connman: Fix comments after @erikarvstedt's comments

+9 -9
+6 -6
pkgs/tools/networking/connman/default.nix
··· 8 8 , libmnl 9 9 , gnutls 10 10 , readline 11 - # Choices one has to decide 11 + # configureable options 12 12 , firewallType ? "iptables" # or "nftables" 13 13 , iptables ? null 14 14 , libnftnl ? null # for nftables ··· 81 81 ++ stdenv.lib.optionals (firewallType == "nftables") [ libnftnl ] 82 82 ; 83 83 84 - # Fix file program not found 84 + # fix invalid path to 'file' 85 85 preConfigure = '' 86 86 sed -i "s/\/usr\/bin\/file/file/g" ./configure 87 87 ''; ··· 99 99 # production build flags 100 100 "--disable-maintainer-mode" 101 101 "--enable-session-policy-local=builtin" 102 - # This is for building and running tests (probably enabled by default), 103 - # --enable-tests installs the tests as well 102 + # for building and running tests 103 + # --enable-tests # installs the tests, we don't want that 104 104 "--enable-tools" 105 105 ] 106 106 ++ stdenv.lib.optionals (!enableLoopback) [ "--disable-loopback" ] ··· 108 108 ++ stdenv.lib.optionals (!enableWireguard) [ "--disable-wireguard" ] 109 109 ++ stdenv.lib.optionals (!enableGadget) [ "--disable-gadget" ] 110 110 ++ stdenv.lib.optionals (!enableWifi) [ "--disable-wifi" ] 111 - # We (almost) always turn on IWD support as it doesn't require any new dependencies 112 - # and it's easier for the NixOS module to use only 1 connmand package when 111 + # enable IWD support for wifi as it doesn't require any new dependencies 112 + # and it's easier for the NixOS module to use only one connman package when 113 113 # IWD is requested 114 114 ++ stdenv.lib.optionals (enableWifi) [ "--enable-iwd" ] 115 115 ++ stdenv.lib.optionals (!enableBluetooth) [ "--disable-bluetooth" ]
+3 -3
pkgs/top-level/all-packages.nix
··· 2559 2559 enablePolkit = false; 2560 2560 enablePptp = false; 2561 2561 enableLoopback = false; 2562 - # enableEthernet = false; 2562 + # enableEthernet = false; # If disabled no ethernet connection can be performed 2563 2563 enableWireguard = false; 2564 2564 enableGadget = false; 2565 - # enableWifi = false; 2565 + # enableWifi = false; # If disabled no WiFi connection can be performed 2566 2566 enableBluetooth = false; 2567 2567 enableOfono = false; 2568 2568 enableDundee = false; ··· 2572 2572 enableTools = false; 2573 2573 enableStats = false; 2574 2574 enableClient = false; 2575 - # enableDatafiles = false; 2575 + # enableDatafiles = false; # If disabled, configuration and data files are not installed 2576 2576 }; 2577 2577 connmanFull = callPackage ../tools/networking/connman { 2578 2578 enableNetworkManager = true;