lol

Update of skype expression: make the use of pulse audio optional based on the configuration setting for pulse audio (off by default).

Removing pulse audio from the build inputs when it is not used prevents the bug of Skype taking 100% cpu from showing up.
This demonstrates nicely nix' features: in other distributions the recomended solution was to remove read permission from the
pulse audio libs.

svn path=/nixpkgs/trunk/; revision=31959

+13 -4
+3 -3
pkgs/applications/networking/skype/default.nix
··· 1 1 { stdenv, fetchurl, alsaLib, libXv, libXi, libXrender, libXrandr, zlib, glib 2 2 , libXext, libX11, libXScrnSaver, libSM, qt4, libICE, freetype, fontconfig 3 - , pulseaudio }: 3 + , pulseaudio, usePulseAudio, lib }: 4 4 5 5 assert stdenv.system == "i686-linux"; 6 6 ··· 12 12 sha256 = "157ba3ci12bq0nv2m8wlsab45ib5sccqagyna8nixnhqw9q72sxm"; 13 13 }; 14 14 15 - buildInputs = [ 15 + buildInputs = 16 + lib.optional usePulseAudio pulseaudio ++ [ 16 17 alsaLib 17 - pulseaudio 18 18 stdenv.glibc 19 19 stdenv.gcc.gcc 20 20 libXv
+10 -1
pkgs/top-level/all-packages.nix
··· 313 313 inherit stdenv; 314 314 }; 315 315 316 + makeAutostartItem = import ../build-support/make-startupitem { 317 + inherit stdenv; 318 + inherit lib; 319 + }; 320 + 316 321 makeInitrd = {contents}: import ../build-support/kernel/make-initrd.nix { 317 322 inherit stdenv perl cpio contents ubootChooser; 318 323 }; ··· 5256 5261 5257 5262 alsaUtils = callPackage ../os-specific/linux/alsa-utils { }; 5258 5263 5264 + microcodeIntel = callPackage ../os-specific/linux/microcode/intel.nix { }; 5265 + 5259 5266 bcm43xx = callPackage ../os-specific/linux/firmware/bcm43xx { }; 5260 5267 5261 5268 bluez = callPackage ../os-specific/linux/bluez { }; ··· 7477 7484 7478 7485 siproxd = callPackage ../applications/networking/siproxd { }; 7479 7486 7480 - skype_linux = callPackage_i686 ../applications/networking/skype { }; 7487 + skype_linux = callPackage_i686 ../applications/networking/skype { 7488 + usePulseAudio = getConfig [ "pulseaudio" ] false; # disabled by default (the 100% cpu bug) 7489 + }; 7481 7490 7482 7491 slim = callPackage ../applications/display-managers/slim { }; 7483 7492