pyrox.dev
lol
Merge pull request #303211 from risicle/ris-check-cherry-picks-empty-lines
check-cherry-picks.sh maintainer script: fix handling of cherry-pick-less branches
authored by
Thomas Gerbet
and committed by
GitHub
b607b942
9207dabe
+5
+5
maintainers/scripts/check-cherry-picks.sh
+5
maintainers/scripts/check-cherry-picks.sh
···
12
12
problem=0
13
13
14
14
while read new_commit_sha ; do
15
+
if [ -z "$new_commit_sha" ] ; then
16
+
continue # skip empty lines
17
+
fi
15
18
if [ "$GITHUB_ACTIONS" = 'true' ] ; then
16
19
echo "::group::Commit $new_commit_sha"
17
20
else
···
57
60
58
61
$range_diff_common --color
59
62
63
+
echo "Note this should not necessarily be treated as a hard fail, but a reviewer's attention should" \
64
+
"be drawn to it and github actions have no way of doing that but to raise a 'failure'"
60
65
problem=1
61
66
else
62
67
echo " ✔ $original_commit_sha highly similar to $new_commit_sha"