lol
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

libtool: fix shebang-fixing from 2.4.7 version bump

Libtool 2.4.7 changed the shebangs in `libtoolize.in` and `ltmain.sh`
from `/bin/sh` (which is a special sandbox exception) to `/usr/bin/env
sh` (which is not).

My PR (#167071) to bump the libtool version adjusted both of these
shebangs, when it should only have adjusted the one in
`libtoolize.in`.

`ltmain.sh` is not a script to be *executed* at
`libtool`-invocation-time. It is a script which is *vendored into a
release* at `libtoolize`-invocation-time.

Thanks to @trofi for reporting this

https://github.com/NixOS/nixpkgs/pull/167071#pullrequestreview-1079484605

+1 -2
+1 -2
pkgs/development/tools/misc/libtool/libtool2.nix
··· 38 38 # libtool commit da2e352735722917bf0786284411262195a6a3f6 changed 39 39 # the shebang from `/bin/sh` (which is a special sandbox exception) 40 40 # to `/usr/bin/env sh`, meaning that we now need to patch shebangs 41 - # in libtoolize and ltmain.sh since `dontPatchShebangs` is set: 41 + # in libtoolize.in: 42 42 '' 43 43 substituteInPlace libtoolize.in --replace '#! /usr/bin/env sh' '#!${runtimeShell}' 44 - substituteInPlace build-aux/ltmain.in --replace '#! /usr/bin/env sh' '#!${runtimeShell}' 45 44 ''; 46 45 47 46 strictDeps = true;