vimUtils: deprecate configure.pathogen (#154814)

pathogen does not bring any value compared to vim native packages so
remove it to ease maintainance burden.

authored by Matthieu Coudron and committed by GitHub a1ad2357 5ed22350

+18 -24
-3
doc/languages-frameworks/vim.section.md
··· 277 277 copy paste output2 here 278 278 ]; 279 279 280 - # Pathogen would be 281 - # vimrcConfig.pathogen.knownPlugins = plugins; # plugins 282 - # vimrcConfig.pathogen.pluginNames = ["tlib"]; 283 280 }; 284 281 ``` 285 282
+8
nixos/doc/manual/from_md/release-notes/rl-2211.section.xml
··· 121 121 this version for the entire lifecycle of the 22.11 release. 122 122 </para> 123 123 </listitem> 124 + <listitem> 125 + <para> 126 + (Neo)Vim can not be configured with 127 + <literal>configure.pathogen</literal> anymore to reduce 128 + maintainance burden. Use <literal>configure.packages</literal> 129 + instead. 130 + </para> 131 + </listitem> 124 132 </itemizedlist> 125 133 </section> 126 134 <section xml:id="sec-release-22.11-notable-changes">
+3
nixos/doc/manual/release-notes/rl-2211.section.md
··· 50 50 - PHP 7.4 is no longer supported due to upstream not supporting this 51 51 version for the entire lifecycle of the 22.11 release. 52 52 53 + - (Neo)Vim can not be configured with `configure.pathogen` anymore to reduce maintainance burden. 54 + Use `configure.packages` instead. 55 + 53 56 <!-- To avoid merge conflicts, consider adding your item at an arbitrary place in the list instead. --> 54 57 55 58 ## Other Notable Changes {#sec-release-22.11-notable-changes}
+2 -2
pkgs/applications/editors/neovim/tests.nix
··· 150 150 # and do `:call deoplete#enable()`. It will print an error if the remote 151 151 # plugin is not registered. 152 152 test_nvim_with_remote_plugin = neovim.override { 153 - extraName = "-pathogen-remote"; 154 - configure.pathogen.pluginNames = with vimPlugins; [ deoplete-nvim ]; 153 + extraName = "-remote"; 154 + configure.packages.foo.start = with vimPlugins; [ deoplete-nvim ]; 155 155 }; 156 156 157 157 # only neovim makes use of `requiredPlugins`, test this here
+5 -14
pkgs/applications/editors/vim/plugins/vim-utils.nix
··· 51 51 # full documentation at github.com/MarcWeber/vim-addon-manager 52 52 ]; 53 53 54 - # there is a pathogen implementation as well, but its startup is slower and [VAM] has more feature 55 - # vimrcConfig.pathogen.knownPlugins = vimPlugins; # optional 56 - # vimrcConfig.pathogen.pluginNames = ["vim-addon-nix"]; 57 54 }; 58 55 59 56 WHAT IS A VIM PLUGIN? ··· 103 100 contribute to vim-pi so that plugins can be updated automatically. 104 101 105 102 106 - CREATING DERVITATIONS AUTOMATICALLY BY PLUGIN NAME 103 + CREATING DERIVATIONS AUTOMATICALLY BY PLUGIN NAME 107 104 ================================================== 108 105 Most convenient is to use a ~/.vim-scripts file putting a plugin name into each line 109 106 as documented by [VAM]'s README.md ··· 277 274 }: 278 275 279 276 let 280 - /* pathogen mostly can set &rtp at startup time. Its used very commonly. 277 + /* pathogen mostly can set &rtp at startup time. Deprecated. 281 278 */ 282 279 pathogenImpl = let 283 280 knownPlugins = pathogen.knownPlugins or vimPlugins; 284 281 285 282 plugins = findDependenciesRecursively (map (pluginToDrv knownPlugins) pathogen.pluginNames); 286 283 287 - pluginsEnv = buildEnv { 288 - name = "pathogen-plugin-env"; 289 - paths = map (x: "${x}/${rtpPath}") plugins; 284 + pathogenPackages.pathogen = lib.warn "'pathogen' attribute is deprecated. Use 'packages' instead in your vim configuration" { 285 + start = plugins; 290 286 }; 291 287 in 292 - '' 293 - let &rtp.=(empty(&rtp)?"":',')."${vimPlugins.vim-pathogen.rtp}" 294 - execute pathogen#infect('${pluginsEnv}/{}') 295 - 296 - filetype indent plugin on | syn on 297 - ''; 288 + nativeImpl pathogenPackages; 298 289 299 290 /* vim-plug is an extremely popular vim plugin manager. 300 291 */
-5
pkgs/test/vim/default.nix
··· 23 23 vimrcConfig.vam.pluginDictionaries = [{name = "vim-nix"; }]; 24 24 }; 25 25 26 - test_vim_with_vim_nix_using_pathogen = vim_configurable.customize { 27 - name = "vim-with-vim-addon-nix-using-pathogen"; 28 - vimrcConfig.pathogen.pluginNames = [ "vim-nix" ]; 29 - }; 30 - 31 26 test_vim_with_vim_nix_using_plug = vim_configurable.customize { 32 27 name = "vim-with-vim-addon-nix-using-plug"; 33 28 vimrcConfig.plug.plugins = with vimPlugins; [ vim-nix ];