helm: fix #79177 on linux (#137146)

* helm: replace /usr/share reference with $out/share

with the stock path helm will always determine that it is not installed
properly and thus refuse to save/load settings, preset and builtin presets.

* helm: remove buildPhase

the default is adequate since using `make install` during installPhase will
build the remaining targets anyway.

* helm: enable parallel builds

* helm: fix package lints

authored by

pennae and committed by
GitHub
9ad5029b cdb48d75

+6 -11
+6 -11
pkgs/applications/audio/helm/default.nix
··· 26 26 buildInputs = [ 27 27 xorg.libX11 xorg.libXcomposite xorg.libXcursor xorg.libXext 28 28 xorg.libXinerama xorg.libXrender xorg.libXrandr 29 - freetype alsa-lib curl libjack2 pkg-config libGLU libGL lv2 29 + freetype alsa-lib curl libjack2 libGLU libGL lv2 30 30 ]; 31 + nativeBuildInputs = [ pkg-config ]; 31 32 32 33 CXXFLAGS = "-DHAVE_LROUND"; 34 + enableParallelBuilding = true; 35 + makeFlags = [ "DESTDIR=$(out)" ]; 33 36 34 37 patches = [ 35 38 # gcc9 compatibility https://github.com/mtytel/helm/pull/233 ··· 41 44 42 45 prePatch = '' 43 46 sed -i 's|usr/||g' Makefile 44 - ''; 45 - 46 - buildPhase = '' 47 - make lv2 48 - make standalone 49 - ''; 50 - 51 - installPhase = '' 52 - make DESTDIR="$out" install 47 + sed -i "s|/usr/share/|$out/share/|" src/common/load_save.cpp 53 48 ''; 54 49 55 50 meta = with lib; { ··· 72 67 Simple arpeggiator 73 68 Effects: Formant filter, stutter, delay 74 69 ''; 75 - license = lib.licenses.gpl3; 70 + license = lib.licenses.gpl3Plus; 76 71 maintainers = [ maintainers.magnetophon ]; 77 72 platforms = platforms.linux; 78 73 };