libtiff: switch back to CMake

Since libwebp was switched to CMake, the .la files that told static
builds which libraries had to be linked with libwebp are no longer
generated, breaking static builds. By switching libtiff to CMake too,
we can use the CMake files instead. (This is necessary, but not
sufficient, for static builds to work — a further patch is required.)

This was tried once before (in 96d50327bc59 ("libtiff: export private
headers for freeimage")), and I reverted it (in
5df9305b60d5 ("libtiff: fix cross by switching back to autoconf")),
because at the time, it broke cross compilation of libtiff. Things
seem to have settled since then, and this now cross compiles
correctly.

Fixes: 909c49149371 ("libwebp: build with CMake")

pkgs/by-name/li/libtiff/headers.patch

···
-export private headers for freeimage
---- i/libtiff/Makefile.am
-+++ w/libtiff/Makefile.am
-@@ -36,8 +36,12 @@ EXTRA_DIST = \
- 	tif_win32_versioninfo.rc
-
- libtiffinclude_HEADERS = \
-+	tif_config.h \
-+	tif_dir.h \
-+	tif_hash_set.h \
- 	tiff.h \
- 	tiffio.h \
-+	tiffiop.h \
- 	tiffvers.h
-
- if HAVE_CXX

pkgs/by-name/li/libtiff/package.nix

···
   fetchpatch,
   nix-update-script,
 
-  autoreconfHook,
+  cmake,
   pkg-config,
   sphinx,
 
···
   };
 
   patches = [
-    # FreeImage needs this patch
-    ./headers.patch
     # libc++abi 11 has an `#include <version>`, this picks up files name
     # `version` in the project's include paths
     ./rename-version.patch
···
   ];
 
   postFixup = ''
-    moveToOutput include/tif_config.h $dev_private
-    moveToOutput include/tif_dir.h $dev_private
-    moveToOutput include/tif_hash_set.h $dev_private
-    moveToOutput include/tiffiop.h $dev_private
+    mkdir -p $dev_private/include
+    mv -t $dev_private/include \
+      libtiff/tif_config.h \
+      ../libtiff/tif_dir.h \
+      ../libtiff/tif_hash_set.h \
+      ../libtiff/tiffiop.h
   '';
 
-  # If you want to change to a different build system, please make
-  # sure cross-compilation works first!
   nativeBuildInputs = [
-    autoreconfHook
+    cmake
     pkg-config
     sphinx
   ];
···
     xz
     zlib
     zstd
+  ];
+
+  cmakeFlags = [
+    "-DCMAKE_FIND_PACKAGE_PREFER_CONFIG=ON"
   ];
 
   enableParallelBuilding = true;

pkgs/by-name/li/libtiff/rename-version.patch

···
-fix case-insensitive build
---- a/Makefile.am
-+++ b/Makefile.am
-@@ -34,7 +34,7 @@ docfiles = \
- 	README.md \
- 	RELEASE-DATE \
- 	TODO \
--	VERSION
-+	VERSION.txt
+diff --git a/cmake/AutotoolsVersion.cmake b/cmake/AutotoolsVersion.cmake
+index f93f5cf0..fd33df59 100644
+--- a/cmake/AutotoolsVersion.cmake
++++ b/cmake/AutotoolsVersion.cmake
+@@ -41,7 +41,7 @@ set(LIBTIFF_VERSION "${LIBTIFF_MAJOR_VERSION}.${LIBTIFF_MINOR_VERSION}.${LIBTIFF
+ set(LIBTIFF_VERSION_FULL "${LIBTIFF_VERSION}${LIBTIFF_ALPHA_VERSION}")
  
- EXTRA_DIST = \
- 	placeholder.h \
-@@ -68,7 +68,7 @@ NEW_LIBTIFF_RELEASE_DATE=$(shell date +"%Y%m%d")
- release:
- 	@(echo --- Setting release date to $(NEW_LIBTIFF_RELEASE_DATE) and release version to $(LIBTIFF_VERSION) ---)
- 	(rm -f $(top_srcdir)/RELEASE-DATE && echo $(NEW_LIBTIFF_RELEASE_DATE) > $(top_srcdir)/RELEASE-DATE)
--	(rm -f $(top_srcdir)/VERSION && echo $(LIBTIFF_VERSION) > $(top_srcdir)/VERSION)
-+	(rm -f $(top_srcdir)/VERSION && echo $(LIBTIFF_VERSION) > $(top_srcdir)/VERSION.txt)
- 	(rm -f $(top_builddir)/libtiff/tiffvers.h && sed 's,LIBTIFF_VERSION,$(LIBTIFF_VERSION),;s,LIBTIFF_RELEASE_DATE,$(NEW_LIBTIFF_RELEASE_DATE),;s,LIBTIFF_MAJOR_VERSION,$(LIBTIFF_MAJOR_VERSION),;s,LIBTIFF_MINOR_VERSION,$(LIBTIFF_MINOR_VERSION),;s,LIBTIFF_MICRO_VERSION,$(LIBTIFF_MICRO_VERSION),' $(top_srcdir)/libtiff/tiffvers.h.in > $(top_builddir)/libtiff/tiffvers.h && sed -i 's,@,,g' $(top_builddir)/libtiff/tiffvers.h)
+ # Get release version from file VERSION
+-FILE(STRINGS "${CMAKE_CURRENT_SOURCE_DIR}/VERSION" LIBTIFF_RELEASE_VERSION)
++FILE(STRINGS "${CMAKE_CURRENT_SOURCE_DIR}/VERSION.txt" LIBTIFF_RELEASE_VERSION)
  
- pkgconfigdir = $(libdir)/pkgconfig
+ # Package date - get it from file RELEASE-DATE
+ FILE(STRINGS "${CMAKE_CURRENT_SOURCE_DIR}/RELEASE-DATE" LIBTIFF_RELEASE_DATE)