lol

gnome2.ORBit2: fix the build against `gcc-14`

Without the change the build fails as
https://hydra.nixos.org/build/282732612:

configure: error:
Linking is badly borked on your system. Please ensure your library path is correct
Check config.log for details - check near the end of the log above 'failed program was'

It happens because `gcc-14` defaults to `-Werror=implicit-int`. There is
no easy way to jst regenerate `./configure` as it is not compatible with
`automake-1.13` or above.

Let' flip the `-Werror=` switches back before `gnome2.ORBit2` gets
removed from `nixpkgs`.

Closes: https://github.com/NixOS/nixpkgs/issues/367694

+9
+9
pkgs/desktops/gnome-2/platform/ORBit2/default.nix
··· 38 38 "dev" 39 39 ]; 40 40 41 + env.NIX_CFLAGS_COMPILE = toString ( 42 + lib.optionals (stdenv.cc.isGNU && (lib.versionAtLeast (lib.getVersion stdenv.cc.cc) "14")) [ 43 + # the ./configure script is not compatible with gcc-14, not easy to 44 + # regenerate without porting: https://github.com/NixOS/nixpkgs/issues/367694 45 + "-Wno-error=implicit-int" 46 + "-Wno-error=incompatible-pointer-types" 47 + ] 48 + ); 49 + 41 50 configureFlags = lib.optionals (stdenv.buildPlatform != stdenv.hostPlatform) [ 42 51 "--with-idl-compiler=${lib.getExe' buildPackages.gnome2.ORBit2 "orbit-idl-2"}" 43 52 # https://github.com/void-linux/void-packages/blob/e5856e02aa6ef7e4f2725afbff2915f89d39024b/srcpkgs/ORBit2/template#L17-L35