pyrox.dev
mps: fix `gcc-13` build failure by dropping `-Werror`
Without the change build fails on `master` as
https://hydra.nixos.org/build/249125931:
ss.c: In function 'StackHot':
ss.c:38:13: error: storing the address of local variable 'stackOut' in '*stackOut' [-Werror=dangling-pointer=8]
38 | *stackOut = &stackOut;
| ~~~~~~~~~~^~~~~~~~~~~
Blanket `-Werror` tends to break with minor toolchain and dependency
changes. It's a reasonable option to test upstream and use downstream
only if upstream is quick at addressing builds failures. `gcc-13` is
almost a year old.
+8
-8
pkgs/development/libraries/mps/default.nix
+8
-8
pkgs/development/libraries/mps/default.nix
···
16
16
hash = "sha256-3ql3jWLccgnQHKf23B1en+nJ9rxqmHcWd7aBr93YER0=";
17
17
};
18
18
19
+
postPatch = ''
20
+
# Disable -Werror to avoid biuld failure on fresh toolchains like
21
+
# gcc-13.
22
+
substituteInPlace code/gc.gmk --replace-fail '-Werror ' ' '
23
+
substituteInPlace code/gp.gmk --replace-fail '-Werror ' ' '
24
+
substituteInPlace code/ll.gmk --replace-fail '-Werror ' ' '
25
+
'';
26
+
19
27
nativeBuildInputs = [ autoreconfHook ];
20
28
buildInputs = [ sqlite ];
21
-
22
-
# needed for 1.116.0 to build with gcc7
23
-
env.NIX_CFLAGS_COMPILE = toString [
24
-
"-Wno-implicit-fallthrough"
25
-
"-Wno-error=clobbered"
26
-
"-Wno-error=cast-function-type"
27
-
];
28
-
29
29
30
30
meta = {
31
31
description = "A flexible memory management and garbage collection library";