pyrox.dev
libtiff: don't propagate unnecessary build inputs
authored by
Ivan Mincik
and committed by
+11
-16
pkgs/by-name/li/libtiff/package.nix
+11
-16
pkgs/by-name/li/libtiff/package.nix
···
16
16
zlib,
17
17
zstd,
18
18
19
-
# Because lerc is C++ and static libraries don't track dependencies,
20
-
# that every downstream dependent of libtiff has to link with a C++
21
-
# compiler, or the C++ standard library won't be linked, resulting
22
-
# in undefined symbol errors. Without systematic support for this
23
-
# in build systems, fixing this would require modifying the build
24
-
# system of every libtiff user. Hopefully at some point build
19
+
# Because lerc is C++ and static libraries don't track dependencies, every downstream dependent of
20
+
# libtiff has to link with a C++ compiler, or the C++ standard library won't be linked, resulting
21
+
# in undefined symbol errors. Without systematic support for this in build systems, fixing this
22
+
# would require modifying the build system of every libtiff user. Hopefully at some point build
25
23
# systems will figure this out, and then we can enable this.
26
24
#
27
25
# See https://github.com/mesonbuild/meson/issues/14234
···
84
82
];
85
83
86
84
buildInputs = [
87
-
zstd
88
-
]
89
-
++ lib.optionals withLerc [
90
-
lerc
91
-
];
92
-
93
-
# TODO: opengl support (bogus configure detection)
94
-
propagatedBuildInputs = [
95
85
libdeflate
96
86
libjpeg
97
-
# libwebp depends on us; this will cause infinite
98
-
# recursion otherwise
87
+
# libwebp depends on us; this will cause infinite recursion otherwise
99
88
(libwebp.override { tiffSupport = false; })
100
89
xz
101
90
zlib
102
91
zstd
92
+
]
93
+
++ lib.optionals withLerc [
94
+
lerc
103
95
];
104
96
105
97
cmakeFlags = [
···
109
101
enableParallelBuilding = true;
110
102
111
103
doCheck = true;
104
+
112
105
# Avoid flakiness like https://gitlab.com/libtiff/libtiff/-/commit/94f6f7315b1
113
106
enableParallelChecking = false;
114
107
···
122
115
openimageio
123
116
freeimage
124
117
;
118
+
125
119
inherit (python3Packages) pillow imread;
120
+
126
121
pkg-config = testers.hasPkgConfigModules {
127
122
package = finalAttrs.finalPackage;
128
123
};