pyrox.dev
nixos/libvirt: fix shellcheck findings with enableStrictShellChecks enabled (#349620)
+6
-6
nixos/modules/virtualisation/libvirtd.nix
+6
-6
nixos/modules/virtualisation/libvirtd.nix
···
426
426
libvirt/qemu/networks/*.xml \
427
427
libvirt/nwfilter/*.xml );
428
428
do
429
-
mkdir -p /var/lib/$(dirname $i) -m 755
430
-
if [ ! -e /var/lib/$i ]; then
431
-
cp -pd ${cfg.package}/var/lib/$i /var/lib/$i
429
+
# Intended behavior
430
+
# shellcheck disable=SC2174
431
+
mkdir -p "/var/lib/$(dirname "$i")" -m 755
432
+
if [ ! -e "/var/lib/$i" ]; then
433
+
cp -pd "${cfg.package}/var/lib/$i" "/var/lib/$i"
432
434
fi
433
435
done
434
436
···
440
442
ln -s --force "$emulator" /run/${dirName}/nix-emulators/
441
443
done
442
444
443
-
for helper in bin/qemu-pr-helper; do
444
-
ln -s --force ${cfg.qemu.package}/$helper /run/${dirName}/nix-helpers/
445
-
done
445
+
ln -s --force ${cfg.qemu.package}/bin/qemu-pr-helper /run/${dirName}/nix-helpers/
446
446
447
447
${optionalString cfg.qemu.ovmf.enable (let
448
448
ovmfpackage = pkgs.buildEnv {