spike: move test to installCheck phase (#143832)

Co-authored-by: Sandro <[e-mail]>

nixos/tests/all-tests.nix

···
   sonarr = handleTest ./sonarr.nix {};
   spacecookie = handleTest ./spacecookie.nix {};
   spark = handleTestOn ["x86_64-linux"] ./spark {};
-  spike = handleTest ./spike.nix {};
   sslh = handleTest ./sslh.nix {};
   sssd = handleTestOn ["x86_64-linux"] ./sssd.nix {};
   sssd-ldap = handleTestOn ["x86_64-linux"] ./sssd-ldap.nix {};

nixos/tests/spike.nix

···
-import ./make-test-python.nix ({ pkgs, ... }:
-
-let
-  riscvPkgs = import ../.. { crossSystem = pkgs.lib.systems.examples.riscv64-embedded; };
-in
-{
-  name = "spike";
-  meta = with pkgs.lib.maintainers; { maintainers = [ blitz ]; };
-
-  machine = { pkgs, lib, ... }: {
-    environment.systemPackages = [ pkgs.spike riscvPkgs.riscv-pk riscvPkgs.hello ];
-  };
-
-  # Run the RISC-V hello applications using the proxy kernel on the
-  # Spike emulator and see whether we get the expected output.
-  testScript =
-    ''
-      machine.wait_for_unit("multi-user.target")
-      output = machine.succeed("spike -m64 $(which pk) $(which hello)")
-      assert "Hello, world!" in output
-    '';
-})

pkgs/applications/virtualization/spike/default.nix

···
-{ lib, stdenv, fetchgit, dtc, nixosTests, fetchpatch }:
+{ lib, stdenv, fetchgit, dtc, fetchpatch }:
 
 stdenv.mkDerivation rec {
   pname = "spike";
···
 
   doCheck = true;
 
-  passthru.tests = {
-    can-run-hello-world = nixosTests.spike;
-  };
+  # To test whether spike is working, we run the RISC-V hello applications using the RISC-V proxy
+  # kernel on the Spike emulator and see whether we get the expected output.
+  doInstallCheck = true;
+  installCheckPhase =
+    let
+      riscvPkgs = import ../../../.. { crossSystem = lib.systems.examples.riscv64-embedded; };
+    in
+    ''
+      runHook preInstallCheck
+
+      $out/bin/spike -m64 ${riscvPkgs.riscv-pk}/bin/pk ${riscvPkgs.hello}/bin/hello | grep -Fq "Hello, world"
+
+      runHook postInstallCheck
+    '';
 
   meta = with lib; {
     description = "A RISC-V ISA Simulator";