CONTRIBUTING: discourage style reviews not based on written rules (#445898)

authored by Wolfgang Walther and committed by GitHub 60f7ec82 08daa34e

+6
+6
CONTRIBUTING.md
··· 661 As an exception, an explicit conditional expression with null can be used when fixing a important bug without triggering a mass rebuild. 662 If this is done a follow up pull request _should_ be created to change the code to `lib.optional(s)`. 663 664 # Practical contributing advice 665 666 To contribute effectively and efficiently, you need to be aware of how the process generally works.
··· 661 As an exception, an explicit conditional expression with null can be used when fixing a important bug without triggering a mass rebuild. 662 If this is done a follow up pull request _should_ be created to change the code to `lib.optional(s)`. 663 664 + - Any style choices not covered here but that can be expressed as general rules should be left at the discretion of the authors of changes and _not_ commented in reviews. 665 + The purpose of this is: 666 + - to avoid churn as contributors with different style preferences undo each other's changes, 667 + - to ensure that style rules are written down and consistent (and can thus be followed when authoring changes, reducing review cycles), 668 + - and to encourage reviews to focus on more impactful considerations. 669 + 670 # Practical contributing advice 671 672 To contribute effectively and efficiently, you need to be aware of how the process generally works.