treewide: migrate git python packages to by-name (#427531)

pkgs/applications/version-management/git-archive-all/default.nix pkgs/by-name/gi/git-archive-all/package.nix

···
 {
   lib,
-  buildPythonApplication,
+  python3Packages,
   fetchFromGitHub,
   git,
-  pytestCheckHook,
-  pytest-cov-stub,
-  pytest-mock,
 }:
 
-buildPythonApplication rec {
+python3Packages.buildPythonApplication rec {
   pname = "git-archive-all";
   version = "1.23.1";
   format = "setuptools";
···
   src = fetchFromGitHub {
     owner = "Kentzo";
     repo = "git-archive-all";
-    rev = version;
+    tag = version;
     hash = "sha256-fIPjggOx+CEorj1bazz8s81ZdppkTL0OlA5tRqCYZyc=";
   };
 
···
     git
   ];
 
-  checkInputs = [
+  checkInputs = with python3Packages; [
     pytestCheckHook
     pytest-cov-stub
     pytest-mock
···
     export HOME="$(mktemp -d)"
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Archive a repository with all its submodules";
     longDescription = ''
       A python script wrapper for git-archive that archives a git superproject
       and its submodules, if it has any. Takes into account .gitattributes
     '';
     homepage = "https://github.com/Kentzo/git-archive-all";
-    license = licenses.mit;
-    maintainers = with maintainers; [ fgaz ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ fgaz ];
     mainProgram = "git-archive-all";
   };
 }

pkgs/applications/version-management/git-imerge/default.nix pkgs/by-name/gi/git-imerge/package.nix

···
 {
   lib,
-  buildPythonApplication,
+  python3Packages,
   fetchPypi,
   installShellFiles,
 }:
 
-buildPythonApplication rec {
+python3Packages.buildPythonApplication rec {
   pname = "git-imerge";
   version = "1.2.0";
   format = "setuptools";
···
     installShellCompletion --bash completions/git-imerge
   '';
 
-  meta = with lib; {
+  meta = {
     homepage = "https://github.com/mhagger/git-imerge";
     description = "Perform a merge between two branches incrementally";
-    license = licenses.gpl2Plus;
-    maintainers = [ ];
+    license = lib.licenses.gpl2Plus;
+    maintainers = with lib.maintainers; [ ];
     mainProgram = "git-imerge";
   };
 }

pkgs/applications/version-management/git-publish/default.nix pkgs/by-name/gi/git-publish/package.nix

···
 {
   lib,
   stdenv,
-  python,
+  python3,
   perl,
   fetchFromGitHub,
   installShellFiles,
 }:
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "git-publish";
   version = "1.8.2";
 
   src = fetchFromGitHub {
     owner = "stefanha";
     repo = "git-publish";
-    rev = "v${version}";
+    tag = "v${finalAttrs.version}";
     hash = "sha256-jjpbr+ZqG4U8/z0PurnXR+IUKQkG3QB8YqhDkH8uu2Y=";
   };
 
···
     perl
     installShellFiles
   ];
-  buildInputs = [ python ];
+  buildInputs = [ python3 ];
 
   installPhase = ''
     runHook preInstall
···
     homepage = "https://github.com/stefanha/git-publish";
     mainProgram = "git-publish";
   };
-}
+})

pkgs/applications/version-management/git-repo-updater/default.nix

···
-{
-  lib,
-  buildPythonApplication,
-  hatchling,
-  colorama,
-  fetchPypi,
-  gitpython,
-}:
-
-buildPythonApplication rec {
-  pname = "gitup";
-  version = "0.5.2";
-  pyproject = true;
-
-  src = fetchPypi {
-    inherit pname version;
-    sha256 = "sha256-51DWPJ9JOMrRdWGaiiL4qzo4VFFeT1rG5yyI6Ej+ZRw=";
-  };
-
-  build-system = [ hatchling ];
-  propagatedBuildInputs = [
-    colorama
-    gitpython
-  ];
-
-  # no tests
-  doCheck = false;
-
-  meta = with lib; {
-    description = "Easily update multiple Git repositories at once";
-    homepage = "https://github.com/earwig/git-repo-updater";
-    license = licenses.mit;
-    maintainers = with maintainers; [
-      bdesham
-      artturin
-    ];
-    mainProgram = "gitup";
-  };
-}

pkgs/applications/version-management/git-review/default.nix pkgs/by-name/gi/git-review/package.nix

···
 {
   lib,
-  buildPythonApplication,
+  python3Packages,
   fetchgit,
-  pbr,
-  requests,
-  setuptools,
   gitUpdater,
 }:
 
-buildPythonApplication rec {
+python3Packages.buildPythonApplication rec {
   pname = "git-review";
   version = "2.5.0";
   format = "setuptools";
 
-  # Manually set version because prb wants to get it from the git
+  # Manually set version because pbr wants to get it from the git
   # upstream repository (and we are installing from tarball instead)
   PBR_VERSION = version;
 
···
     "man"
   ];
 
-  nativeBuildInputs = [
+  nativeBuildInputs = with python3Packages; [
     pbr
   ];
 
-  propagatedBuildInputs = [
+  dependencies = with python3Packages; [
     requests
     setuptools # implicit dependency, used to get package version through pkg_resources
   ];
···
 
   passthru.updateScript = gitUpdater { };
 
-  meta = with lib; {
+  meta = {
     description = "Tool to submit code to Gerrit";
     homepage = "https://opendev.org/opendev/git-review";
     changelog = "https://docs.opendev.org/opendev/git-review/latest/releasenotes.html#relnotes-${version}";
-    license = licenses.asl20;
-    maintainers = with maintainers; [ kira-bruneau ];
+    license = lib.licenses.asl20;
+    maintainers = with lib.maintainers; [ kira-bruneau ];
     mainProgram = "git-review";
   };
 }

pkgs/by-name/gi/git-repo-updater/package.nix

···
+{
+  lib,
+  python3Packages,
+  fetchPypi,
+}:
+
+python3Packages.buildPythonApplication rec {
+  pname = "gitup";
+  version = "0.5.2";
+  pyproject = true;
+
+  src = fetchPypi {
+    inherit pname version;
+    hash = "sha256-51DWPJ9JOMrRdWGaiiL4qzo4VFFeT1rG5yyI6Ej+ZRw=";
+  };
+
+  build-system = with python3Packages; [ hatchling ];
+  dependencies = with python3Packages; [
+    colorama
+    gitpython
+  ];
+
+  # no tests
+  doCheck = false;
+
+  meta = {
+    description = "Easily update multiple Git repositories at once";
+    homepage = "https://github.com/earwig/git-repo-updater";
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [
+      bdesham
+      artturin
+    ];
+    mainProgram = "gitup";
+  };
+}

pkgs/top-level/all-packages.nix

···
     python3Packages.callPackage ../applications/version-management/git-annex-remote-googledrive
       { };
 
-  git-archive-all = python3.pkgs.callPackage ../applications/version-management/git-archive-all { };
-
   git-credential-manager = callPackage ../applications/version-management/git-credential-manager { };
-
-  git-imerge = python3Packages.callPackage ../applications/version-management/git-imerge { };
-
-  git-publish = python3Packages.callPackage ../applications/version-management/git-publish { };
 
   git-recent = callPackage ../applications/version-management/git-recent {
     util-linux = if stdenv.hostPlatform.isLinux then util-linuxMinimal else util-linux;
   };
 
   gitRepo = git-repo;
-  git-repo-updater =
-    python3Packages.callPackage ../applications/version-management/git-repo-updater
-      { };
-
-  git-review = python3Packages.callPackage ../applications/version-management/git-review { };
 
   gittyup = libsForQt5.callPackage ../applications/version-management/gittyup { };