lol

qt5: debug flag should never be null

+10 -12
+1 -1
pkgs/development/libraries/qt-5/5.10/default.nix
··· 24 24 # options 25 25 developerBuild ? false, 26 26 decryptSslTraffic ? false, 27 - debug ? null, 27 + debug ? false, 28 28 }: 29 29 30 30 with stdenv.lib;
+1 -1
pkgs/development/libraries/qt-5/5.6/default.nix
··· 33 33 # options 34 34 developerBuild ? false, 35 35 decryptSslTraffic ? false, 36 - debug ? null, 36 + debug ? false, 37 37 }: 38 38 39 39 with stdenv.lib;
+1 -1
pkgs/development/libraries/qt-5/5.9/default.nix
··· 24 24 # options 25 25 developerBuild ? false, 26 26 decryptSslTraffic ? false, 27 - debug ? null, 27 + debug ? false, 28 28 }: 29 29 30 30 with stdenv.lib;
+7 -9
pkgs/development/libraries/qt-5/mkDerivation.nix
··· 11 11 12 12 qmakeFlags = 13 13 (args.qmakeFlags or []) 14 - ++ optional (debug != null) 15 - (if debug then "CONFIG+=debug" else "CONFIG+=release"); 14 + ++ [ ("CONFIG+=" + (if debug then "debug" else "release")) ]; 16 15 17 16 NIX_CFLAGS_COMPILE = 18 - let arg = args.NIX_CFLAGS_COMPILE or []; in 19 - optional (debug == true) "-DQT_NO_DEBUG" 20 - ++ (if builtins.isList arg then arg else [arg]); 17 + optional (!debug) "-DQT_NO_DEBUG" 18 + ++ lib.toList (args.NIX_CFLAGS_COMPILE or []); 21 19 22 20 cmakeFlags = 23 21 (args.cmakeFlags or []) 24 - ++ [ "-DBUILD_TESTING=OFF" ] 25 - ++ optional (debug != null) 26 - (if debug then "-DCMAKE_BUILD_TYPE=Debug" 27 - else "-DCMAKE_BUILD_TYPE=Release"); 22 + ++ [ 23 + "-DBUILD_TESTING=OFF" 24 + ("-DCMAKE_BUILD_TYPE=" + (if debug then "Debug" else "Release")) 25 + ]; 28 26 29 27 enableParallelBuilding = args.enableParallelBuilding or true; 30 28