lol

pe-parse: drop `no-sign-conversion` compile flag

Upstream has merged a patch to fix the issue so we can use that instead
of being lax when compiling.

+8 -4
+8 -4
pkgs/development/libraries/pe-parse/default.nix
··· 1 - { stdenv, lib, fetchFromGitHub, cmake }: 1 + { stdenv, lib, fetchFromGitHub, cmake, fetchpatch }: 2 2 3 3 stdenv.mkDerivation rec { 4 4 pname = "pe-parse"; ··· 11 11 hash = "sha256-HwWlMRhpB/sa/JRyAZF7LZzkXCCyuxB+gtDAfHt7e6k="; 12 12 }; 13 13 14 - nativeBuildInputs = [ cmake ]; 14 + patches = [ 15 + (fetchpatch { 16 + url = "https://github.com/trailofbits/pe-parse/commit/eecdb3d36eb44e306398a2e66e85490f9bdcc74c.patch"; 17 + hash = "sha256-pd6D/JMctiQqJxnJU9Nm/GDVf4/CaIGeXx1UfdcCupo="; 18 + }) 19 + ]; 15 20 16 - # See https://github.com/trailofbits/pe-parse/issues/169 17 - NIX_CFLAGS_COMPILE = "-Wno-sign-conversion"; 21 + nativeBuildInputs = [ cmake ]; 18 22 19 23 doInstallCheck = true; 20 24 installCheckPhase = ''