lol
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Merge pull request #301555 from fabaff/pynetdicom-fix

python312Packages.pynetdicom: disable failing tests on Python 3.12

authored by

Fabian Affolter and committed by
GitHub
436699df 23fae009

+31 -19
+31 -19
pkgs/development/python-modules/pynetdicom/default.nix
··· 1 - { lib 2 - , stdenv 3 - , buildPythonPackage 4 - , fetchFromGitHub 5 - , fetchpatch 6 - , pydicom 7 - , pyfakefs 8 - , pytestCheckHook 9 - , sqlalchemy 10 - , pythonOlder 1 + { 2 + lib, 3 + stdenv, 4 + buildPythonPackage, 5 + fetchFromGitHub, 6 + fetchpatch, 7 + pydicom, 8 + pyfakefs, 9 + pytestCheckHook, 10 + pythonAtLeast, 11 + pythonOlder, 12 + setuptools, 13 + sqlalchemy, 11 14 }: 12 15 13 16 buildPythonPackage rec { 14 17 pname = "pynetdicom"; 15 18 version = "2.0.2"; 16 - format = "setuptools"; 19 + pyproject = true; 17 20 18 21 disabled = pythonOlder "3.7"; 19 22 20 23 src = fetchFromGitHub { 21 24 owner = "pydicom"; 22 - repo = pname; 23 - rev = "v${version}"; 25 + repo = "pynetdicom"; 26 + rev = "refs/tags/v${version}"; 24 27 hash = "sha256-/JWQUtFBW4uqCbs/nUxj1pRBfTCXV4wcqTkqvzpdFrM="; 25 28 }; 26 29 ··· 29 32 name = "fix-python-3.11-test-attribute-errors"; 30 33 url = "https://github.com/pydicom/pynetdicom/pull/754/commits/2126bd932d6dfb3f07045eb9400acb7eaa1b3069.patch"; 31 34 hash = "sha256-t6Lg0sTZSWIE5q5pkBvEoHDQ+cklDn8SgNBcFk1myp4="; 32 - }) 35 + }) 33 36 ]; 34 37 35 - propagatedBuildInputs = [ 36 - pydicom 37 - ]; 38 + build-system = [ setuptools ]; 39 + 40 + dependencies = [ pydicom ]; 38 41 39 42 nativeCheckInputs = [ 40 43 pyfakefs ··· 72 75 disabledTestPaths = [ 73 76 # Ignore apps tests 74 77 "pynetdicom/apps/tests/" 78 + ] ++ lib.optionals (pythonAtLeast "3.12") [ 79 + # https://github.com/pydicom/pynetdicom/issues/924 80 + "pynetdicom/tests/test_assoc.py" 81 + "pynetdicom/tests/test_transport.py" 75 82 ]; 76 83 77 - pythonImportsCheck = [ 78 - "pynetdicom" 84 + pythonImportsCheck = [ "pynetdicom" ]; 85 + 86 + pytestFlagsArray = [ 87 + # https://github.com/pydicom/pynetdicom/issues/923 88 + "-W" 89 + "ignore::pytest.PytestRemovedIn8Warning" 79 90 ]; 80 91 81 92 meta = with lib; { 82 93 description = "Python implementation of the DICOM networking protocol"; 83 94 homepage = "https://github.com/pydicom/pynetdicom"; 95 + changelog = "https://github.com/pydicom/pynetdicom/releases/tag/v${version}"; 84 96 license = with licenses; [ mit ]; 85 97 maintainers = with maintainers; [ fab ]; 86 98 # Tests are not passing on Darwin/Aarch64, thus it's assumed that it doesn't work