pyrox.dev / nixpkgs
lol
fork atom

Merge pull request #259361 from doronbehar/pkg/transmission

transmission_4: fix darwin build

authored by

Doron Behar and committed by
GitHub 34d8d08f 51bc5df8

+12 -15
unified split
+5 -7
pkgs/applications/networking/p2p/transmission/4.nix
··· 21 21 , dht 22 22 , libnatpmp 23 23 , libiconv 24 - , darwin 24 + , Foundation 25 25 # Build options 26 26 , enableGTK3 ? false 27 27 , gtkmm3 ··· 37 37 , apparmorRulesFromClosure 38 38 }: 39 39 40 - stdenv.mkDerivation rec { 40 + stdenv.mkDerivation (finalAttrs: { 41 41 pname = "transmission"; 42 42 version = "4.0.4"; 43 43 44 44 src = fetchFromGitHub { 45 45 owner = "transmission"; 46 46 repo = "transmission"; 47 - rev = version; 47 + rev = finalAttrs.version; 48 48 hash = "sha256-Sz3+5VvfOgET1aiormEnBOrF+yN79tiSQvjLAoGqTLw="; 49 49 fetchSubmodules = true; 50 50 }; ··· 113 113 ++ lib.optionals enableGTK3 [ gtkmm3 xorg.libpthreadstubs ] 114 114 ++ lib.optionals enableSystemd [ systemd ] 115 115 ++ lib.optionals stdenv.isLinux [ inotify-tools ] 116 - ++ lib.optionals stdenv.isDarwin [ libiconv darwin.apple_sdk.frameworks.Foundation ]; 116 + ++ lib.optionals stdenv.isDarwin [ libiconv Foundation ]; 117 117 118 118 postInstall = '' 119 119 mkdir $apparmor ··· 164 164 license = with lib.licenses; [ gpl2Plus mit ]; 165 165 maintainers = with lib.maintainers; [ astsmtl ]; 166 166 platforms = lib.platforms.unix; 167 - # Needs macOS >= 10.14.6 168 - broken = stdenv.isDarwin && stdenv.isx86_64; 169 167 }; 170 - } 168 + })
+4 -7
pkgs/applications/networking/p2p/transmission/default.nix
··· 32 32 , apparmorRulesFromClosure 33 33 }: 34 34 35 - let 35 + stdenv.mkDerivation (finalAttrs: { 36 + pname = "transmission"; 36 37 version = "3.00"; 37 38 38 - in stdenv.mkDerivation { 39 - pname = "transmission"; 40 - inherit version; 41 - 42 39 src = fetchFromGitHub { 43 40 owner = "transmission"; 44 41 repo = "transmission"; 45 - rev = version; 42 + rev = finalAttrs.version; 46 43 sha256 = "0ccg0km54f700x9p0jsnncnwvfnxfnxf7kcm7pcx1cj0vw78924z"; 47 44 fetchSubmodules = true; 48 45 }; ··· 147 144 platforms = lib.platforms.unix; 148 145 }; 149 146 150 - } 147 + })
+3 -1
pkgs/top-level/all-packages.nix
··· 36119 36119 transmission-gtk = transmission.override { enableGTK3 = true; }; 36120 36120 transmission-qt = transmission.override { enableQt = true; }; 36121 36121 36122 - transmission_4 = callPackage ../applications/networking/p2p/transmission/4.nix { 36122 + # Needs macOS >= 10.14.6 36123 + transmission_4 = darwin.apple_sdk_11_0.callPackage ../applications/networking/p2p/transmission/4.nix { 36124 + inherit (darwin.apple_sdk_11_0.frameworks) Foundation; 36123 36125 fmt = fmt_9; 36124 36126 libutp = libutp_3_4; 36125 36127 };