various: replace substituteAll with replaceVars (#360770)

pkgs/applications/editors/emacs/make-emacs.nix

···
 , recurseIntoAttrs
 , sigtool
 , sqlite
-, substituteAll
+, replaceVars
 , systemd
 , tree-sitter
 , texinfo
···
   inherit src;
 
   patches = patches fetchpatch ++ lib.optionals withNativeCompilation [
-    (substituteAll {
-      src = if lib.versionOlder finalAttrs.version "29"
+    (replaceVars (if lib.versionOlder finalAttrs.version "29"
             then ./native-comp-driver-options-28.patch
             else if lib.versionOlder finalAttrs.version "30"
             then ./native-comp-driver-options.patch
-            else ./native-comp-driver-options-30.patch;
+            else ./native-comp-driver-options-30.patch) {
+
       backendPath = (lib.concatStringsSep " "
         (builtins.map (x: ''"-B${x}"'') ([
           # Paths necessary so the JIT compiler finds its libraries:

pkgs/applications/kde/kdegraphics-thumbnailers/default.nix

···
 {
-  mkDerivation, lib, ghostscript, substituteAll,
+  mkDerivation, lib, ghostscript, replaceVars,
   extra-cmake-modules, karchive, kio, libkexiv2, libkdcraw, kdegraphics-mobipocket
 }:
 
···
   patches = [
     # Hardcode patches to Ghostscript so PDF thumbnails work OOTB.
     # Intentionally not doing the same for dvips because TeX is big.
-    (substituteAll {
+    (replaceVars ./gs-paths.patch {
       gs = "${ghostscript}/bin/gs";
-      src = ./gs-paths.patch;
     })
   ];
 }

pkgs/build-support/docker/default.nix

···
 , skopeo
 , stdenv
 , storeDir ? builtins.storeDir
-, substituteAll
 , symlinkJoin
 , tarsum
 , util-linux

pkgs/build-support/dotnet/build-dotnet-module/default.nix

···
   runtimeShell,
   stdenvNoCC,
   callPackage,
-  substituteAll,
   writeShellScript,
   makeWrapper,
   dotnetCorePackages,

pkgs/build-support/testers/default.nix

···
   runCommandWith,
   stdenv,
   stdenvNoCC,
-  substituteAll,
+  replaceVars,
   testers,
 }:
 # Documentation is in doc/build-helpers/testers.chapter.md
···
   testBuildFailure = drv: drv.overrideAttrs (orig: {
     builder = buildPackages.bash;
     args = [
-      (substituteAll { coreutils = buildPackages.coreutils; src = ./expect-failure.sh; })
+      (replaceVars ./expect-failure.sh { coreutils = buildPackages.coreutils; })
       orig.realBuilder or stdenv.shell
     ] ++ orig.args or ["-e" (orig.builder or ../../stdenv/generic/default-builder.sh)];
   });

pkgs/by-name/cb/cbmc/package.nix

···
   makeWrapper,
   perl,
   substituteAll,
-  substitute,
   cudd,
   fetchurl,
   nix-update-script,

pkgs/by-name/hy/hylafaxplus/config.site

···
 @config_maxgid@
-DIR_BIN="@out_@/bin"
-DIR_FONTMAP="@out_@/share/ghostscript/@ghostscript_version@"
-DIR_LIB="@out_@/lib"
-DIR_LIBDATA="@out_@/spool/etc"
-DIR_LIBEXEC="@out_@/spool/bin"
+DIR_BIN="@out@/bin"
+DIR_FONTMAP="@out@/share/ghostscript/@ghostscript_version@"
+DIR_LIB="@out@/lib"
+DIR_LIBDATA="@out@/spool/etc"
+DIR_LIBEXEC="@out@/spool/bin"
 DIR_LOCKS=/var/lock
-DIR_MAN="@out_@/share/man"
-DIR_SBIN="@out_@/spool/bin"
-DIR_SPOOL="@out_@/spool"
+DIR_MAN="@out@/share/man"
+DIR_SBIN="@out@/spool/bin"
+DIR_SPOOL="@out@/spool"
 FONTMAP="@ghostscript@/share/ghostscript/@ghostscript_version@"
 PATH_AFM="@ghostscript@/share/ghostscript/fonts"
-PATH_DPSRIP="@out_@/spool/bin/ps2fax"
+PATH_DPSRIP="@out@/spool/bin/ps2fax"
 PATH_EGETTY="@coreutils@/bin/false"
 PATH_GSRIP="@ghostscript@/bin/gs"
 PATH_IMPRIP="@coreutils@/bin/false"

pkgs/by-name/hy/hylafaxplus/package.nix

···
 , fakeroot
 , fetchurl
 , libfaketime
-, substituteAll
+, replaceVars
 ## runtime dependencies
 , coreutils
 , file
···
   version = "7.0.9";
   hash = "sha512-3OJwM4vFC9pzPozPobFLiNNx/Qnkl8BpNNziRUpJNBDLBxjtg/eDm3GnprS2hpt7VUoV4PCsFvp1hxhNnhlUwQ==";
 
-  configSite = substituteAll {
-    name = "${pname}-config.site";
-    src = ./config.site;
+  configSite = replaceVars ./config.site {
     config_maxgid = lib.optionalString (maxgid!=null) ''CONFIG_MAXGID=${builtins.toString maxgid}'';
     ghostscript_version = ghostscript.version;
-    out_ = "@out@";  # "out" will be resolved in post-install.sh
+    out = null;  # "out" will be resolved in post-install.sh
     inherit coreutils ghostscript libtiff;
   };
 
-  postPatch = substituteAll {
-    name = "${pname}-post-patch.sh";
-    src = ./post-patch.sh;
+  postPatch = replaceVars ./post-patch.sh {
     inherit configSite;
     maxuid = lib.optionalString (maxuid!=null) (builtins.toString maxuid);
     faxcover_binpath = lib.makeBinPath
···
       [stdenv.shellPackage coreutils findutils gnused gnugrep gawk];
   };
 
-  postInstall = substituteAll {
-    name = "${pname}-post-install.sh";
-    src = ./post-install.sh;
+  postInstall = replaceVars ./post-install.sh {
     inherit fakeroot libfaketime;
   };
 

pkgs/by-name/li/libnvidia-container/package.nix

···
   rpcsvc-proto,
   libtirpc,
   makeWrapper,
-  substituteAll,
   removeReferencesTo,
   replaceVars,
   go,
···
     rev = modprobeVersion;
     sha256 = "sha256-iBRMkvOXacs/llTtvc/ZC5i/q9gc8lMuUHxMbu8A+Kg=";
   };
-  modprobePatch = substituteAll {
-    src = ./modprobe.patch;
+  modprobePatch = replaceVars ./modprobe.patch {
+
     inherit modprobeVersion;
   };
 in

pkgs/by-name/ps/ps2eps/package.nix

···
 { lib
 , fetchFromGitHub
 , perlPackages
-, substituteAll
+, replaceVars
 , ghostscript
 , installShellFiles
 }:
···
     hash = "sha256-SPLwsGKLVhANoqSQ/GJ938cYjbjMbUOXkNn9so3aJTA=";
   };
   patches = [
-    (substituteAll {
-      src = ./hardcode-deps.patch;
+    (replaceVars ./hardcode-deps.patch {
       gs = "${ghostscript}/bin/gs";
-      # bbox cannot be substituted here because substituteAll doesn't know what
+      # bbox cannot be substituted here because replaceVars doesn't know what
       # will be the $out path of the main derivation
+      bbox = null;
     })
   ];
 

pkgs/by-name/tp/tpm2-pkcs11/package.nix

···
-{ stdenv, lib, fetchFromGitHub, substituteAll
+{ stdenv, lib, fetchFromGitHub
 , pkg-config, autoreconfHook, autoconf-archive, makeWrapper, patchelf
 , tpm2-tss, tpm2-tools, opensc, openssl, sqlite, python3, glibc, libyaml
 , abrmdSupport ? true, tpm2-abrmd ? null

pkgs/by-name/zo/zod/package.nix

···
 , makeWrapper
 , coreutils
 , scalingFactor ? 2 # this is to resize the fixed-size zod_launcher window
-, substituteAll
+, replaceVars
 }:
 let
   name = "zod-engine";
···
       # 2,3,4 look acceptable on my 4k monitor and 1 is unreadable.
       # also the ./ in the run command is removed to have easier time starting the game
       patches = [
-        (substituteAll {
+        (replaceVars ./0002-add-scaling-factor-to-source.patch {
           inherit scalingFactor;
-          src=./0002-add-scaling-factor-to-source.patch;
         })
       ];
       postPatch = ''

pkgs/development/compilers/llvm/common/clang/default.nix

···
 , src ? null
 , monorepoSrc ? null
 , runCommand
-, substituteAll
 , cmake
 , ninja
 , libxml2

pkgs/development/compilers/llvm/common/default.nix

···
   preLibcCrossHeaders,
   libxcrypt,
   substitute,
-  substituteAll,
+  replaceVars,
   fetchFromGitHub,
   fetchpatch,
   fetchpatch2,
···
               ./clang/ignore-nostd-link-13.diff
           )
           ++ [
-            (substituteAll {
-              src =
+            (replaceVars
+              (
                 if (lib.versionOlder metadata.release_version "16") then
                   ./clang/clang-11-15-LLVMgold-path.patch
                 else
-                  ./clang/clang-at-least-16-LLVMgold-path.patch;
-              libllvmLibdir = "${tools.libllvm.lib}/lib";
-            })
+                  ./clang/clang-at-least-16-LLVMgold-path.patch
+              )
+              {
+                libllvmLibdir = "${tools.libllvm.lib}/lib";
+              }
+            )
           ]
           # Backport version logic from Clang 16. This is needed by the following patch.
           ++ lib.optional (lib.versions.major metadata.release_version == "15") (fetchpatch {
···
           patches =
             let
               resourceDirPatch = callPackage (
-                { substituteAll, libclang }:
-                (substituteAll {
-                  src = metadata.getVersionFile "lldb/resource-dir.patch";
+                { replaceVars, libclang }:
+                (replaceVars (metadata.getVersionFile "lldb/resource-dir.patch") {
+
                   clangLibDir = "${lib.getLib libclang}/lib";
                 }).overrideAttrs
                   (_: _: { name = "resource-dir.patch"; })

pkgs/development/python-modules/pysdl2/PySDL2-dll.patch

···
  
  try:
 -    dll = DLL("SDL2", ["SDL2", "SDL2-2.0", "SDL2-2.0.0"], os.getenv("PYSDL2_DLL_PATH"))
-+    dll = DLL("SDL2", "@sdl2@")
++    dll = DLL("SDL2", "@SDL2@")
  except RuntimeError as exc:
      raise ImportError(exc)
  
···
  try:
 -    dll = DLL("SDL2_gfx", ["SDL2_gfx", "SDL2_gfx-1.0"],
 -              os.getenv("PYSDL2_DLL_PATH"))
-+    dll = DLL("SDL2_gfx", "@sdl2_gfx@")
++    dll = DLL("SDL2_gfx", "@SDL2_gfx@")
  except RuntimeError as exc:
      raise ImportError(exc)
  
···
 -    dll = DLL(
 -        "SDL2_image", ["SDL2_image", "SDL2_image-2.0"], os.getenv("PYSDL2_DLL_PATH")
 -    )
-+    dll = DLL("SDL2_image", "@sdl2_image@")
++    dll = DLL("SDL2_image", "@SDL2_image@")
  except RuntimeError as exc:
      raise ImportError(exc)
  
···
  try:
 -    dll = DLL("SDL2_mixer", ["SDL2_mixer", "SDL2_mixer-2.0"],
 -              os.getenv("PYSDL2_DLL_PATH"))
-+    dll = DLL("SDL2_mixer", "@sdl2_mixer@")
++    dll = DLL("SDL2_mixer", "@SDL2_mixer@")
  except RuntimeError as exc:
      raise ImportError(exc)
  
···
  try:
 -    dll = DLL("SDL2_ttf", ["SDL2_ttf", "SDL2_ttf-2.0"],
 -              os.getenv("PYSDL2_DLL_PATH"))
-+    dll = DLL("SDL2_ttf", "@sdl2_ttf@")
++    dll = DLL("SDL2_ttf", "@SDL2_ttf@")
  except RuntimeError as exc:
      raise ImportError(exc)
  

pkgs/development/python-modules/pysdl2/default.nix

···
 {
   stdenv,
   lib,
-  substituteAll,
+  replaceVars,
   fetchPypi,
   buildPythonPackage,
   SDL2,
···
   ];
   propagatedBuildInputs = [ SDL2 ];
   patches = [
-    (substituteAll (
-      {
-        src = ./PySDL2-dll.patch;
-      }
-      //
-        builtins.mapAttrs
-          (_: pkg: "${pkg}/lib/lib${pkg.pname}${stdenv.hostPlatform.extensions.sharedLibrary}")
-          {
-            # substituteAll keys must start lowercase
-            sdl2 = SDL2;
-            sdl2_ttf = SDL2_ttf;
-            sdl2_image = SDL2_image;
-            sdl2_gfx = SDL2_gfx;
-            sdl2_mixer = SDL2_mixer;
-          }
+    (replaceVars ./PySDL2-dll.patch (
+      builtins.mapAttrs
+        (_: pkg: "${pkg}/lib/lib${pkg.pname}${stdenv.hostPlatform.extensions.sharedLibrary}")
+        {
+          inherit
+            SDL2
+            SDL2_ttf
+            SDL2_image
+            SDL2_gfx
+            SDL2_mixer
+            ;
+        }
     ))
   ];
 

pkgs/development/tools/electron/common.nix

···
 , fixup-yarn-lock
 , npmHooks
 , yarn
-, substituteAll
 , libnotify
 , unzip
 , pkgs

pkgs/development/tools/ocaml/merlin/4.x.nix

···
 { lib
-, substituteAll
+, replaceVars
 , fetchurl
 , ocaml
 , dune_3
···
     old-patch = lib.versionOlder version "4.17";
   in
   [
-    (substituteAll {
-      src = if old-patch then ./fix-paths.patch else ./fix-paths2.patch;
-      dot_merlin_reader = "${dot-merlin-reader}/bin/dot-merlin-reader";
+    (replaceVars (if old-patch then ./fix-paths.patch else ./fix-paths2.patch) {
+
+      dot-merlin-reader = "${dot-merlin-reader}/bin/dot-merlin-reader";
       dune = "${dune_3}/bin/dune";
     })
   ];

pkgs/kde/gear/kdegraphics-thumbnailers/default.nix

···
 {
   mkKdeDerivation,
-  substituteAll,
+  replaceVars,
   ghostscript,
 }:
 mkKdeDerivation {
···
   patches = [
     # Hardcode patches to Ghostscript so PDF thumbnails work OOTB.
     # Intentionally not doing the same for dvips because TeX is big.
-    (substituteAll {
+    (replaceVars ./gs-paths.patch {
       gs = "${ghostscript}/bin/gs";
-      src = ./gs-paths.patch;
     })
   ];
 }

pkgs/os-specific/linux/lvm2/common.nix

···
 , coreutils
 , libuuid
 , libaio
-, substituteAll
+, replaceVars
 , enableCmdlib ? false
 , enableDmeventd ? false
 , udevSupport ? !stdenv.hostPlatform.isStatic, udev
···
 
   patches = [
     # fixes paths to and checks for tools
-    (substituteAll (let
+    (replaceVars ./fix-blkdeactivate.patch (let
       optionalTool = cond: pkg: if cond then pkg else "/run/current-system/sw";
     in {
-      src = ./fix-blkdeactivate.patch;
       inherit coreutils;
       util_linux = optionalTool enableUtilLinux util-linux;
       mdadm = optionalTool enableMdadm mdadm;
       multipath_tools = optionalTool enableMultipath multipath-tools;
       vdo = optionalTool enableVDO vdo;
+      SBINDIR = null; # part of original source code in the patch's context
     }))
     ./fix-stdio-usage.patch
   ];