···535536 The old config generation system used impure shell scripts and could break in specific circumstances (see #1234).
53700000538### Writing good commit messages
539540In addition to writing properly formatted commit messages, it's important to include relevant information so other developers can later understand *why* a change was made. While this information usually can be found by digging code, mailing list/Discourse archives, pull request discussions or upstream changes, it may require a lot of work.
···535536 The old config generation system used impure shell scripts and could break in specific circumstances (see #1234).
537538+ When adding yourself as maintainer, in the same pull request, make a separate
539+ commit with the message `maintainers: add <handle>`.
540+ Add the commit before those making changes to the package or module.
541+ See [Nixpkgs Maintainers](../maintainers/README.md) for details.
542+543### Writing good commit messages
544545In addition to writing properly formatted commit messages, it's important to include relevant information so other developers can later understand *why* a change was made. While this information usually can be found by digging code, mailing list/Discourse archives, pull request discussions or upstream changes, it may require a lot of work.
···22in
23stdenv.mkDerivation rec {
24 pname = "clightning";
25- version = "23.05.2";
2627 src = fetchurl {
28 url = "https://github.com/ElementsProject/lightning/releases/download/v${version}/clightning-v${version}.zip";
29- sha256 = "sha256-Tj5ybVaxpk5wmOw85LkeU4pgM9NYl6SnmDG2gyXrTHw=";
30 };
3132 # when building on darwin we need dawin.cctools to provide the correct libtool
···22in
23stdenv.mkDerivation rec {
24 pname = "clightning";
25+ version = "23.08";
2627 src = fetchurl {
28 url = "https://github.com/ElementsProject/lightning/releases/download/v${version}/clightning-v${version}.zip";
29+ sha256 = "sha256-kersWWGytZmdVbpgezrWyjfb4jeG5dShk/CUb5hpiqA=";
30 };
3132 # when building on darwin we need dawin.cctools to provide the correct libtool
···10 version = "1.8.9-2";
1112 src = requireFile rec {
13- name = "PI-linux-x64-${version}-20230814-c.tar.xz";
14 url = "https://pixinsight.com/";
15- sha256 = "sha256-4Jspkl5riMlbeJX/h1zhVfVymORPK1X4l0LyOgXm05Y=";
16 message = ''
17 PixInsight is available from ${url} and requires a commercial (or trial) license.
18 After a license has been obtained, PixInsight can be downloaded from the software distribution
···10 version = "1.8.9-2";
1112 src = requireFile rec {
13+ name = "PI-linux-x64-${version}-20230828-c.tar.xz";
14 url = "https://pixinsight.com/";
15+ sha256 = "sha256-f4E6F3LeEolDGcN9Uo/n8GlIuwMIVI26fW9NYtEesd4=";
16 message = ''
17 PixInsight is available from ${url} and requires a commercial (or trial) license.
18 After a license has been obtained, PixInsight can be downloaded from the software distribution
+4-13
pkgs/applications/misc/jrnl/default.nix
···56python3.pkgs.buildPythonApplication rec {
7 pname = "jrnl";
8- version = "3.3";
9 format = "pyproject";
1011 src = fetchFromGitHub {
12 owner = "jrnl-org";
13 repo = pname;
14 rev = "refs/tags/v${version}";
15- sha256 = "sha256-e2w0E8t6s0OWx2ROme2GdyzWhmCc6hnMfSdLTZqt3bg=";
16 };
1718 nativeBuildInputs = with python3.pkgs; [
···42 toml
43 ];
4445- # Upstream expects a old pytest-bdd version
46- # Once it changes we should update here too
47- # https://github.com/jrnl-org/jrnl/blob/develop/poetry.lock#L732
48- disabledTests = [
49- "bdd"
50- ];
51-52- postPatch = ''
53- substituteInPlace pyproject.toml \
54- --replace 'rich = "^12.2.0"' 'rich = ">=12.2.0, <14.0.0"'
55- '';
5657 preCheck = ''
58 export HOME=$(mktemp -d);
···63 ];
6465 meta = with lib; {
066 description = "Simple command line journal application that stores your journal in a plain text file";
67 homepage = "https://jrnl.sh/";
68 license = licenses.gpl3Only;
69 maintainers = with maintainers; [ bryanasdev000 zalakain ];
070 };
71}
···56python3.pkgs.buildPythonApplication rec {
7 pname = "jrnl";
8+ version = "4.0.1";
9 format = "pyproject";
1011 src = fetchFromGitHub {
12 owner = "jrnl-org";
13 repo = pname;
14 rev = "refs/tags/v${version}";
15+ hash = "sha256-NpI19NQxfDiqcfFI9kMqfMboI4fQTqCG7AoG9o8YoEI=";
16 };
1718 nativeBuildInputs = with python3.pkgs; [
···42 toml
43 ];
44000000000004546 preCheck = ''
47 export HOME=$(mktemp -d);
···52 ];
5354 meta = with lib; {
55+ changelog = "https://github.com/jrnl-org/jrnl/releases/tag/v${version}";
56 description = "Simple command line journal application that stores your journal in a plain text file";
57 homepage = "https://jrnl.sh/";
58 license = licenses.gpl3Only;
59 maintainers = with maintainers; [ bryanasdev000 zalakain ];
60+ mainProgram = "jrnl";
61 };
62}
···4, buildGoModule
5, sqlite
6, callPackage
07}:
89buildGoModule rec {
···3940 passthru = {
41 updateScript = ./update.sh;
00042 };
4344 # Otherwise, all other subpackages are built as well and from some reason,
···4, buildGoModule
5, sqlite
6, callPackage
7+, nixosTests
8}:
910buildGoModule rec {
···4041 passthru = {
42 updateScript = ./update.sh;
43+ tests = {
44+ nixos = nixosTests.gotify-server;
45+ };
46 };
4748 # Otherwise, all other subpackages are built as well and from some reason,