oppi.li
loading up the forgejo repo on tangled to test page performance
fix(ui): hide git note add button for commit if commit already has a note (#6613)
Regression from f5c0570533b0a835a88eb7337da841d071f2de6b
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6613
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Beowulf <beowulf@beocode.eu>
Co-committed-by: Beowulf <beowulf@beocode.eu>
+8
-3
+5
-3
templates/repo/commit_page.tmpl
+5
-3
templates/repo/commit_page.tmpl
···
128
128
</form>
129
129
</div>
130
130
</div>
131
-
<div id="commit-notes-add-button" class="item">
132
-
{{ctx.Locale.Tr "repo.diff.git-notes.add"}}
133
-
</div>
131
+
{{if not .NoteRendered}}
132
+
<div id="commit-notes-add-button" class="item">
133
+
{{ctx.Locale.Tr "repo.diff.git-notes.add"}}
134
+
</div>
135
+
{{end}}
134
136
</div>
135
137
</div>
136
138
{{end}}
+3
tests/e2e/git-notes.test.e2e.ts
+3
tests/e2e/git-notes.test.e2e.ts
···
8
8
let response = await page.goto('/user2/repo1/commit/65f1bf27bc3bf70f64657658635e66094edbcb4d');
9
9
expect(response?.status()).toBe(200);
10
10
11
+
// An add button should not be present, because the commit already has a commit note
12
+
await expect(page.locator('#commit-notes-add-button')).toHaveCount(0);
13
+
11
14
await page.locator('#commit-notes-edit-button').click();
12
15
13
16
let textarea = page.locator('textarea[name="notes"]');