loading up the forgejo repo on tangled to test page performance
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

test: fix test linting

See forgejo/forgejo#5911

+15 -18
+1 -1
models/activities/user_heatmap_test.go
··· 96 96 // Test JSON rendering 97 97 jsonData, err := json.Marshal(heatmap) 98 98 require.NoError(t, err) 99 - assert.Equal(t, tc.JSONResult, string(jsonData)) 99 + assert.JSONEq(t, tc.JSONResult, string(jsonData)) 100 100 } 101 101 }
+1 -2
models/project/column_test.go
··· 5 5 6 6 import ( 7 7 "fmt" 8 - "strings" 9 8 "testing" 10 9 11 10 "code.gitea.io/gitea/models/db" ··· 124 123 ProjectID: project1.ID, 125 124 }) 126 125 require.Error(t, err) 127 - assert.True(t, strings.Contains(err.Error(), "maximum number of columns reached")) 126 + assert.Contains(t, err.Error(), "maximum number of columns reached") 128 127 }
+1 -2
modules/activitypub/client_test.go
··· 9 9 "io" 10 10 "net/http" 11 11 "net/http/httptest" 12 - "regexp" 13 12 "testing" 14 13 "time" 15 14 ··· 119 118 120 119 expected := "BODY" 121 120 srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { 122 - assert.Regexp(t, regexp.MustCompile("^"+setting.Federation.DigestAlgorithm), r.Header.Get("Digest")) 121 + assert.Regexp(t, "^"+setting.Federation.DigestAlgorithm, r.Header.Get("Digest")) 123 122 assert.Contains(t, r.Header.Get("Signature"), pubID) 124 123 assert.Equal(t, ActivityStreamsContentType, r.Header.Get("Content-Type")) 125 124 body, err := io.ReadAll(r.Body)
+2 -2
modules/lfs/http_client_test.go
··· 267 267 return nil 268 268 }) 269 269 if len(c.expectederror) > 0 { 270 - assert.True(t, strings.Contains(err.Error(), c.expectederror), "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror) 270 + assert.Contains(t, err.Error(), c.expectederror, "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror) 271 271 } else { 272 272 require.NoError(t, err, "case %d", n) 273 273 } ··· 369 369 return io.NopCloser(new(bytes.Buffer)), objectError 370 370 }) 371 371 if len(c.expectederror) > 0 { 372 - assert.True(t, strings.Contains(err.Error(), c.expectederror), "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror) 372 + assert.Contains(t, err.Error(), c.expectederror, "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror) 373 373 } else { 374 374 require.NoError(t, err, "case %d", n) 375 375 }
+3 -3
modules/lfs/transferadapter_test.go
··· 97 97 for n, c := range cases { 98 98 _, err := a.Download(context.Background(), c.link) 99 99 if len(c.expectederror) > 0 { 100 - assert.True(t, strings.Contains(err.Error(), c.expectederror), "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror) 100 + assert.Contains(t, err.Error(), c.expectederror, "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror) 101 101 } else { 102 102 require.NoError(t, err, "case %d", n) 103 103 } ··· 130 130 for n, c := range cases { 131 131 err := a.Upload(context.Background(), c.link, p, bytes.NewBufferString("dummy")) 132 132 if len(c.expectederror) > 0 { 133 - assert.True(t, strings.Contains(err.Error(), c.expectederror), "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror) 133 + assert.Contains(t, err.Error(), c.expectederror, "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror) 134 134 } else { 135 135 require.NoError(t, err, "case %d", n) 136 136 } ··· 163 163 for n, c := range cases { 164 164 err := a.Verify(context.Background(), c.link, p) 165 165 if len(c.expectederror) > 0 { 166 - assert.True(t, strings.Contains(err.Error(), c.expectederror), "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror) 166 + assert.Contains(t, err.Error(), c.expectederror, "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror) 167 167 } else { 168 168 require.NoError(t, err, "case %d", n) 169 169 }
+1 -1
modules/setting/storage_test.go
··· 445 445 require.NoError(t, loadLFSFrom(cfg)) 446 446 assert.EqualValues(t, "my_access_key", LFS.Storage.MinioConfig.AccessKeyID) 447 447 assert.EqualValues(t, "my_secret_key", LFS.Storage.MinioConfig.SecretAccessKey) 448 - assert.True(t, true, LFS.Storage.MinioConfig.UseSSL) 448 + assert.True(t, LFS.Storage.MinioConfig.UseSSL) 449 449 assert.EqualValues(t, "/lfs", LFS.Storage.MinioConfig.BasePath) 450 450 451 451 cfg, err = NewConfigProviderFromData(`
+2 -3
modules/util/keypair_test.go
··· 10 10 "crypto/sha256" 11 11 "crypto/x509" 12 12 "encoding/pem" 13 - "regexp" 14 13 "testing" 15 14 16 15 "github.com/stretchr/testify/assert" ··· 24 23 assert.NotEmpty(t, priv) 25 24 assert.NotEmpty(t, pub) 26 25 27 - assert.Regexp(t, regexp.MustCompile("^-----BEGIN RSA PRIVATE KEY-----.*"), priv) 28 - assert.Regexp(t, regexp.MustCompile("^-----BEGIN PUBLIC KEY-----.*"), pub) 26 + assert.Regexp(t, "^-----BEGIN RSA PRIVATE KEY-----.*", priv) 27 + assert.Regexp(t, "^-----BEGIN PUBLIC KEY-----.*", pub) 29 28 } 30 29 31 30 func TestSignUsingKeys(t *testing.T) {
+1 -1
services/repository/contributors_graph_test.go
··· 43 43 dataString, isData := mockCache.Get("key2").(string) 44 44 assert.True(t, isData) 45 45 // Verify that JSON is actually stored in the cache. 46 - assert.EqualValues(t, `{"ethantkoenig@gmail.com":{"name":"Ethan Koenig","login":"","avatar_link":"https://secure.gravatar.com/avatar/b42fb195faa8c61b8d88abfefe30e9e3?d=identicon","home_link":"","total_commits":1,"weeks":{"1511654400000":{"week":1511654400000,"additions":3,"deletions":0,"commits":1}}},"jimmy.praet@telenet.be":{"name":"Jimmy Praet","login":"","avatar_link":"https://secure.gravatar.com/avatar/93c49b7c89eb156971d11161c9b52795?d=identicon","home_link":"","total_commits":1,"weeks":{"1624752000000":{"week":1624752000000,"additions":2,"deletions":0,"commits":1}}},"jon@allspice.io":{"name":"Jon","login":"","avatar_link":"https://secure.gravatar.com/avatar/00388ce725e6886f3e07c3733007289b?d=identicon","home_link":"","total_commits":1,"weeks":{"1607817600000":{"week":1607817600000,"additions":10,"deletions":0,"commits":1}}},"total":{"name":"Total","login":"","avatar_link":"","home_link":"","total_commits":3,"weeks":{"1511654400000":{"week":1511654400000,"additions":3,"deletions":0,"commits":1},"1607817600000":{"week":1607817600000,"additions":10,"deletions":0,"commits":1},"1624752000000":{"week":1624752000000,"additions":2,"deletions":0,"commits":1}}}}`, dataString) 46 + assert.JSONEq(t, `{"ethantkoenig@gmail.com":{"name":"Ethan Koenig","login":"","avatar_link":"https://secure.gravatar.com/avatar/b42fb195faa8c61b8d88abfefe30e9e3?d=identicon","home_link":"","total_commits":1,"weeks":{"1511654400000":{"week":1511654400000,"additions":3,"deletions":0,"commits":1}}},"jimmy.praet@telenet.be":{"name":"Jimmy Praet","login":"","avatar_link":"https://secure.gravatar.com/avatar/93c49b7c89eb156971d11161c9b52795?d=identicon","home_link":"","total_commits":1,"weeks":{"1624752000000":{"week":1624752000000,"additions":2,"deletions":0,"commits":1}}},"jon@allspice.io":{"name":"Jon","login":"","avatar_link":"https://secure.gravatar.com/avatar/00388ce725e6886f3e07c3733007289b?d=identicon","home_link":"","total_commits":1,"weeks":{"1607817600000":{"week":1607817600000,"additions":10,"deletions":0,"commits":1}}},"total":{"name":"Total","login":"","avatar_link":"","home_link":"","total_commits":3,"weeks":{"1511654400000":{"week":1511654400000,"additions":3,"deletions":0,"commits":1},"1607817600000":{"week":1607817600000,"additions":10,"deletions":0,"commits":1},"1624752000000":{"week":1624752000000,"additions":2,"deletions":0,"commits":1}}}}`, dataString) 47 47 48 48 var data map[string]*ContributorData 49 49 require.NoError(t, json.Unmarshal([]byte(dataString), &data))
+1 -1
tests/integration/compare_test.go
··· 40 40 41 41 req = NewRequest(t, "GET", "/user2/repo1/compare/invalid") 42 42 resp = session.MakeRequest(t, req, http.StatusNotFound) 43 - assert.False(t, strings.Contains(resp.Body.String(), ">500<"), "expect 404 page not 500") 43 + assert.NotContains(t, resp.Body.String(), ">500<", "expect 404 page not 500") 44 44 } 45 45 46 46 // Compare with inferred default branch (master)
+1 -1
tests/integration/last_updated_time_test.go
··· 48 48 { 49 49 buf := "" 50 50 findTextNonNested(t, node, &buf) 51 - assert.True(t, strings.Contains(buf, "Updated")) 51 + assert.Contains(t, buf, "Updated") 52 52 } 53 53 54 54 {
+1 -1
tests/integration/repo_test.go
··· 902 902 symlinkURL, ok := htmlDoc.Find(".file-actions .button[data-kind='follow-symlink']").Attr("href") 903 903 if shouldExist { 904 904 assert.True(t, ok) 905 - assert.EqualValues(t, expectedSymlinkURL, symlinkURL) 905 + assert.Equal(t, expectedSymlinkURL, symlinkURL) 906 906 } else { 907 907 assert.False(t, ok) 908 908 }