loading up the forgejo repo on tangled to test page performance
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Adjust codespell config + make it fix few typos which sneaked in since addition of codespell support (#4857)

Now that my colleague just posted a wonderful blog post https://blog.datalad.org/posts/forgejo-runner-podman-deployment/ on forgejo runner, some time I will try to add that damn codespell action to work on CI here ;) meanwhile some typos managed to sneak in and this PR should address them (one change might be functional in a test -- not sure if would cause a fail or not)

### Release notes

- [ ] I do not want this change to show in the release notes.
- [ ] I want the title to show in the release notes with a link to this pull request.
- [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4857
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-committed-by: Yaroslav Halchenko <debian@onerussian.com>

authored by

Yaroslav Halchenko
Yaroslav Halchenko
and committed by
Earl Warren
5ae2dbcb 06d25815

+25 -25
+3 -3
RELEASE-NOTES.md
··· 52 52 - feat: add [Reviewed-on and Reviewed-by variables](https://codeberg.org/forgejo/forgejo/commit/4ddd9af50fbfcfb2ebf629697a803b3bce56c4af) to the merge template. 53 53 - feat(perf): [add the `[ui.csv].MAX_ROWS` setting](https://codeberg.org/forgejo/forgejo/commit/433b6c6910f8699dc41787ef8f5148b122b4677e) to avoid displaying a large number of lines (defaults to 2500). 54 54 - feat: [add a setting to override or add headers of all outgoing emails](https://codeberg.org/forgejo/forgejo/commit/1d4bff4f65d5e4a3969871ef91d3612daf272b45), for instance `Reply-To` or `In-Reply-To`.<!--description--> 55 - - [PR](https://codeberg.org/forgejo/forgejo/pulls/4027): <!--number 4027 --><!--number--><!--description - Gitea/Forgejo webhook payload include additional fields (`html_url`, `additions`, `deletions`, `review_comments`...) for better compatbility with [OpenProject](https://www.openproject.org/), ported from [gitea#28435](https://github.com/go-gitea/gitea/pull/28435).-->the Gitea/Forgejo webhook payload includes additional fields (`html_url`, `additions`, `deletions`, `review_comments`...) for better compatbility with [OpenProject](https://www.openproject.org/).<!--description--> 55 + - [PR](https://codeberg.org/forgejo/forgejo/pulls/4027): <!--number 4027 --><!--number--><!--description - Gitea/Forgejo webhook payload include additional fields (`html_url`, `additions`, `deletions`, `review_comments`...) for better compatibility with [OpenProject](https://www.openproject.org/), ported from [gitea#28435](https://github.com/go-gitea/gitea/pull/28435).-->the Gitea/Forgejo webhook payload includes additional fields (`html_url`, `additions`, `deletions`, `review_comments`...) for better compatibility with [OpenProject](https://www.openproject.org/).<!--description--> 56 56 - [PR](https://codeberg.org/forgejo/forgejo/pulls/4026): <!--number 4026 --><!--number--><!--description - when an OAuth grant request submitted to a Forgejo user is denied, the server from which the request originates is not notified that it has been denied-->when an OAuth grant request submitted to a Forgejo user is denied, the server from which the request originates is notified that it has been denied.<!--description--> 57 57 - [PR](https://codeberg.org/forgejo/forgejo/pulls/3989): <!--number 3989 --><!--number--><!--description multine placeholder--> 58 58 - feat: API endpoints that return a repository now [also include the topics](https://codeberg.org/forgejo/forgejo/commit/ee2247d77c0b13b0b45df704d7589b541db03899). ··· 76 76 - [PR](https://codeberg.org/forgejo/forgejo/pulls/3724): <!--number 3724 --><!--number--><!--description multine placeholder--> 77 77 - [CERT management was improved](https://codeberg.org/forgejo/forgejo/pulls/3724) when [`ENABLE_ACME=true`](https://forgejo.org/docs/v7.0/admin/config-cheat-sheet/#server-server) 78 78 - Draft support for draft-03 of [ACME Renewal Information (ARI)](https://datatracker.ietf.org/doc/draft-ietf-acme-ari/) which assists with deciding when to renew certificates. This augments CertMagic's already-advanced logic using cert lifetime and OCSP/revocation status. 79 - - New [`ZeroSSLIssuer`](https://pkg.go.dev/github.com/caddyserver/certmagic@v0.21.0#ZeroSSLIssuer) uses the [ZeroSSL API](https://zerossl.com/documentation/api/) to get certificates. ZeroSSL also has an ACME endpoint, which can still be accesed using the existing ACMEIssuer, as always. Their proprietary API is paid, but has extra features like IP certificates, better reliability, and support. 79 + - New [`ZeroSSLIssuer`](https://pkg.go.dev/github.com/caddyserver/certmagic@v0.21.0#ZeroSSLIssuer) uses the [ZeroSSL API](https://zerossl.com/documentation/api/) to get certificates. ZeroSSL also has an ACME endpoint, which can still be accessed using the existing ACMEIssuer, as always. Their proprietary API is paid, but has extra features like IP certificates, better reliability, and support. 80 80 - DNS challenges should be smoother in some cases as we've improved propagation checking. 81 81 - In the odd case your ACME account disappears from the ACME server, CertMagic will automatically retry with a new account. (This happens in some test/dev environments.) 82 82 - ACME accounts are identified only by their public keys, but CertMagic maps accounts by CA+email for practical/storage reasons. So now you can "pin" an account key to use by specifying your email and the account public key in your config, which is useful if you need to absolutely be sure to use a specific account (like if you get rate limit exemptions from a CA).<!--description--> ··· 2219 2219 2220 2220 ### Git 2221 2221 2222 - Git [recently announced](https://github.blog/2023-02-14-git-security-vulnerabilities-announced-3/) new versions to address two CVEs ([CVE-2023-22490](https://cve.circl.lu/cve/CVE-2023-22490), [CVE-2023-23946](https://cve.circl.lu/cve/CVE-2023-23946)). On 14 Februrary 2023, Git published the maintenance release v2.39.2, together with releases for older maintenance tracks v2.38.4, v2.37.6, v2.36.5, v2.35.7, v2.34.7, v2.33.7, v2.32.6, v2.31.7, and v2.30.8. All major GNU/Linux distributions also provide updated packages via their security update channels. 2222 + Git [recently announced](https://github.blog/2023-02-14-git-security-vulnerabilities-announced-3/) new versions to address two CVEs ([CVE-2023-22490](https://cve.circl.lu/cve/CVE-2023-22490), [CVE-2023-23946](https://cve.circl.lu/cve/CVE-2023-23946)). On 14 February 2023, Git published the maintenance release v2.39.2, together with releases for older maintenance tracks v2.38.4, v2.37.6, v2.36.5, v2.35.7, v2.34.7, v2.33.7, v2.32.6, v2.31.7, and v2.30.8. All major GNU/Linux distributions also provide updated packages via their security update channels. 2223 2223 2224 2224 We recommend that all installations running a version affected by the issues described below are upgraded to the latest version as soon as possible. 2225 2225
+1 -1
models/db/log.go
··· 67 67 l.Log(stackLevel, log.WARN, "%s", fmt.Sprint(v...)) 68 68 } 69 69 70 - // Warnf show warnning log 70 + // Warnf show warning log 71 71 func (l *XORMLogBridge) Warnf(format string, v ...any) { 72 72 l.Log(stackLevel, log.WARN, format, v...) 73 73 }
+1 -1
models/user/user_test.go
··· 646 646 {"Hi Its <Mee>", "ee@mail.box", `"Hi Its Mee" <ee@mail.box>`}, 647 647 {"Sinéad.O'Connor", "sinead.oconnor@gmail.com", "=?utf-8?b?U2luw6lhZC5PJ0Nvbm5vcg==?= <sinead.oconnor@gmail.com>"}, 648 648 {"Æsir", "aesir@gmx.de", "=?utf-8?q?=C3=86sir?= <aesir@gmx.de>"}, 649 - {"new😀user", "new.user@alo.com", "=?utf-8?q?new=F0=9F=98=80user?= <new.user@alo.com>"}, 649 + {"new😀user", "new.user@alo.com", "=?utf-8?q?new=F0=9F=98=80user?= <new.user@alo.com>"}, // codespell-ignore 650 650 {`"quoted"`, "quoted@test.com", `"quoted" <quoted@test.com>`}, 651 651 {`gusted`, "gusted@test.com", `"gusted" <gusted@test.com>`}, 652 652 {`Joe Q. Public`, "john.q.public@example.com", `"Joe Q. Public" <john.q.public@example.com>`},
+2 -2
modules/forgefed/activity.go
··· 21 21 func NewForgeLike(actorIRI, objectIRI string, startTime time.Time) (ForgeLike, error) { 22 22 result := ForgeLike{} 23 23 result.Type = ap.LikeType 24 - result.Actor = ap.IRI(actorIRI) // Thats us, a User 25 - result.Object = ap.IRI(objectIRI) // Thats them, a Repository 24 + result.Actor = ap.IRI(actorIRI) // That's us, a User 25 + result.Object = ap.IRI(objectIRI) // That's them, a Repository 26 26 result.StartTime = startTime 27 27 if valid, err := validation.IsValid(result); !valid { 28 28 return ForgeLike{}, err
+1 -1
modules/indexer/code/indexer_test.go
··· 119 119 } 120 120 defer idx.Close() 121 121 122 - testIndexer("beleve", t, idx) 122 + testIndexer("bleve", t, idx) 123 123 } 124 124 125 125 func TestESIndexAndSearch(t *testing.T) {
+1 -1
modules/indexer/code/search.go
··· 105 105 !ok || 106 106 // token was marked as used 107 107 token == "" || 108 - // the token is not an valid html tag emited by chroma 108 + // the token is not an valid html tag emitted by chroma 109 109 !(len(token) > 6 && (token[0:5] == "<span" || token[0:6] == "</span")) { 110 110 count++ 111 111 } else if !isOpen {
+2 -2
modules/indexer/internal/bleve/query.go
··· 13 13 // NumericEqualityQuery generates a numeric equality query for the given value and field 14 14 func NumericEqualityQuery(value int64, field string) *query.NumericRangeQuery { 15 15 f := float64(value) 16 - tru := true 17 - q := bleve.NewNumericRangeInclusiveQuery(&f, &f, &tru, &tru) 16 + tru := true // codespell-ignore 17 + q := bleve.NewNumericRangeInclusiveQuery(&f, &f, &tru, &tru) // codespell-ignore 18 18 q.SetField(field) 19 19 return q 20 20 }
+1 -1
modules/structs/repo.go
··· 317 317 ) 318 318 319 319 // Name represents the service type's name 320 - // WARNNING: the name have to be equal to that on goth's library 320 + // WARNING: the name have to be equal to that on goth's library 321 321 func (gt GitServiceType) Name() string { 322 322 return strings.ToLower(gt.Title()) 323 323 }
+1 -1
modules/structs/user.go
··· 62 62 63 63 // MarshalJSON implements the json.Marshaler interface for User, adding field(s) for backward compatibility 64 64 func (u User) MarshalJSON() ([]byte, error) { 65 - // Re-declaring User to avoid recursion 65 + // Redeclaring User to avoid recursion 66 66 type shadow User 67 67 return json.Marshal(struct { 68 68 shadow
+2 -2
pyproject.toml
··· 18 18 # precise hits for CamelCased words,various other curious cases which require regex to ignore 19 19 # entire line or some portion of it 20 20 # TODO: Resolve Treshold typo in API and remove from here 21 - ignore-regex = '(\b(Treshold|mx claus|commitT|ReadBy|#afile|respOne|commitI|[cC]rossReference)\b|shouldbe\.|women’s.*womens|"emoji":.*|,bu,|assert\.Equal.*"fo\b|github\.com/unknwon|Copyright 2014 Unknwon|allowed\.noone|[hH]eadErr|atLeast|{"\\U.*)|Iif|FilterIn|.*codespell-ignore.*' 21 + ignore-regex = '(\b(Treshold|mx claus|commitT|ReadBy|#afile|respOne|commitI|[cC]rossReference|SMove|reVer|CheckIn|NotIn)\b|shouldbe\.|women’s.*womens|"emoji":.*|,bu,|assert\.Equal.*"fo\b|github\.com/unknwon|Copyright 2014 Unknwon|allowed\.noone|[hH]eadErr|atLeast|{"\\U.*)|Iif|FilterIn|.*codespell-ignore.*' 22 22 #|.*(Maskenpflicht|Geimpft),.*)' 23 23 # te - TreeEntry variable 24 24 # commiter - wrong spelling but seems used in API 25 25 # ALLWAYS - is a config var 26 26 # infact - other variable(s) 27 - ignore-words-list = 'crate,te,commiter,befores,allways,infact,startd,unknow' 27 + ignore-words-list = 'bleve,crate,te,commiter,befores,allways,infact,startd,unknow'
+1 -1
release-notes/3724.md
··· 1 1 - [CERT management was improved](https://codeberg.org/forgejo/forgejo/pulls/3724) when [`ENABLE_ACME=true`](https://forgejo.org/docs/v7.0/admin/config-cheat-sheet/#server-server) 2 2 - Draft support for draft-03 of [ACME Renewal Information (ARI)](https://datatracker.ietf.org/doc/draft-ietf-acme-ari/) which assists with deciding when to renew certificates. This augments CertMagic's already-advanced logic using cert lifetime and OCSP/revocation status. 3 - - New [`ZeroSSLIssuer`](https://pkg.go.dev/github.com/caddyserver/certmagic@v0.21.0#ZeroSSLIssuer) uses the [ZeroSSL API](https://zerossl.com/documentation/api/) to get certificates. ZeroSSL also has an ACME endpoint, which can still be accesed using the existing ACMEIssuer, as always. Their proprietary API is paid, but has extra features like IP certificates, better reliability, and support. 3 + - New [`ZeroSSLIssuer`](https://pkg.go.dev/github.com/caddyserver/certmagic@v0.21.0#ZeroSSLIssuer) uses the [ZeroSSL API](https://zerossl.com/documentation/api/) to get certificates. ZeroSSL also has an ACME endpoint, which can still be accessed using the existing ACMEIssuer, as always. Their proprietary API is paid, but has extra features like IP certificates, better reliability, and support. 4 4 - DNS challenges should be smoother in some cases as we've improved propagation checking. 5 5 - In the odd case your ACME account disappears from the ACME server, CertMagic will automatically retry with a new account. (This happens in some test/dev environments.) 6 6 - ACME accounts are identified only by their public keys, but CertMagic maps accounts by CA+email for practical/storage reasons. So now you can "pin" an account key to use by specifying your email and the account public key in your config, which is useful if you need to absolutely be sure to use a specific account (like if you get rate limit exemptions from a CA).
+1 -1
release-notes/4027.md
··· 1 - - Gitea/Forgejo webhook payload include additional fields (`html_url`, `additions`, `deletions`, `review_comments`...) for better compatbility with [OpenProject](https://www.openproject.org/), ported from [gitea#28435](https://github.com/go-gitea/gitea/pull/28435). 1 + - Gitea/Forgejo webhook payload include additional fields (`html_url`, `additions`, `deletions`, `review_comments`...) for better compatibility with [OpenProject](https://www.openproject.org/), ported from [gitea#28435](https://github.com/go-gitea/gitea/pull/28435).
+2 -2
routers/api/actions/artifacts.go
··· 428 428 } 429 429 430 430 if itemPath != artifacts[0].ArtifactName { 431 - log.Error("Error dismatch artifact name, itemPath: %v, artifact: %v", itemPath, artifacts[0].ArtifactName) 432 - ctx.Error(http.StatusBadRequest, "Error dismatch artifact name") 431 + log.Error("Error mismatch artifact name, itemPath: %v, artifact: %v", itemPath, artifacts[0].ArtifactName) 432 + ctx.Error(http.StatusBadRequest, "Error mismatch artifact name") 433 433 return 434 434 } 435 435
+1 -1
tailwind.config.js
··· 99 99 }, 100 100 plugins: [ 101 101 plugin(({addUtilities}) => { 102 - // base veriables required for tranform utilities 102 + // base variables required for transform utilities 103 103 // added as utilities since base is not imported 104 104 // note: required when using tailwind's transform classes 105 105 addUtilities({
+1 -1
tests/e2e/profile_actions.test.e2e.js
··· 12 12 13 13 // Check if following and then unfollowing works. 14 14 // This checks that the event listeners of 15 - // the buttons aren't dissapearing. 15 + // the buttons aren't disappearing. 16 16 const followButton = page.locator('.follow'); 17 17 await expect(followButton).toContainText('Follow'); 18 18 await followButton.click();
+1 -1
tests/integration/api_packages_nuget_test.go
··· 451 451 packageName, 452 452 "almost.similar.dependency", 453 453 "almost.similar", 454 - "almost.similar.dependant", 454 + "almost.similar.dependent", 455 455 } 456 456 457 457 for _, fakePackageName := range fakePackages {
+1 -1
tests/integration/git_push_test.go
··· 79 79 } 80 80 pushed = append(pushed, "master") 81 81 82 - // push all, so that master are not chagned 82 + // push all, so that master are not changed 83 83 doGitPushTestRepository(gitPath, "origin", "--all")(t) 84 84 85 85 return pushed, deleted
+1 -1
tests/integration/repo_badges_test.go
··· 133 133 err := release.CreateNewTag(git.DefaultContext, owner, repo, "main", "v1", "message") 134 134 require.NoError(t, err) 135 135 136 - // Now the workflow is wating 136 + // Now the workflow is waiting 137 137 req = NewRequestf(t, "GET", "/user2/%s/actions/workflows/tag-test.yaml/badge.svg", repo.Name) 138 138 resp = MakeRequest(t, req, http.StatusSeeOther) 139 139 assertBadge(t, resp, "tag--test.yaml-waiting-lightgrey")
+1 -1
tools/lint-go-gopls.sh
··· 8 8 ) 9 9 10 10 # lint all go files with 'gopls check' and look for lines starting with the 11 - # current absolute path, indicating a error was found. This is neccessary 11 + # current absolute path, indicating a error was found. This is necessary 12 12 # because the tool does not set non-zero exit code when errors are found. 13 13 # ref: https://github.com/golang/go/issues/67078 14 14 ERROR_LINES=$("$GO" run "$GOPLS_PACKAGE" check "$@" 2>/dev/null | grep -E "^$PWD" | grep -vFf <(printf '%s\n' "${IGNORE_PATTERNS[@]}"));