···4455## Motivation
66The interface for requesting and getting back feeds is something that I feel is really at the core of what bluesky offers. The user should be able to choose what feeds they subscribe to, feeds should be first class objects, they should be able to be efficiently generated and consumed, and they should be able to trustlessly come from anywhere.
77-Theres a lot of changes we *could* make to the current structure, but I don't want to stray too far from where we are at right now.
77+There are a lot of changes we *could* make to the current structure, but I don't want to stray too far from where we are at right now.
88991010```go
+1-1
indexer/indexer.go
···307307 if post.Reply != nil {
308308 replyto, err := ix.GetPost(ctx, post.Reply.Parent.Uri)
309309 if err != nil {
310310- log.Error("probably shouldnt error when processing a reply to a not-found post")
310310+ log.Error("probably shouldn't error when processing a reply to a not-found post")
311311 return err
312312 }
313313
+2-2
lex/gen.go
···555555556556 main, ok := s.Defs["main"]
557557 if !ok {
558558- return fmt.Errorf("schema %q doesnt have a main def", s.ID)
558558+ return fmt.Errorf("schema %q doesn't have a main def", s.ID)
559559 }
560560561561 if main.Type == "procedure" || main.Type == "query" {
···642642643643 main, ok := s.Defs["main"]
644644 if !ok {
645645- return fmt.Errorf("schema %q doesnt have a main def", s.ID)
645645+ return fmt.Errorf("schema %q doesn't have a main def", s.ID)
646646 }
647647648648 if main.Type == "procedure" || main.Type == "query" {
···2626 }
2727}
28282929-// TODO: this code isnt great, should be rewritten on top of the baseline datastructures once functional and correct
2929+// TODO: this code isn't great, should be rewritten on top of the baseline datastructures once functional and correct
3030func DiffTrees(ctx context.Context, bs blockstore.Blockstore, from, to cid.Cid) ([]*DiffOp, error) {
3131 cst := cbor.NewCborStore(bs)
3232
+1-1
mst/mst.go
···483483func checkTreeInvariant(ents []NodeEntry) {
484484 for i := 0; i < len(ents)-1; i++ {
485485 if ents[i].isTree() && ents[i+1].isTree() {
486486- panic(fmt.Sprintf("two trees next to eachother! %d %d", i, i+1))
486486+ panic(fmt.Sprintf("two trees next to each other! %d %d", i, i+1))
487487 }
488488 }
489489}
···5454 accessTok := makeToken(otherpds, "com.atproto.federation", time.Now().Add(24*time.Hour))
55555656 // setting this is a little weird,
5757- // since the token isnt signed by this key, we dont have a way to validate...
5757+ // since the token isn't signed by this key, we dont have a way to validate...
5858 accessTok.Set("pds", s.signingKey.DID())
59596060 rval := make([]byte, 10)