goat plc: address review comments

cmd/goat/plc.go

···
 	"fmt"
 	"io"
 	"net/http"
+	"net/url"
 	"strings"
 	"time"
 
···
 
 	"github.com/urfave/cli/v2"
 )
-
-// TODO: use this consistently for all requests
-const GOAT_PLC_USER_AGENT = "goat-cli"
 
 var cmdPLC = &cli.Command{
 	Name:  "plc",
···
 			ArgsUsage: `<operation.json>`,
 			Flags: []cli.Flag{
 				&cli.StringFlag{
-					Name:    "plc-private-rotation-key",
-					Usage:   "private key used as a rotation key, if operation is not signed (multibase syntax)",
-					EnvVars: []string{"PLC_PRIVATE_ROTATION_KEY"},
+					Name:    "plc-signing-key",
+					Usage:   "private key used to sign operation (multibase syntax)",
+					EnvVars: []string{"PLC_SIGNING_KEY"},
 				},
 			},
 			Action: runPLCSign,
···
 		if err != nil {
 			return err
 		}
+		parsedHandle = parsedHandle.Normalize()
 		op.AlsoKnownAs = append(op.AlsoKnownAs, "at://"+string(parsedHandle))
 	}
 
···
 
 	pds := cctx.String("pds")
 	if pds != "" {
-		// TODO: check pds is valid URI?
+		parsedUrl, err := url.Parse(pds)
+		if err != nil {
+			return err
+		}
+		if !parsedUrl.IsAbs() {
+			return fmt.Errorf("invalid PDS URL: must be absolute")
+		}
 		op.Services["atproto_pds"] = didplc.OpService{
 			Type:     "AtprotoPersonalDataServer",
 			Endpoint: pds,
···
 		return fmt.Errorf("need to provide PLC operation json path as input")
 	}
 
-	privStr := cctx.String("plc-private-rotation-key")
+	privStr := cctx.String("plc-signing-key")
 	if privStr == "" {
 		return fmt.Errorf("private key must be provided")
 	}
···
 
 	c := didplc.Client{
 		DirectoryURL: cctx.String("plc-host"),
-		UserAgent:    GOAT_PLC_USER_AGENT,
+		UserAgent:    *userAgent(),
 	}
 
 	if err = c.Submit(ctx, didString, op); err != nil {
 		return err
 	}
 
-	// TODO: print confirmation?
+	fmt.Println("success")
 
 	return nil
 }
···
 		op = *baseOp
 		op.Sig = nil
 	case *didplc.LegacyOp:
-		op = baseOp.RegularOp()
+		op = baseOp.RegularOp() // also strips sig
 	case *didplc.TombstoneOp:
 		return nil, fmt.Errorf("cannot update from a tombstone op")
 	}
···
 
 	c := didplc.Client{
 		DirectoryURL: cctx.String("plc-host"),
-		UserAgent:    GOAT_PLC_USER_AGENT,
+		UserAgent:    *userAgent(),
 	}
 	op, err := fetchOpForUpdate(ctx, c, didString, prevCID)
 	if err != nil {
···
 
 	pds := cctx.String("pds")
 	if pds != "" {
-		// TODO: check pds is valid URI?
+		parsedUrl, err := url.Parse(pds)
+		if err != nil {
+			return err
+		}
+		if !parsedUrl.IsAbs() {
+			return fmt.Errorf("invalid PDS URL: must be absolute")
+		}
 		op.Services["atproto_pds"] = didplc.OpService{
 			Type:     "AtprotoPersonalDataServer",
 			Endpoint: pds,