plumbing: blame simplification

remove unused result parameter and dead code

blame.go

···
 		b.lineToCommit[i] = needsMap[i].Commit
 	}
 
-	lines, err := newLines(finalLines, b.lineToCommit)
-	if err != nil {
-		return nil, err
-	}
+	lines := newLines(finalLines, b.lineToCommit)
 
 	return &BlameResult{
 		Path:  path,
···
 	}
 }
 
-func newLines(contents []string, commits []*object.Commit) ([]*Line, error) {
+func newLines(contents []string, commits []*object.Commit) []*Line {
 	result := make([]*Line, 0, len(contents))
 	for i := range contents {
 		result = append(result, newLine(
···
 		))
 	}
 
-	return result, nil
+	return result
 }
 
 // this struct is internally used by the blame function to hold its

blame_test.go

···
 
 func (s *BlameSuite) TestNewLines() {
 	h := plumbing.NewHash("ce9f123d790717599aaeb76bc62510de437761be")
-	lines, err := newLines([]string{"foo"}, []*object.Commit{{
+	lines := newLines([]string{"foo"}, []*object.Commit{{
 		Hash:    h,
 		Message: "foo",
 	}})
 
-	s.NoError(err)
 	s.Len(lines, 1)
 	s.Equal("foo", lines[0].Text)
 	s.Equal(h, lines[0].Hash)
 }
 
 func (s *BlameSuite) TestNewLinesWithNewLine() {
-	lines, err := newLines([]string{"foo", ""}, []*object.Commit{
+	lines := newLines([]string{"foo", ""}, []*object.Commit{
 		{Message: "foo"},
 		{Message: "bar"},
 	})
 
-	s.NoError(err)
 	s.Len(lines, 2)
 	s.Equal("foo", lines[0].Text)
 	s.Equal("", lines[1].Text)