Technical test for a job interview.

added info on improvements branch's testing

authored by vylion and committed by GitHub e8986027 8723b9d0

Changed files
+3 -1
+3 -1
README.md
··· 4 5 Ideas for improvement: 6 7 - * Adding actual testing. 8 * Adding some permanence, so requests closer in time than 10 minutes use a local cache'd copy. 9 * Either keeping the parameters of the last cache'd call too, to manually convert temperature units if the user asks for a different one, or change queries to always get them in Kelvin and always do the manual calculations when presenting the info to the user. 10 * Adding the alternative API calls available at OpenWeather. 11 * Check that parameters are correct & compatible (city name with the country code, for example), using the resources from OpenWeather. 12 * Reusing the Http Client across API calls. 13 14 # Consulted Documentation 15
··· 4 5 Ideas for improvement: 6 7 + * Adding actual testing. Note: Some tests added [here](https://github.com/vylion/weather-rust-service/tree/improvements). 8 * Adding some permanence, so requests closer in time than 10 minutes use a local cache'd copy. 9 * Either keeping the parameters of the last cache'd call too, to manually convert temperature units if the user asks for a different one, or change queries to always get them in Kelvin and always do the manual calculations when presenting the info to the user. 10 + * Defining our own Json Weather & Forecast structs in `utils.rs` to allow for more complex parsing. 11 * Adding the alternative API calls available at OpenWeather. 12 * Check that parameters are correct & compatible (city name with the country code, for example), using the resources from OpenWeather. 13 * Reusing the Http Client across API calls. 14 + * Read the OpenWeather API key from parameters instead of hving it hardcoded. 15 16 # Consulted Documentation 17