personal web client for Bluesky
typescript solidjs bluesky atcute

refactor: remove id from mediaplay event

mary.my.id 419c7ac8 55af475c

verified
Changed files
+2 -8
src
components
globals
+1 -4
src/components/embeds/players/gif-player.tsx
··· 1 - import { nanoid } from 'nanoid/non-secure'; 2 import { createEffect, createSignal, onCleanup } from 'solid-js'; 3 4 import { globalEvents } from '~/globals/events'; ··· 14 } 15 16 const GifPlayer = ({ snippet }: GifPlayerProps) => { 17 - const playerId = nanoid(); 18 - 19 const [playing, setPlaying] = createSignal(false); 20 const [stalling, setStalling] = createSignal(false); 21 ··· 67 } 68 }} 69 onPlay={() => { 70 - globalEvents.emit('mediaplay', playerId); 71 setPlaying(true); 72 }} 73 onPause={() => {
··· 1 import { createEffect, createSignal, onCleanup } from 'solid-js'; 2 3 import { globalEvents } from '~/globals/events'; ··· 13 } 14 15 const GifPlayer = ({ snippet }: GifPlayerProps) => { 16 const [playing, setPlaying] = createSignal(false); 17 const [stalling, setStalling] = createSignal(false); 18 ··· 64 } 65 }} 66 onPlay={() => { 67 + globalEvents.emit('mediaplay'); 68 setPlaying(true); 69 }} 70 onPause={() => {
-3
src/components/embeds/players/video-player.tsx
··· 1 import type * as h from 'hls.js'; 2 import Hls from 'hls.js/dist/hls.light.js'; 3 - import { nanoid } from 'nanoid/non-secure'; 4 import { createEffect, createSignal, onCleanup } from 'solid-js'; 5 6 import type { AppBskyEmbedVideo } from '@atcute/bluesky'; ··· 21 const { currentAccount } = useSession(); 22 23 const [playing, setPlaying] = createSignal(false); 24 - const playerId = nanoid(); 25 26 const hls = new Hls({ 27 capLevelToPlayerSize: true, ··· 90 playsinline 91 autoplay 92 onPlay={() => { 93 - globalEvents.emit('mediaplay', playerId); 94 setPlaying(true); 95 }} 96 onPause={() => {
··· 1 import type * as h from 'hls.js'; 2 import Hls from 'hls.js/dist/hls.light.js'; 3 import { createEffect, createSignal, onCleanup } from 'solid-js'; 4 5 import type { AppBskyEmbedVideo } from '@atcute/bluesky'; ··· 20 const { currentAccount } = useSession(); 21 22 const [playing, setPlaying] = createSignal(false); 23 24 const hls = new Hls({ 25 capLevelToPlayerSize: true, ··· 88 playsinline 89 autoplay 90 onPlay={() => { 91 setPlaying(true); 92 }} 93 onPause={() => {
+1 -1
src/globals/events.ts
··· 4 // User has published a post 5 postpublished: []; 6 // Media is being played 7 - mediaplay: [id: string]; 8 // User initiated scroll to top 9 softreset: []; 10 }>();
··· 4 // User has published a post 5 postpublished: []; 6 // Media is being played 7 + mediaplay: []; 8 // User initiated scroll to top 9 softreset: []; 10 }>();