split discussion page and mode

resources/js/beatmap-discussions/discussion-mode.ts

···
 // Copyright (c) ppy Pty Ltd <[e-mail]>. Licensed under the GNU Affero General Public License v3.0.
 // See the LICENCE file in the repository root for full licence text.
 
-// In display order on discussion page tabs
-export const discussionPages = ['reviews', 'generalAll', 'general', 'timeline', 'events'] as const;
-export type DiscussionPage = (typeof discussionPages)[number];
-
-const discussionPageSet = new Set<unknown>(discussionPages);
-
-export function isDiscussionPage(value: unknown): value is DiscussionPage{
-  return discussionPageSet.has(value);
-}
+import DiscussionPage from './discussion-page';
 
 type DiscussionMode = Exclude<DiscussionPage, 'events'>;
 export const discussionModes: Readonly<DiscussionMode[]> = ['reviews', 'generalAll', 'general', 'timeline'] as const;

resources/js/beatmap-discussions/discussion-page.ts

···
+// Copyright (c) ppy Pty Ltd <[e-mail]>. Licensed under the GNU Affero General Public License v3.0.
+// See the LICENCE file in the repository root for full licence text.
+
+// In display order on discussion page tabs
+export const discussionPages = ['reviews', 'generalAll', 'general', 'timeline', 'events'] as const;
+type DiscussionPage = (typeof discussionPages)[number];
+
+const discussionPageSet = new Set<unknown>(discussionPages);
+
+export function isDiscussionPage(value: unknown): value is DiscussionPage {
+  return discussionPageSet.has(value);
+}
+
+export default DiscussionPage;

resources/js/beatmap-discussions/discussions-state.ts

···
 import { findDefault, group, sortWithMode } from 'utils/beatmap-helper';
 import { canModeratePosts, makeUrl, parseUrl } from 'utils/beatmapset-discussion-helper';
 import { Filter, filters } from './current-discussions';
-import DiscussionMode, { DiscussionPage, discussionModes, isDiscussionPage } from './discussion-mode';
+import DiscussionMode, { discussionModes } from './discussion-mode';
+import DiscussionPage, { isDiscussionPage } from './discussion-page';
 
 export interface UpdateOptions {
   beatmap_discussion_post_ids: number[];

resources/js/beatmap-discussions/mode-switcher.tsx

···
 import { makeUrl } from 'utils/beatmapset-discussion-helper';
 import { classWithModifiers } from 'utils/css';
 import { trans } from 'utils/lang';
-import { DiscussionPage, discussionPages } from './discussion-mode';
+import DiscussionPage, { discussionPages } from './discussion-page';
 import DiscussionsState from './discussions-state';
 
 interface Props {

resources/js/utils/beatmapset-discussion-helper.ts

···
 // See the LICENCE file in the repository root for full licence text.
 
 import { Filter, filters } from 'beatmap-discussions/current-discussions';
-import DiscussionMode, { DiscussionPage, discussionPages } from 'beatmap-discussions/discussion-mode';
+import DiscussionMode from 'beatmap-discussions/discussion-mode';
+import DiscussionPage, { isDiscussionPage } from 'beatmap-discussions/discussion-page';
 import guestGroup from 'beatmap-discussions/guest-group';
 import mapperGroup from 'beatmap-discussions/mapper-group';
 import BeatmapJson from 'interfaces/beatmap-json';
···
 // parseUrl and makeUrl lookups
 const filterLookup = new Set<unknown>(filters);
 const generalPages = new Set<unknown>(['events', 'generalAll', 'reviews']);
-const pageLookup = new Set<unknown>(discussionPages);
 
 const defaultBeatmapId = '-';
 
···
   const m = Math.floor(value / 1000 / 60);
 
   return `${padStart(m.toString(), 2, '0')}:${padStart(s.toString(), 2, '0')}:${padStart(ms.toString(), 3, '0')}`;
-}
-
-
-function isDiscussionPage(value: string): value is DiscussionPage {
-  return pageLookup.has(value);
 }
 
 function isFilter(value: string): value is Filter {