use subtypes for results

resources/js/contest-judge-results/header.tsx

···
 import BasicSelectOptions from 'components/basic-select-options';
 import UserLink from 'components/user-link';
 import ValueDisplay from 'components/value-display';
-import ContestEntryJson from 'interfaces/contest-entry-json';
-import ContestJson from 'interfaces/contest-json';
+import { ContestEntryJsonForResults } from 'interfaces/contest-entry-json';
+import { ContestJsonForResults } from 'interfaces/contest-json';
 import SelectOptionJson from 'interfaces/select-option-json';
 import * as React from 'react';
 import { trans } from 'utils/lang';
 
 interface Props {
-  contest: ContestJson;
-  entries: ContestEntryJson[];
-  entry: ContestEntryJson;
+  contest: ContestJsonForResults;
+  entries: ContestEntryJsonForResults[];
+  entry: ContestEntryJsonForResults;
 }
 
 export default class Header extends React.PureComponent<Props> {
···
   render() {
     const { contest, entry } = this.props;
 
-    const score = entry.results?.votes;
-    const maxScore = (contest.max_judging_score ?? 0) * (entry.judge_votes?.length ?? 0);
+    const score = entry.results.votes;
+    const maxScore = contest.max_judging_score * entry.judge_votes.length;
     const totalScore = `${score}/${maxScore}`;
-
-    const userLink = this.renderUserLink();
 
     return (
       <div className='contest-judge-results-header'>
···
         />
 
         <div className='contest-judge-results-header__values'>
-          {score != null && <ValueDisplay
+          <ValueDisplay
             label={trans('contest.judge_results.total_score')}
             modifiers={'judge-results'}
             value={totalScore}
-          />}
+          />
 
-          {userLink != null && <ValueDisplay
+          <ValueDisplay
             label={trans('contest.judge_results.creator')}
             modifiers={'judge-results'}
-            value={userLink}
-          />}
+            value={
+              <UserLink user={this.props.entry.user} />
+            }
+          />
         </div>
       </div>
     );
   }
 
-  private entryToSelectOption(entry: ContestEntryJson): SelectOptionJson {
+  private entryToSelectOption(entry: ContestEntryJsonForResults): SelectOptionJson {
     return {
       id: entry.id,
       text: entry.title,
     };
-  }
-
-  private renderUserLink() {
-    const { user } = this.props.entry;
-    if (user == null) return;
-
-    return (
-      <UserLink user={user} />
-    );
   }
 }

resources/js/contest-judge-results/main.tsx

···
 // Copyright (c) ppy Pty Ltd <[e-mail]>. Licensed under the GNU Affero General Public License v3.0.
 // See the LICENCE file in the repository root for full licence text.
 
-import ContestEntryJson from 'interfaces/contest-entry-json';
-import ContestJson from 'interfaces/contest-json';
+import { ContestEntryJsonForResults } from 'interfaces/contest-entry-json';
+import { ContestJsonForResults } from 'interfaces/contest-json';
 import * as React from 'react';
 import Header from './header';
 import Vote from './vote';
 
 interface Props {
-  contest: ContestJson;
-  entries: ContestEntryJson[];
-  entry: ContestEntryJson;
+  contest: ContestJsonForResults;
+  entries: ContestEntryJsonForResults[];
+  entry: ContestEntryJsonForResults;
 }
 
 export default function Main(props: Props) {
···
       />
 
       <div className='contest-judge-results'>
-        {props.entry.judge_votes?.map((vote) => (
+        {props.entry.judge_votes.map((vote) => (
           <Vote
             key={vote.id}
             contest={props.contest}

resources/js/contest-judge-results/vote.tsx

···
 import UserAvatar from 'components/user-avatar';
 import UserLink from 'components/user-link';
 import ValueDisplay from 'components/value-display';
-import ContestJson from 'interfaces/contest-json';
-import ContestJudgeVoteJson from 'interfaces/contest-judge-vote-json';
+import { ContestJsonForResults } from 'interfaces/contest-json';
+import { ContestJudgeVoteJsonForResults } from 'interfaces/contest-judge-vote-json';
 import * as React from 'react';
 import { trans } from 'utils/lang';
 
 interface Props {
-  contest: ContestJson;
-  vote: ContestJudgeVoteJson;
+  contest: ContestJsonForResults;
+  vote: ContestJudgeVoteJsonForResults;
 }
 
 export default function Vote(props: Props) {
···
       </div>
 
       <div className='contest-judge-results-scores'>
-        {props.vote.scores?.map((score) => (
+        {props.vote.scores.map((score) => (
           <div key={score.id} className='contest-judge-results-scores__row'>
             <div className='contest-judge-results-scores__col'>
               <div className='contest-judge-entry__description-icon' title={score.category?.description}>

resources/js/interfaces/contest-entry-json.ts

···
 // Copyright (c) ppy Pty Ltd <[e-mail]>. Licensed under the GNU Affero General Public License v3.0.
 // See the LICENCE file in the repository root for full licence text.
 
-import ContestJudgeVoteJson from './contest-judge-vote-json';
+import ContestJudgeVoteJson, { ContestJudgeVoteJsonForResults } from './contest-judge-vote-json';
 
-export default interface ContestEntryJson {
-  contest_id: number;
-  current_user_judge_vote?: ContestJudgeVoteJson;
-  id: number;
-  judge_votes?: ContestJudgeVoteJson[];
-  results?: {
+interface ContestEntryJsonAvailableIncludes {
+  current_user_judge_vote: ContestJudgeVoteJson;
+  results: {
     actual_name: string;
     votes: number;
   };
-  title: string;
-  user?: {
+  judge_votes: ContestJudgeVoteJson[];
+  user: {
     id: number;
     username: string;
   };
 }
+
+interface ContestEntryJsonDefaultAttributes {
+  contest_id: number;
+  id: number;
+  title: string;
+}
+
+type ContestEntryJson = ContestEntryJsonDefaultAttributes
+& Partial<ContestEntryJsonAvailableIncludes>;
+export default ContestEntryJson;
+
+export type ContestEntryJsonForResults = ContestEntryJsonDefaultAttributes
+& Required<Pick<ContestEntryJsonAvailableIncludes, 'results' | 'user'>>
+& {
+  judge_votes: ContestJudgeVoteJsonForResults[];
+};

resources/js/interfaces/contest-json.ts

···
 // Copyright (c) ppy Pty Ltd <[e-mail]>. Licensed under the GNU Affero General Public License v3.0.
 // See the LICENCE file in the repository root for full licence text.
 
-import ContestEntryJson from './contest-entry-json';
+import ContestEntryJson, { ContestEntryJsonForResults } from './contest-entry-json';
 import ContestScoringCategoryJson from './contest-scoring-category-json';
 
-export default interface ContestJson {
-  entries?: ContestEntryJson[];
+interface ContestJsonAvailableIncludes {
+  entries: ContestEntryJson[];
+  max_judging_score: number;
+  scoring_categories: ContestScoringCategoryJson[];
+}
+
+interface ContestJsonDefaultAttributes {
   id: number;
-  max_judging_score?: number;
   name: string;
-  scoring_categories?: ContestScoringCategoryJson[];
 }
+
+type ContestJson = ContestJsonDefaultAttributes & Partial<ContestJsonAvailableIncludes>;
+export default ContestJson;
+
+export type ContestJsonForResults = ContestJsonDefaultAttributes
+& Required<Pick<ContestJsonAvailableIncludes, 'max_judging_score' | 'scoring_categories'>>
+& {
+  entires: ContestEntryJsonForResults;
+};

resources/js/interfaces/contest-judge-vote-json.ts

···
   total_score?: number;
   user?: UserJson;
 }
+
+export type ContestJudgeVoteJsonForResults = ContestJudgeVoteJson
+& Required<Pick<ContestJudgeVoteJson, 'scores' | 'total_score'>>;