Add class based factory for Changelog

database/factories/ChangelogFactory.php

···
 // Copyright (c) ppy Pty Ltd <[e-mail]>. Licensed under the GNU Affero General Public License v3.0.
 // See the LICENCE file in the repository root for full licence text.
 
-/*
-|--------------------------------------------------------------------------
-| Model Factories
-|--------------------------------------------------------------------------
-|
-| Here you may define all of your model factories. Model factories give
-| you a convenient way to create models for testing and seeding your
-| database. Just tell the factory how a default model should look.
-|
-*/
+declare(strict_types=1);
+
+namespace Database\Factories;
 
+use App\Models\Changelog;
 use App\Models\User;
 
-$factory->define(App\Models\Changelog::class, function (Faker\Generator $faker) {
-    return [
-        'user_id' => function () {
-            $u = User::inRandomOrder()->first() ?? User::factory()->create();
+class ChangelogFactory extends Factory
+{
+    protected $model = Changelog::class;
 
-            return $u->getKey();
-        },
-        'prefix' => $faker->randomElement(['*', '+', '?']),
-        'category' => $faker->randomElement(['Web', 'Audio', 'Code', 'Editor', 'Gameplay', 'Graphics']),
-        'message' => $faker->catchPhrase,
-        'checksum' => $faker->md5,
-        'date' => $faker->dateTimeBetween('-6 weeks', 'now'),
-    ];
-});
+    public function definition(): array
+    {
+        return [
+            'user_id' => User::factory(),
+            'prefix' => fn() => $this->faker->randomElement(['*', '+', '?']),
+            'category' => fn() => $this->faker->randomElement(['Web', 'Audio', 'Code', 'Editor', 'Gameplay', 'Graphics']),
+            'message' => fn() => $this->faker->catchPhrase(),
+            'checksum' => fn() => $this->faker->md5,
+            'date' => fn() => $this->faker->dateTimeBetween('-6 weeks'),
+        ];
+    }
+}

database/seeders/ModelSeeders/ChangelogSeeder.php

···
             ->merge(Build::factory()->count(5)->create(['stream_id' => $fallback->stream_id]));
 
         foreach ($builds as $build) {
-            factory(Changelog::class, 5)->create([
+            Changelog::factory()->count(5)->create([
                 'build' => $build->version,
                 'stream_id' => $build->stream_id,
             ]);
         }
 
         // create some buildless changes
-        factory(Changelog::class, 15)->create([
+        Changelog::factory()->count(15)->create([
             'build' => null,
             'stream_id' => 5,
         ]);
 
-        factory(Changelog::class, 5)->create([
+        Changelog::factory()->count(5)->create([
             'build' => null,
             'stream_id' => 1,
         ]);

tests/Browser/SanityTest.php

···
 
         // factory for /home/changelog/*
         self::$scaffolding['stream'] = factory(UpdateStream::class)->create();
-        self::$scaffolding['changelog'] = factory(Changelog::class)->create([
+        self::$scaffolding['changelog'] = Changelog::factory()->create([
             'stream_id' => self::$scaffolding['stream']->stream_id,
         ]);
         self::$scaffolding['build'] = Build::factory()->create([

tests/Middleware/RouteScopesTest.php

···
             'stream_id' => 1, // Changelog stream_id is tinyint, autoincrement makes test fail too soon.
         ]);
 
-        factory(Changelog::class)->create([
+        Changelog::factory()->create([
             'stream_id' => $stream->getKey(),
             'user_id' => 1, // user doesn't need to exist and not having to create a user makes the test much faster
         ]);