Remove slack notification for forum updates

app/Http/Controllers/Forum/TopicsController.php

···
 namespace App\Http\Controllers\Forum;
 
 use App\Exceptions\ModelNotSavedException;
-use App\Libraries\ForumUpdateNotifier;
+use App\Jobs\Notifications\ForumTopicReply;
 use App\Libraries\NewForumTopic;
 use App\Models\Forum\FeatureVote;
 use App\Models\Forum\Forum;
···
         $firstPostPosition = $topic->postPosition($post->post_id);
 
         $post->markRead(Auth::user());
-        ForumUpdateNotifier::onReply([
-            'topic' => $topic,
-            'post' => $post,
-            'user' => Auth::user(),
-        ]);
+        (new ForumTopicReply($post, auth()->user()))->dispatch();
 
         return ext_view('forum.topics._posts', compact('posts', 'firstPostPosition', 'topic'));
     }
···
 
         $post = $topic->posts->last();
         $post->markRead($user);
-        ForumUpdateNotifier::onNew(['topic' => $topic, 'post' => $post, 'user' => $user]);
 
         return ujs_redirect(route('forum.topics.show', $topic));
     }

app/Jobs/NotifyForumUpdateSlack.php

···
-<?php
-
-// Copyright (c) ppy Pty Ltd <[e-mail]>. Licensed under the GNU Affero General Public License v3.0.
-// See the LICENCE file in the repository root for full licence text.
-
-namespace App\Jobs;
-
-use Illuminate\Bus\Queueable;
-use Illuminate\Contracts\Queue\ShouldQueue;
-use Illuminate\Queue\SerializesModels;
-use Slack;
-
-class NotifyForumUpdateSlack implements ShouldQueue
-{
-    use Queueable, SerializesModels;
-
-    public $topic;
-    public $post;
-    public $user;
-    public $prefix;
-    public $message;
-
-    public function __construct($data, $type)
-    {
-        $this->topic = $data['topic'];
-        $this->post = $data['post'];
-        $this->user = $data['user'];
-
-        switch ($type) {
-            case 'new':
-                $this->message = 'A new topic has been created at watched forum';
-                $this->prefix = 'New topic';
-                break;
-            case 'reply':
-                $this->message = 'A watched topic has been replied to';
-                $this->prefix = 'Reply';
-                break;
-        }
-    }
-
-    public function dispatchIfNeeded()
-    {
-        if (!$this->shouldNotify()) {
-            return;
-        }
-
-        return dispatch($this);
-    }
-
-    public function handle()
-    {
-        if ($this->topic === null || $this->post === null || $this->user === null) {
-            return;
-        }
-
-        // FIXME: travis explodes without this
-        if (app()->runningUnitTests()) {
-            return;
-        }
-
-        return Slack::to('dev')
-            ->attach([
-                'color' => $this->notifyColour(),
-                'fallback' => $this->message,
-                'text' => $this->post->post_text,
-            ])
-            ->send($this->mainMessage());
-    }
-
-    private function shouldNotify()
-    {
-        return in_array($this->topic->getKey(), config('osu.forum.slack_watch.topic_ids'), true) ||
-            in_array($this->topic->forum_id, config('osu.forum.slack_watch.forum_ids'), true);
-    }
-
-    private function replyCommand()
-    {
-        $topicHash = base62_encode($this->topic->topic_id);
-
-        return "/msg #support !reply {$topicHash} <text>";
-    }
-
-    private function notifyColour()
-    {
-        if ($this->isFromSupport()) {
-            return 'good';
-        } elseif ($this->topic->topic_poster === $this->user->user_id) {
-            return 'warning';
-        } else {
-            return 'danger';
-        }
-    }
-
-    private function mainMessage()
-    {
-        $user = $this->userText();
-        $url = post_url($this->post->topic_id, $this->post->post_id);
-        $title = $this->topic->topic_title;
-        $command = $this->replyCommand();
-        $prefix = $this->prefix;
-
-        return "{$prefix}: <{$url}|{$title}> by {$user} `{$command}`";
-    }
-
-    private function isFromSupport()
-    {
-        return $this->user->isAdmin() || $this->user->isDev();
-    }
-
-    private function userText()
-    {
-        $suffix = '';
-        if ($this->isFromSupport()) {
-            $suffix = ' (Support Team)';
-        } elseif ($this->post->post_id !== $this->topic->topic_first_post_id &&
-            $this->topic->topic_poster === $this->user->user_id) {
-            $suffix = ' (OP)';
-        }
-
-        return $this->user->username.$suffix;
-    }
-}

app/Libraries/ForumUpdateNotifier.php

···
-<?php
-
-// Copyright (c) ppy Pty Ltd <[e-mail]>. Licensed under the GNU Affero General Public License v3.0.
-// See the LICENCE file in the repository root for full licence text.
-
-namespace App\Libraries;
-
-use App\Jobs\Notifications\ForumTopicReply;
-use App\Jobs\NotifyForumUpdateSlack;
-
-class ForumUpdateNotifier
-{
-    public static function onNew($data)
-    {
-        (new NotifyForumUpdateSlack($data, 'new'))->dispatchIfNeeded();
-    }
-
-    public static function onReply($data)
-    {
-        (new ForumTopicReply($data['post'], $data['user']))->dispatch();
-
-        (new NotifyForumUpdateSlack($data, 'reply'))->dispatchIfNeeded();
-    }
-}

composer.json

···
   "repositories": [
     {
       "type": "vcs",
-      "url": "https://github.com/nanaya/slack-php"
-    },
-    {
-      "type": "vcs",
       "url": "https://github.com/nanaya/xsolla-sdk-php"
     }
   ],
···
     "league/flysystem-aws-s3-v3": "*",
     "league/fractal": "*",
     "league/html-to-markdown": "*",
-    "maknz/slack": "dev-laravel-any",
     "mariuzzo/laravel-js-localization": "*",
     "mpociot/laravel-apidoc-generator": "*",
     "paypal/rest-api-sdk-php": "*",

composer.lock

···
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
         "This file is @generated automatically"
     ],
-    "content-hash": "ef0fdf25b31794ec636428dc9d1635e8",
+    "content-hash": "4ddecf6dfc12f377b4abb2d812e2bdbf",
     "packages": [
         {
             "name": "anhskohbo/no-captcha",
···
             "authors": [
                 {
                     "name": "Alex Corley",
-                    "email": "[e-mail]",
-                    "role": "Developer"
+                    "role": "Developer",
+                    "email": "[e-mail]"
                 },
                 {
                     "name": "Datadog",
-                    "email": "[e-mail]",
-                    "role": "Developer"
+                    "role": "Developer",
+                    "email": "[e-mail]"
                 }
             ],
             "description": "This is an extremely simple PHP datadogstatsd client",
···
             "time": "2019-07-13T18:58:26+00:00"
         },
         {
-            "name": "maknz/slack",
-            "version": "dev-laravel-any",
-            "source": {
-                "type": "git",
-                "url": "https://github.com/nanaya/slack-php.git",
-                "reference": "2f8534e23ffd5d6255f347f61a94c40a17029f42"
-            },
-            "dist": {
-                "type": "zip",
-                "url": "https://api.github.com/repos/nanaya/slack-php/zipball/2f8534e23ffd5d6255f347f61a94c40a17029f42",
-                "reference": "2f8534e23ffd5d6255f347f61a94c40a17029f42",
-                "shasum": ""
-            },
-            "require": {
-                "ext-mbstring": "*",
-                "guzzlehttp/guzzle": "~6.0|~5.0|~4.0",
-                "php": ">=5.4.0"
-            },
-            "require-dev": {
-                "mockery/mockery": "0.9.*",
-                "phpunit/phpunit": "4.2.*"
-            },
-            "suggest": {
-                "illuminate/support": "Required for Laravel support"
-            },
-            "type": "library",
-            "autoload": {
-                "psr-4": {
-                    "Maknz\\Slack\\": "src/"
-                }
-            },
-            "license": [
-                "BSD-2-Clause"
-            ],
-            "authors": [
-                {
-                    "name": "maknz",
-                    "email": "[e-mail]"
-                }
-            ],
-            "description": "A simple PHP package for sending messages to Slack, with a focus on ease of use and elegant syntax. Includes Laravel support out of the box.",
-            "keywords": [
-                "laravel",
-                "slack"
-            ],
-            "support": {
-                "source": "https://github.com/nanaya/slack-php/tree/laravel-any"
-            },
-            "time": "2019-09-27T02:54:26+00:00"
-        },
-        {
             "name": "mariuzzo/laravel-js-localization",
             "version": "v1.5.0",
             "source": {
···
             "version": "v0.8.1",
             "source": {
                 "type": "git",
-                "url": "https://github.com/tightenco/ziggy.git",
+                "url": "https://github.com/tighten/ziggy.git",
                 "reference": "4c4b29bc658153f0771b0a145173ce83a7b6b885"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/tightenco/ziggy/zipball/4c4b29bc658153f0771b0a145173ce83a7b6b885",
+                "url": "https://api.github.com/repos/tighten/ziggy/zipball/4c4b29bc658153f0771b0a145173ce83a7b6b885",
                 "reference": "4c4b29bc658153f0771b0a145173ce83a7b6b885",
                 "shasum": ""
             },
···
             "authors": [
                 {
                     "name": "Arne Blankerts",
-                    "email": "[e-mail]",
-                    "role": "Developer"
+                    "role": "Developer",
+                    "email": "[e-mail]"
                 },
                 {
                     "name": "Sebastian Heuer",
-                    "email": "[e-mail]",
-                    "role": "Developer"
+                    "role": "Developer",
+                    "email": "[e-mail]"
                 },
                 {
                     "name": "Sebastian Bergmann",
-                    "email": "[e-mail]",
-                    "role": "Developer"
+                    "role": "Developer",
+                    "email": "[e-mail]"
                 }
             ],
             "description": "Component for reading phar.io manifest information from a PHP Archive (PHAR)",
···
             "authors": [
                 {
                     "name": "Arne Blankerts",
-                    "email": "[e-mail]",
-                    "role": "Developer"
+                    "role": "Developer",
+                    "email": "[e-mail]"
                 },
                 {
                     "name": "Sebastian Heuer",
-                    "email": "[e-mail]",
-                    "role": "Developer"
+                    "role": "Developer",
+                    "email": "[e-mail]"
                 },
                 {
                     "name": "Sebastian Bergmann",
-                    "email": "[e-mail]",
-                    "role": "Developer"
+                    "role": "Developer",
+                    "email": "[e-mail]"
                 }
             ],
             "description": "Library for handling version information and constraints",
···
             "authors": [
                 {
                     "name": "Sebastian Bergmann",
-                    "email": "[e-mail]",
-                    "role": "lead"
+                    "role": "lead",
+                    "email": "[e-mail]"
                 }
             ],
             "description": "FilterIterator implementation that filters files based on a list of suffixes.",
···
             "authors": [
                 {
                     "name": "Sebastian Bergmann",
-                    "email": "[e-mail]",
-                    "role": "lead"
+                    "role": "lead",
+                    "email": "[e-mail]"
                 }
             ],
             "description": "Utility class for timing",
···
     ],
     "aliases": [],
     "minimum-stability": "stable",
-    "stability-flags": {
-        "maknz/slack": 20
-    },
+    "stability-flags": [],
     "prefer-stable": false,
     "prefer-lowest": false,
     "platform": [],

config/app.php

···
          * Package Service Providers...
          */
         GrahamCampbell\GitHub\GitHubServiceProvider::class,
-        Maknz\Slack\SlackServiceProvider::class,
         Mariuzzo\LaravelJsLocalization\LaravelJsLocalizationServiceProvider::class,
         Laravel\Tinker\TinkerServiceProvider::class,
 
···
 
         'GitHub' => GrahamCampbell\GitHub\Facades\GitHub::class,
 
-        'Slack' => Maknz\Slack\Facades\Slack::class,
         'Datadog' => ChaseConey\LaravelDatadogHelper\Datadog::class,
     ],
 

config/slack.php

···
     */
 
     'endpoint' => env('SLACK_ENDPOINT'),
-
-    /*
-    |-------------------------------------------------------------
-    | Default channel
-    |-------------------------------------------------------------
-    |
-    | The default channel we should post to. The channel can either be a
-    | channel like #general, a private #group, or a @username. Set to
-    | null to use the default set on the Slack webhook
-    |
-    */
-
-    'channel' => 'store',
-
-    /*
-    |-------------------------------------------------------------
-    | Default username
-    |-------------------------------------------------------------
-    |
-    | The default username we should post as. Set to null to use
-    | the default set on the Slack webhook
-    |
-    */
-
-    'username' => 'osu!web',
-
-    /*
-    |-------------------------------------------------------------
-    | Default icon
-    |-------------------------------------------------------------
-    |
-    | The default icon to use. This can either be a URL to an image or Slack
-    | emoji like :ghost: or :heart_eyes:. Set to null to use the default
-    | set on the Slack webhook
-    |
-    */
-
-    'icon' => null,
-
-    /*
-    |-------------------------------------------------------------
-    | Link names
-    |-------------------------------------------------------------
-    |
-    | Whether names like @regan should be converted into links
-    | by Slack
-    |
-    */
-
-    'link_names' => false,
-
-    /*
-    |-------------------------------------------------------------
-    | Unfurl links
-    |-------------------------------------------------------------
-    |
-    | By default, Slack will unfurl links from well known media
-    | sources like YouTube and Twitter. If you want Slack to unfurl
-    | other URLs, enable this option
-    |
-    */
-
-    'unfurl_links' => false,
 ];