remove overlapping functions

there was a `is_record_constructor` function that did basically the same
as `is_record_builder` but was more limited (e.g. couldn't understand a
module select was still a record builder). So I removed that function
and replaced its usage with the better `is_record_builder`

compiler-core/src/ast/typed.rs

···
 
             // Calls are literals if they are records and all the arguemnts are also literals.
             Self::Call { fun, args, .. } => {
-                fun.is_record_constructor()
-                    && args.iter().all(|argument| argument.value.is_literal())
+                fun.is_record_builder() && args.iter().all(|argument| argument.value.is_literal())
             }
 
             // Variables are literals if they are record constructors that take no arguments.
···
             | TypedExpr::NegateBool { .. }
             | TypedExpr::NegateInt { .. }
             | TypedExpr::Invalid { .. } => Purity::Unknown,
-        }
-    }
-
-    #[must_use]
-    // TODO)) is this the same as is_record_builder
-    pub fn is_record_constructor(&self) -> bool {
-        match self {
-            TypedExpr::Var {
-                constructor:
-                    ValueConstructor {
-                        variant: ValueConstructorVariant::Record { .. },
-                        ..
-                    },
-                ..
-            } => true,
-            _ => false,
         }
     }
 

compiler-core/src/type_/tests/snapshots/gleam_core__type___tests__warnings__unused_module_select_constructor_call.snap

···
 
 
 ----- WARNING
-warning: Unused value
+warning: Unused literal
   ┌─ /src/warning/wrn.gleam:5:3
   │
 5 │   wibble.Wibble(1)
   │   ^^^^^^^^^^^^^^^^ This value is never used
 
-This expression computes a value without any side effects, but then the
-value isn't used at all. You might want to assign it to a variable, or
-delete the expression entirely if it's not needed.
+Hint: You can safely remove it.