appview: {db,issues}: remove unnecessary `GetIssueId` method

As `issue.IssueId` is already retrieved from `NewIssue`, We don't need
`GetIssueId` to get last issue-id.
Using same, last inserted issue-id would be better.

Signed-off-by: Seongmin Lee <[e-mail]>

appview/db/issues.go

···
 	return issueAt, err
 }
 
-func GetIssueId(e Execer, repoAt syntax.ATURI) (int, error) {
-	var issueId int
-	err := e.QueryRow(`select next_issue_id from repo_issue_seqs where repo_at = ?`, repoAt).Scan(&issueId)
-	return issueId - 1, err
-}
-
 func GetIssueOwnerDid(e Execer, repoAt syntax.ATURI, issueId int) (string, error) {
 	var ownerDid string
 	err := e.QueryRow(`select owner_did from issues where repo_at = ? and issue_id = ?`, repoAt, issueId).Scan(&ownerDid)

appview/issues/issues.go

···
 			return
 		}
 
-		err = db.NewIssue(tx, &db.Issue{
+		issue := &db.Issue{
 			RepoAt:   f.RepoAt,
 			Title:    title,
 			Body:     body,
 			OwnerDid: user.Did,
-		})
-		if err != nil {
-			log.Println("failed to create issue", err)
-			rp.pages.Notice(w, "issues", "Failed to create issue.")
-			return
 		}
-
-		issueId, err := db.GetIssueId(rp.db, f.RepoAt)
+		err = db.NewIssue(tx, issue)
 		if err != nil {
-			log.Println("failed to get issue id", err)
+			log.Println("failed to create issue", err)
 			rp.pages.Notice(w, "issues", "Failed to create issue.")
 			return
 		}
···
 					Title:   title,
 					Body:    &body,
 					Owner:   user.Did,
-					IssueId: int64(issueId),
+					IssueId: int64(issue.IssueId),
 				},
 			},
 		})
···
 			return
 		}
 
-		err = db.SetIssueAt(rp.db, f.RepoAt, issueId, resp.Uri)
+		err = db.SetIssueAt(rp.db, f.RepoAt, issue.IssueId, resp.Uri)
 		if err != nil {
 			log.Println("failed to set issue at", err)
 			rp.pages.Notice(w, "issues", "Failed to create issue.")
···
 			err = rp.posthog.Enqueue(posthog.Capture{
 				DistinctId: user.Did,
 				Event:      "new_issue",
-				Properties: posthog.Properties{"repo_at": f.RepoAt.String(), "issue_id": issueId},
+				Properties: posthog.Properties{"repo_at": f.RepoAt.String(), "issue_id": issue.IssueId},
 			})
 			if err != nil {
 				log.Println("failed to enqueue posthog event:", err)
 			}
 		}
 
-		rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", f.OwnerSlashRepo(), issueId))
+		rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", f.OwnerSlashRepo(), issue.IssueId))
 		return
 	}
 }