openbsd-src/lib/libc/yp/ at jcs · jcs.org/openbsd-src

jcs.org / openbsd-src

jcs's openbsd hax

openbsd

openbsd-src / lib / libc / yp /

at jcs 35 files

there is no function called ypclnt(3), but yp_bind(3) exists...

6 years ago

Wrap _yp_check() and _yp_unbind() so internal calls go direct and they're weak

10 years ago

xdr_domainname.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypbind_binding.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypbind_resp.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypbind_resptype.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypbind_setdom.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypmaplist.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypreq_key.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypreq_nokey.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypresp_all.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypresp_key_val.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypresp_maplist.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypresp_master.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypresp_order.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

xdr_ypresp_val.c

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared dom_binding structs between threads, which is unsafe -- example, dom_vers signalled retry events, and structs+socket would get deallocated in _yp_unbind. Change all yp_first (and similar) functions to understand that _yp_dobind now provides a private dom_binding and socket, which must be released using _yp_unbind. Use similar methods in the one-step yp_all function. 2) domainname caching in get* is not neccessary now that the domainname cannot change relative to ypconnect(2)'s decisions. Many fields in dom_binding struct become unused, so delete them. ok jmatthew, also tested by miod

3 years ago

correct articles

5 months ago

When getpwnam(3) reaches out to YP, it calls clntudp_create(3) with a pre-initialized ypconnect(2) socket. That calls clntudp_bufcreate(), which contains code checking if the socket and address are configured.. If not, socket(2) is called, or an address allocation is performed via the portmapper (which calls a whole lot more code).

2 years ago

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared dom_binding structs between threads, which is unsafe -- example, dom_vers signalled retry events, and structs+socket would get deallocated in _yp_unbind. Change all yp_first (and similar) functions to understand that _yp_dobind now provides a private dom_binding and socket, which must be released using _yp_unbind. Use similar methods in the one-step yp_all function. 2) domainname caching in get* is not neccessary now that the domainname cannot change relative to ypconnect(2)'s decisions. Many fields in dom_binding struct become unused, so delete them. ok jmatthew, also tested by miod

3 years ago

yp_get_default_domain.c

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared dom_binding structs between threads, which is unsafe -- example, dom_vers signalled retry events, and structs+socket would get deallocated in _yp_unbind. Change all yp_first (and similar) functions to understand that _yp_dobind now provides a private dom_binding and socket, which must be released using _yp_unbind. Use similar methods in the one-step yp_all function. 2) domainname caching in get* is not neccessary now that the domainname cannot change relative to ypconnect(2)'s decisions. Many fields in dom_binding struct become unused, so delete them. ok jmatthew, also tested by miod

3 years ago

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared dom_binding structs between threads, which is unsafe -- example, dom_vers signalled retry events, and structs+socket would get deallocated in _yp_unbind. Change all yp_first (and similar) functions to understand that _yp_dobind now provides a private dom_binding and socket, which must be released using _yp_unbind. Use similar methods in the one-step yp_all function. 2) domainname caching in get* is not neccessary now that the domainname cannot change relative to ypconnect(2)'s decisions. Many fields in dom_binding struct become unused, so delete them. ok jmatthew, also tested by miod

3 years ago

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared dom_binding structs between threads, which is unsafe -- example, dom_vers signalled retry events, and structs+socket would get deallocated in _yp_unbind. Change all yp_first (and similar) functions to understand that _yp_dobind now provides a private dom_binding and socket, which must be released using _yp_unbind. Use similar methods in the one-step yp_all function. 2) domainname caching in get* is not neccessary now that the domainname cannot change relative to ypconnect(2)'s decisions. Many fields in dom_binding struct become unused, so delete them. ok jmatthew, also tested by miod

3 years ago

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared dom_binding structs between threads, which is unsafe -- example, dom_vers signalled retry events, and structs+socket would get deallocated in _yp_unbind. Change all yp_first (and similar) functions to understand that _yp_dobind now provides a private dom_binding and socket, which must be released using _yp_unbind. Use similar methods in the one-step yp_all function. 2) domainname caching in get* is not neccessary now that the domainname cannot change relative to ypconnect(2)'s decisions. Many fields in dom_binding struct become unused, so delete them. ok jmatthew, also tested by miod

3 years ago

Move to the <limits.h> universe. review by millert, binary checking process with doug, concept with guenther

11 years ago

All these files include <stdlib.h>, so do not need to cast malloc/calloc/realloc* returns.

10 years ago

Stop publicly declaring _yp_dobind() and struct dom_binding, closing out a rant Theo wrote 24 years ago. Mark __ypexclude_{add,is,free}() as hidden

10 years ago

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared dom_binding structs between threads, which is unsafe -- example, dom_vers signalled retry events, and structs+socket would get deallocated in _yp_unbind. Change all yp_first (and similar) functions to understand that _yp_dobind now provides a private dom_binding and socket, which must be released using _yp_unbind. Use similar methods in the one-step yp_all function. 2) domainname caching in get* is not neccessary now that the domainname cannot change relative to ypconnect(2)'s decisions. Many fields in dom_binding struct become unused, so delete them. ok jmatthew, also tested by miod

3 years ago

ypmatch_cache.c

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared dom_binding structs between threads, which is unsafe -- example, dom_vers signalled retry events, and structs+socket would get deallocated in _yp_unbind. Change all yp_first (and similar) functions to understand that _yp_dobind now provides a private dom_binding and socket, which must be released using _yp_unbind. Use similar methods in the one-step yp_all function. 2) domainname caching in get* is not neccessary now that the domainname cannot change relative to ypconnect(2)'s decisions. Many fields in dom_binding struct become unused, so delete them. ok jmatthew, also tested by miod

3 years ago

Wrap <rpcsvc/ypclnt.h> so that calls go direct and the symbols are all weak

10 years ago