just playing with tangled
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

fileset, revset: settle on optionally-quoted pattern syntax

Suppose revsets and filesets are primarily used in command shell, it would be
annoying if quoting is required in addition to the shell quoting. We might also
want to relax the revset parser to allow bare * in glob string.

Closes #2101

+3 -5
+3 -3
docs/revsets.md
··· 407 407 408 408 ## String patterns 409 409 410 - Functions that perform string matching support the following pattern syntax: 410 + Functions that perform string matching support the following pattern syntax (the 411 + quotes are optional): 411 412 412 - * `"string"`, or `string` (the quotes are optional), or `substring:"string"`: 413 - Matches strings that contain `string`. 413 + * `"string"` or `substring:"string"`: Matches strings that contain `string`. 414 414 * `exact:"string"`: Matches strings exactly equal to `string`. 415 415 * `glob:"pattern"`: Matches strings with Unix-style shell [wildcard 416 416 `pattern`](https://docs.rs/glob/latest/glob/struct.Pattern.html).
-1
lib/src/fileset.pest
··· 61 61 | "" 62 62 } 63 63 64 - // TODO: change rhs to string_literal to require quoting? #2101 65 64 string_pattern = { 66 65 strict_identifier 67 66 ~ pattern_kind_op
-1
lib/src/revset.pest
··· 88 88 | "" 89 89 } 90 90 91 - // TODO: change rhs to string_literal to require quoting? #2101 92 91 string_pattern = { strict_identifier ~ pattern_kind_op ~ symbol } 93 92 94 93 primary = {