fix: avoid an unnecessary clone

lib/src/fix.rs

···
     // Substitute the fixed file IDs into all of the affected commits. Currently,
     // fixes cannot delete or rename files, change the executable bit, or modify
     // other parts of the commit like the description.
-    repo_mut.transform_descendants(
-        root_commits.iter().cloned().collect_vec(),
-        |mut rewriter| {
-            // TODO: Build the trees in parallel before `transform_descendants()` and only
-            // keep the tree IDs in memory, so we can pass them to the rewriter.
-            let old_commit_id = rewriter.old_commit().id().clone();
-            let repo_paths = commit_paths.get(&old_commit_id).unwrap();
-            let old_tree = rewriter.old_commit().tree()?;
-            let mut tree_builder = MergedTreeBuilder::new(old_tree.id().clone());
-            let mut changes = 0;
-            for repo_path in repo_paths {
-                let old_value = old_tree.path_value(repo_path)?;
-                let new_value = old_value.map(|old_term| {
-                    if let Some(TreeValue::File { id, executable }) = old_term {
-                        let file_to_fix = FileToFix {
-                            file_id: id.clone(),
-                            repo_path: repo_path.clone(),
-                        };
-                        if let Some(new_id) = fixed_file_ids.get(&file_to_fix) {
-                            return Some(TreeValue::File {
-                                id: new_id.clone(),
-                                executable: *executable,
-                            });
-                        }
+    repo_mut.transform_descendants(root_commits, |mut rewriter| {
+        // TODO: Build the trees in parallel before `transform_descendants()` and only
+        // keep the tree IDs in memory, so we can pass them to the rewriter.
+        let old_commit_id = rewriter.old_commit().id().clone();
+        let repo_paths = commit_paths.get(&old_commit_id).unwrap();
+        let old_tree = rewriter.old_commit().tree()?;
+        let mut tree_builder = MergedTreeBuilder::new(old_tree.id().clone());
+        let mut changes = 0;
+        for repo_path in repo_paths {
+            let old_value = old_tree.path_value(repo_path)?;
+            let new_value = old_value.map(|old_term| {
+                if let Some(TreeValue::File { id, executable }) = old_term {
+                    let file_to_fix = FileToFix {
+                        file_id: id.clone(),
+                        repo_path: repo_path.clone(),
+                    };
+                    if let Some(new_id) = fixed_file_ids.get(&file_to_fix) {
+                        return Some(TreeValue::File {
+                            id: new_id.clone(),
+                            executable: *executable,
+                        });
                     }
-                    old_term.clone()
-                });
-                if new_value != old_value {
-                    tree_builder.set_or_remove(repo_path.clone(), new_value);
-                    changes += 1;
                 }
-            }
-            summary.num_checked_commits += 1;
-            if changes > 0 {
-                summary.num_fixed_commits += 1;
-                let new_tree = tree_builder.write_tree(rewriter.mut_repo().store())?;
-                let builder = rewriter.reparent();
-                let new_commit = builder.set_tree_id(new_tree).write()?;
-                summary
-                    .rewrites
-                    .insert(old_commit_id, new_commit.id().clone());
+                old_term.clone()
+            });
+            if new_value != old_value {
+                tree_builder.set_or_remove(repo_path.clone(), new_value);
+                changes += 1;
             }
-            Ok(())
-        },
-    )?;
+        }
+        summary.num_checked_commits += 1;
+        if changes > 0 {
+            summary.num_fixed_commits += 1;
+            let new_tree = tree_builder.write_tree(rewriter.mut_repo().store())?;
+            let builder = rewriter.reparent();
+            let new_commit = builder.set_tree_id(new_tree).write()?;
+            summary
+                .rewrites
+                .insert(old_commit_id, new_commit.id().clone());
+        }
+        Ok(())
+    })?;
 
     tracing::debug!(?summary);
     Ok(summary)