Reactos

[KERNEL32] Improve annotation of BaseProcess/ThreadStartup(); remove useless cast; fix PPROCESS_START_ROUTINE return type.

+17 -13
+3 -3
dll/win32/kernel32/client/proc.c
··· 445 445 } 446 446 } 447 447 448 + DECLSPEC_NORETURN 448 449 VOID 449 450 WINAPI 450 - BaseProcessStartup(PPROCESS_START_ROUTINE lpStartAddress) 451 + BaseProcessStartup( 452 + _In_ PPROCESS_START_ROUTINE lpStartAddress) 451 453 { 452 - DPRINT("BaseProcessStartup(..) - setting up exception frame.\n"); 453 - 454 454 _SEH2_TRY 455 455 { 456 456 /* Set our Start Address */
+5 -4
dll/win32/kernel32/client/thread.c
··· 50 50 return STATUS_SUCCESS; 51 51 } 52 52 53 - __declspec(noreturn) 53 + DECLSPEC_NORETURN 54 54 VOID 55 55 WINAPI 56 - BaseThreadStartup(IN LPTHREAD_START_ROUTINE lpStartAddress, 57 - IN LPVOID lpParameter) 56 + BaseThreadStartup( 57 + _In_ LPTHREAD_START_ROUTINE lpStartAddress, 58 + _In_ LPVOID lpParameter) 58 59 { 59 60 /* Attempt to call the Thread Start Address */ 60 61 _SEH2_TRY ··· 67 68 } 68 69 69 70 /* Get the exit code from the Thread Start */ 70 - ExitThread((lpStartAddress)((PVOID)lpParameter)); 71 + ExitThread(lpStartAddress(lpParameter)); 71 72 } 72 73 _SEH2_EXCEPT(UnhandledExceptionFilter(_SEH2_GetExceptionInformation())) 73 74 {
+9 -6
dll/win32/kernel32/include/kernel32.h
··· 234 234 OUT PVOID *ActCtx 235 235 ); 236 236 237 - __declspec(noreturn) 237 + DECLSPEC_NORETURN 238 238 VOID 239 239 WINAPI 240 - BaseThreadStartup(LPTHREAD_START_ROUTINE lpStartAddress, 241 - LPVOID lpParameter); 240 + BaseThreadStartup( 241 + _In_ LPTHREAD_START_ROUTINE lpStartAddress, 242 + _In_ LPVOID lpParameter); 242 243 243 - __declspec(noreturn) 244 + DECLSPEC_NORETURN 244 245 VOID 245 246 WINAPI 246 247 BaseFiberStartup(VOID); 247 248 248 - typedef UINT (WINAPI *PPROCESS_START_ROUTINE)(VOID); 249 + typedef DWORD (WINAPI *PPROCESS_START_ROUTINE)(VOID); 249 250 251 + DECLSPEC_NORETURN 250 252 VOID 251 253 WINAPI 252 - BaseProcessStartup(PPROCESS_START_ROUTINE lpStartAddress); 254 + BaseProcessStartup( 255 + _In_ PPROCESS_START_ROUTINE lpStartAddress); 253 256 254 257 PVOID 255 258 WINAPI