Clean up sharing packages and start commenting my work

hosts/index/config/sharing/rtorrent.nix

···
   interface = "sh1";
 
   dhtPort = 6771;
-  listenStartPort = 33101;
-  listenEndPort = 33103;
+  listenFromPort = 33101;
+  listenToPort = 33103;
 
   vpnListenPorts = map (port: {
     inherit port;
 
     protocol = "both";
-  }) (lib.range listenStartPort listenEndPort);
+  }) (lib.range listenFromPort listenToPort);
 
   rtorrentModule = import (flakeRoot + /packages/server/sharing/rtorrent.nix) {
     inherit dhtPort;
 
-    listenPorts = {
-      start = listenStartPort;
-      end = listenEndPort;
+    listenPortRange = {
+      from = listenFromPort;
+      to = listenToPort;
     };
   };
 

hosts/index/config/sharing/soulseek.nix

···
     vpnNamespace = interface;
   };
 
+  # TODO: I don't think I need this
   users.users.${config.services.slskd.user}.extraGroups = [ "media" ];
 }

packages/server/sharing/flood.nix

···
     ];
   };
 
+  # Override service to support listening on sockets
   systemd.services.flood.serviceConfig = {
     ExecStart = lib.mkForce (
       utils.escapeSystemdExecArgs (

packages/server/sharing/rtorrent.nix

···
 {
   dhtPort ? 6881,
-  listenPorts ? {
-    start = 6881;
-    end = 6889;
+  listenPortRange ? {
+    from = 6881;
+    to = 6889;
   },
+  openFirewall ? false,
 }:
 
 {
···
     package = pkgs-unstable.rtorrent;
 
     configText = ''
-      dht.mode.set = off
+      dht.mode.set = off # Disabled due to a bug in rtorrent 0.16
       dht.port.set = ${toString dhtPort}
-
       protocol.pex.set = yes
-
       trackers.use_udp.set = yes
-
-      network.port_range.set = ${toString listenPorts.start}-${toString listenPorts.end}
+      network.port_range.set = ${toString listenPortRange.from}-${toString listenPortRange.to}
 
       throttle.max_downloads.set = 100
       throttle.max_uploads.global.set = 300
···
       throttle.min_peers.seed.set = 1
       throttle.max_peers.seed.set = 100
 
+      # Assumes a more powerful machine
       pieces.memory.max.set = 4000M
       pieces.preload.type.set = 2
       pieces.preload.min_rate.set = 50000
 
-      #ratio.enable= # TODO: seeding ratio for sonarr/etc.
+      # TODO: seeding ratio for sonarr/etc.
+      #ratio.enable=
       #ratio.min.set=100
       #ratio.max.set=300
       #system.method.set = group.seeding.ratio.command, d.close=
···
     '';
   };
 
+  # Required override for linux-hardened kernel
   systemd.services.rtorrent.serviceConfig = {
     SystemCallFilter = lib.mkForce "@system-service";
   };
 
+  networking.firewall = lib.mkIf openFirewall {
+    allowedTCPPortRanges = [ listenPortRange ];
+    allowedUDPPortRanges = [ listenPortRange ];
+  };
+
+  # Add Flood to the rtorrent group for file management
   systemd.services.flood.serviceConfig.SupplementaryGroups = [ config.services.rtorrent.group ];
 }

packages/server/sharing/soulseek.nix

···
     domain = null;
 
     settings = {
+      # Upload limits assume a fast connection
       global = {
         upload = {
           slots = 75;
···
       };
 
       shares = {
+        # These files can contain sensitive information
         filters = [
           ".md$"
           ".log$"
           ".pydio$"
         ];
 
+        # Assumes a more powerful machine
         cache = {
           storage_mode = "memory";
           workers = 8;
···
         "^(\.?pdf|\.?docx|\.?xlsx)$"
       ];
 
+      # Numbers are measured in hours
       retention = {
-        search = 10080;
+        search = 1; # Users go offline often, invalidating search
+
+        transfers = {
+          upload = {
+            succeeded = 10080;
+            errored = 1440;
+            cancelled = 1440;
+          };
+
+          download = {
+            succeeded = 1440;
+            errored = 10080;
+            cancelled = 10080;
+          };
+        };
       };
     };
   };