refactors in preparation for search

src/database/like.v

···
 
 import entity { Like, LikeCache }
 
+// add_like adds a like to the database, returns true if this succeeds and false
+// otherwise.
+pub fn (app &DatabaseAccess) add_like(like &Like) bool {
+	sql app.db {
+		insert like into Like
+		// yeet the old cached like value
+		delete from LikeCache where post_id == like.post_id
+	} or {
+		return false
+	}
+	return true
+}
+
 // get_net_likes_for_post returns the net likes of the given post.
 pub fn (app &DatabaseAccess) get_net_likes_for_post(post_id int) int {
 	// check cache
···
 
 	return likes
 }
+
+// unlike_post removes a (dis)like from the given post, returns true if this
+// succeeds and false otherwise.
+pub fn (app &DatabaseAccess) unlike_post(post_id int, user_id int) bool {
+	sql app.db {
+		delete from Like where user_id == user_id && post_id == post_id
+		// yeet the old cached like value
+		delete from LikeCache where post_id == post_id
+	} or {
+		return false
+	}
+	return true
+}

src/database/notification.v

···
 
 import entity { Notification }
 
+// get_notification_by_id gets a notification by its given id, returns none if
+// the notification does not exist.
+pub fn (app &DatabaseAccess) get_notification_by_id(id int) ?Notification {
+	notifications := sql app.db {
+		select from Notification where id == id
+	} or { [] }
+	if notifications.len != 1 {
+		return none
+	}
+	return notifications[0]
+}
+
+// delete_notification deletes the given notification, returns true if this
+// succeeded and false otherwise.
+pub fn (app &DatabaseAccess) delete_notification(id int) bool {
+	sql app.db {
+		delete from Notification where id == id
+	} or {
+		return false
+	}
+	return true
+}
+
+// delete_notifications_for_user deletes all notifications for the given user,
+// returns true if this succeeded and false otherwise.
+pub fn (app &DatabaseAccess) delete_notifications_for_user(user_id int) bool {
+	sql app.db {
+		delete from Notification where user_id == user_id
+	} or {
+		return false
+	}
+	return true
+}
+
 // get_notifications_for gets a list of notifications for the given user.
 pub fn (app &DatabaseAccess) get_notifications_for(user_id int) []Notification {
 	notifications := sql app.db {

src/database/post.v

···
 import time
 import entity { Post, Like, LikeCache }
 
+// add_post adds a new post to the database, returns true if this succeeded and
+// false otherwise.
+pub fn (app &DatabaseAccess) add_post(post &Post) bool {
+	sql app.db {
+		insert post into Post
+	} or {
+		return false
+	}
+	return true
+}
+
 // get_post_by_id gets a post by its id, returns none if it does not exist.
 pub fn (app &DatabaseAccess) get_post_by_id(id int) ?Post {
 	posts := sql app.db {
···
 	} or { [] }
 	return posts
 }
+
+// pin_post pins the given post, returns true if this succeeds and false
+// otherwise.
+pub fn (app &DatabaseAccess) pin_post(post_id int) bool {
+	sql app.db {
+		update Post set pinned = true where id == post_id
+	} or {
+		return false
+	}
+	return true
+}
+
+// update_post updates the given post's title and body with the given title and
+// body, returns true if this succeeds and false otherwise.
+pub fn (app &DatabaseAccess) update_post(post_id int, new_title string, new_body string) bool {
+	sql app.db {
+		update Post set body = new_body, title = new_title where id == post_id
+	} or {
+		return false
+	}
+	return true
+}
+
+// delete_post deletes the given post and all likes associated with it, returns
+// true if this succeeds and false otherwise.
+pub fn (app &DatabaseAccess) delete_post(id int) bool {
+	sql app.db {
+		delete from Post where id == id
+		delete from Like where post_id == id
+		delete from LikeCache where post_id == id
+	} or {
+		return false
+	}
+	return true
+}

src/database/site.v

···
 	}
 	return configs[0]
 }
+
+// set_motd sets the site's current message of the day, returns true if this
+// succeeds and false otherwise.
+pub fn (app &DatabaseAccess) set_motd(motd string) bool {
+	sql app.db {
+		update Site set motd = motd where id == 1
+	} or {
+		return false
+	}
+	return true
+}

src/database/user.v

···
 module database
 
-import entity { User, Notification, Like, Post }
+import entity { User, Notification, Like, LikeCache, Post }
 
 // new_user creates a new user and returns their struct after creation.
 pub fn (app &DatabaseAccess) new_user(user User) ?User {
···
 	}
 	return likes.len == 1
 }
+
+// delete_user deletes the given user and their data, returns true if this
+// succeeded and false otherwise.
+pub fn (app &DatabaseAccess) delete_user(user_id int) bool {
+	sql app.db {
+		delete from User where id == user_id
+		delete from Like where user_id == user_id
+		delete from Notification where user_id == user_id
+	} or {
+		return false
+	}
+
+	// delete posts and their likes
+	posts_from_this_user := sql app.db {
+		select from Post where author_id == id
+	} or { [] }
+
+	for post in posts_from_this_user {
+		sql app.db {
+			delete from Like where post_id == post.id
+			delete from LikeCache where post_id == post.id
+		} or {
+			eprintln('failed to delete like cache for post during user deletion: ${post.id}')
+		}
+	}
+
+	sql app.db {
+		delete from Post where author_id == id
+	} or {
+		eprintln('failed to delete posts by deleting user: ${user_id}')
+	}
+
+	return true
+}

src/webapp/api.v

···
 
 @['/api/user/notification/clear']
 fn (mut app App) api_user_notification_clear(mut ctx Context, id int) veb.Result {
-	if !ctx.is_logged_in() {
+	user := app.whoami(mut ctx) or {
 		ctx.error('you are not logged in!')
 		return ctx.redirect('/login')
 	}
-	sql app.db {
-		delete from Notification where id == id
-	} or {
-		ctx.error('failed to delete notification')
-		return ctx.redirect('/inbox')
+
+	if notification := app.get_notification_by_id(id) {
+		if notification.user_id != user.id {
+			ctx.error('no such notification for user')
+			return ctx.redirect('/inbox')
+		} else {
+			if !app.delete_notification(id) {
+				ctx.error('failed to delete notification')
+				return ctx.redirect('/inbox')
+			}
+		}
+	} else {
+		ctx.error('no such notification for user')
 	}
+
 	return ctx.redirect('/inbox')
 }
 
···
 		ctx.error('you are not logged in!')
 		return ctx.redirect('/login')
 	}
-	sql app.db {
-		delete from Notification where user_id == user.id
-	} or {
+	if !app.delete_notifications_for_user(user.id) {
 		ctx.error('failed to delete notifications')
 		return ctx.redirect('/inbox')
 	}
···
 
 	if user.admin || user.id == id {
 		// yeet
-		sql app.db {
-			delete from User where id == id
-			delete from Like where user_id == id
-			delete from Notification where user_id == id
-		} or {
+		if !app.delete_user(user.id) {
 			ctx.error('failed to delete user: ${id}')
 			return ctx.redirect('/')
-		}
-
-		// delete posts and their likes
-		posts_from_this_user := sql app.db {
-			select from Post where author_id == id
-		} or { [] }
-
-		for post in posts_from_this_user {
-			sql app.db {
-				delete from Like where post_id == post.id
-				delete from LikeCache where post_id == post.id
-			} or {
-				eprintln('failed to delete like cache for post during user deletion: ${post.id}')
-			}
-		}
-
-		sql app.db {
-			delete from Post where author_id == id
-		} or {
-			eprintln('failed to delete posts by deleting user: ${user.id}')
 		}
 
 		app.auth.delete_tokens_for_user(id) or {
···
 		post.replying_to = replying_to
 	}
 
-	sql app.db {
-		insert post into Post
-	} or {
+	if !app.add_post(post) {
 		ctx.error('failed to post!')
 		println('failed to post: ${post} from user ${user.id}')
 		return ctx.redirect('/post/new')
···
 	}
 
 	if user.admin || user.id == post.author_id {
-		sql app.db {
-			delete from Post where id == id
-			delete from Like where post_id == id
-		} or {
+		if !app.delete_post(post.id) {
 			ctx.error('failed to delete post')
 			eprintln('failed to delete post: ${id}')
 			return ctx.redirect('/')
···
 	post := app.get_post_by_id(id) or { return ctx.server_error('post does not exist') }
 
 	if app.does_user_like_post(user.id, post.id) {
-		sql app.db {
-			delete from Like where user_id == user.id && post_id == post.id
-			// yeet the old cached like value
-			delete from LikeCache where post_id == post.id
-		} or {
+		if !app.unlike_post(post.id, user.id) {
 			eprintln('user ${user.id} failed to unlike post ${id}')
 			return ctx.server_error('failed to unlike post')
 		}
···
 	} else {
 		// remove the old dislike, if it exists
 		if app.does_user_dislike_post(user.id, post.id) {
-			sql app.db {
-				delete from Like where user_id == user.id && post_id == post.id
-			} or {
+			if !app.unlike_post(post.id, user.id) {
 				eprintln('user ${user.id} failed to remove dislike on post ${id} when liking it')
 			}
 		}
···
 			post_id: post.id
 			is_like: true
 		}
-		sql app.db {
-			insert like into Like
-			// yeet the old cached like value
-			delete from LikeCache where post_id == post.id
-		} or {
+		if !app.add_like(like) {
 			eprintln('user ${user.id} failed to like post ${id}')
 			return ctx.server_error('failed to like post')
 		}
···
 	post := app.get_post_by_id(id) or { return ctx.server_error('post does not exist') }
 
 	if app.does_user_dislike_post(user.id, post.id) {
-		sql app.db {
-			delete from Like where user_id == user.id && post_id == post.id
-			// yeet the old cached like value
-			delete from LikeCache where post_id == post.id
-		} or {
-			eprintln('user ${user.id} failed to unlike post ${id}')
-			return ctx.server_error('failed to unlike post')
+		if !app.unlike_post(post.id, user.id) {
+			eprintln('user ${user.id} failed to undislike post ${id}')
+			return ctx.server_error('failed to undislike post')
 		}
 		return ctx.ok('undisliked post')
 	} else {
 		// remove the old like, if it exists
 		if app.does_user_like_post(user.id, post.id) {
-			sql app.db {
-				delete from Like where user_id == user.id && post_id == post.id
-			} or {
+			if !app.unlike_post(post.id, user.id) {
 				eprintln('user ${user.id} failed to remove like on post ${id} when disliking it')
 			}
 		}
···
 			post_id: post.id
 			is_like: false
 		}
-		sql app.db {
-			insert like into Like
-			// yeet the old cached like value
-			delete from LikeCache where post_id == post.id
-		} or {
+		if !app.add_like(like) {
 			eprintln('user ${user.id} failed to dislike post ${id}')
 			return ctx.server_error('failed to dislike post')
 		}
···
 		return ctx.redirect('/')
 	}
 
-	sql app.db {
-		update Post set body = body, title = title where id == id
-	} or {
+	if !app.update_post(id, title, body) {
 		eprintln('failed to update post')
 		ctx.error('failed to update post')
 		return ctx.redirect('/')
···
 	}
 
 	if user.admin {
-		sql app.db {
-			update Post set pinned = true where id == id
-		} or {
+		if !app.pin_post(id) {
 			eprintln('failed to pin post: ${id}')
 			ctx.error('failed to pin post')
 			return ctx.redirect('/post/${id}')
···
 	}
 
 	if user.admin {
-		sql app.db {
-			update Site set motd = motd where id == 1
-		} or {
+		if !app.set_motd(motd) {
 			ctx.error('failed to set motd')
 			eprintln('failed to set motd: ${motd}')
 			return ctx.redirect('/')