confirm password, show/hide password, remove dead code

build.maple

···
 		-e POSTGRES_PASSWORD=beep \
 		--mount source=beep-data,target=/var/lib/postgresql/data \
 		-p 5432:5432 \
-		postgres:15'
+		postgres:17'
 }
 
 task:db.start = {

src/templates/register.html

···
 			required
 		>
 		<br>
-		<label for="password">password:</label>
+		<label for="password">password: <a href="#" id="view-password" style="display: inline;">view</a></label>
 		<input
 			type="password"
 			name="password"
···
 			required
 		>
 		<br>
+		<label for="confirm-password">confirm password: <a href="#" id="view-confirm-password" style="display: inline;">view</a></label>
+		<input
+			type="password"
+			name="confirm-password"
+			id="confirm-password"
+			pattern="@app.config.user.password_pattern"
+			minlength="@app.config.user.password_min_len"
+			maxlength="@app.config.user.password_max_len"
+			required
+		>
+		<br>
+		<p>passwords match: <span id="passwords-match">yes</span></p>
+		<br>
 		@if app.config.instance.invite_only
 		<label for="invite-code">invite code:</label>
 		<input type="text" name="invite-code" id="invite-code" required>
···
 	</form>
 	@end
 </div>
+
+<script>
+	const password = document.getElementById('password');
+	const confirm_password = document.getElementById('confirm-password');
+	const matches = document.getElementById('passwords-match');
+
+	const a = () => {
+		matches.innerText = password.value==confirm_password.value ? "yes" : "no";
+	};
+	password.addEventListener('input', a);
+	confirm_password.addEventListener('input', a);
+
+	const view_password = document.getElementById('view-password');
+	const view_confirm_password = document.getElementById('view-confirm-password');
+
+	const b = (elm, btn) => {
+		return event => {
+			if (elm.getAttribute('type') == 'password')
+			{
+				elm.setAttribute('type', 'text');
+				btn.innerText = 'hide';
+			}
+			else
+			{
+				elm.setAttribute('type', 'password')
+				btn.innerText = 'show';
+			}
+		};
+	};
+	view_password.addEventListener('click', b(password, view_password));
+	view_confirm_password.addEventListener('click', b(confirm_password, view_confirm_password));
+</script>
 
 @include 'partial/footer.html'

src/webapp/api.v

···
 // people from requesting searches with huge limits and straining the SQL server
 pub const search_hard_limit = 50
 
-////// util ///////
-
-const always_public_routes = [
-	'/api/user/register/',
-]
-
-fn (mut app App) public_data_check(mut ctx Context) ?veb.Result {
-	if !app.config.instance.public_data {
-		println(ctx.req.url)
-		if ctx.req.url in always_public_routes {
-			return none
-		}
-		_ := app.whoami(mut ctx) or {
-			ctx.error('not logged in')
-			return ctx.redirect('/login')
-		}
-	}
-	return none
-}
-
 ////// user //////
 
 struct HcaptchaResponse {
···
 	// validate password
 	if !app.validators.password.validate(password) {
 		ctx.error('invalid password')
+		return ctx.redirect('/register')
+	}
+
+	if password != ctx.form['confirm-password'] {
+		ctx.error('passwords do not match')
 		return ctx.redirect('/register')
 	}