feat: extract constants

scheduler/scheduler.go

···
 
 const (
 	// Email rate limiting
-	emailsPerMinutePerUser = 1
-	emailRateBurst         = 1
+	emailsPerMinutePerUser   = 1
+	emailRateBurst           = 1
+	emailsPerSecondPerUser   = emailsPerMinutePerUser / 60.0
 
 	// Cleanup intervals
 	cleanupInterval     = 24 * time.Hour
···
 		logger:      logger,
 		interval:    interval,
 		originURL:   originURL,
-		rateLimiter: ratelimit.New(1.0/60.0, emailRateBurst),
+		rateLimiter: ratelimit.New(emailsPerSecondPerUser, emailRateBurst),
 	}
 }
 

web/handlers.go

···
 const (
 	maxFeedItems          = 100
 	shortFingerprintLen   = 8
+	recentItemsLimit      = 50
+	feedCacheMaxAge       = 300 // 5 minutes
 )
 
 func (s *Server) handleIndex(w http.ResponseWriter, r *http.Request) {
···
 
 	// Add caching headers
 	w.Header().Set("Content-Type", "application/rss+xml; charset=utf-8")
-	w.Header().Set("Cache-Control", "public, max-age=300")
+	w.Header().Set("Cache-Control", fmt.Sprintf("public, max-age=%d", feedCacheMaxAge))
 	if cfg.LastRun.Valid {
 		etag := fmt.Sprintf(`"%s-%d"`, fingerprint[:shortFingerprintLen], cfg.LastRun.Time.Unix())
 		w.Header().Set("ETag", etag)
···
 	}
 	
 	for _, feed := range feeds {
-		seenItems, err := s.store.GetSeenItems(ctx, feed.ID, 50)
+		seenItems, err := s.store.GetSeenItems(ctx, feed.ID, recentItemsLimit)
 		if err != nil {
 			continue
 		}
···
 
 	// Add caching headers
 	w.Header().Set("Content-Type", "application/feed+json; charset=utf-8")
-	w.Header().Set("Cache-Control", "public, max-age=300")
+	w.Header().Set("Cache-Control", fmt.Sprintf("public, max-age=%d", feedCacheMaxAge))
 	if cfg.LastRun.Valid {
 		etag := fmt.Sprintf(`"%s-%d"`, fingerprint[:shortFingerprintLen], cfg.LastRun.Time.Unix())
 		w.Header().Set("ETag", etag)

web/server.go

···
 //go:embed templates/*
 var templatesFS embed.FS
 
+const (
+	// HTTP rate limiting
+	httpRequestsPerSecond = 10
+	httpRateLimiterBurst  = 20
+)
+
 type Server struct {
 	store       *store.DB
 	addr        string
···
 		logger:      logger,
 		tmpl:        tmpl,
 		commitHash:  commitHash,
-		rateLimiter: ratelimit.New(10, 20), // 10 req/sec, burst of 20
+		rateLimiter: ratelimit.New(httpRequestsPerSecond, httpRateLimiterBurst),
 		metrics:     NewMetrics(),
 	}
 }