Fixes property value mapping in associated user for public newsletter queries

.sqlx/query-cdb1a6f44a09c14eeb797205c71c15493f9b15791173985a33c6c01d48206996.json .sqlx/query-d193d6ec6eb816835fb673502b9a718339e5949934d5ab3a2cbdb57ff0477a4b.json

···
 {
   "db_name": "PostgreSQL",
-  "query": "\n              SELECT\n                newsletter_issues.content,\n                newsletter_issues.description,\n                newsletter_issues.published_at,\n                newsletter_issues.slug,\n                newsletter_issues.title,\n                (\n                  users.username,\n                  user_profiles.avatar_url,\n                  user_profiles.banner_url,\n                  user_profiles.display_name,\n                  user_profiles.description\n                ) AS \"user!: AssociatedUser\"\n              FROM newsletter_issues\n              JOIN users ON newsletter_issues.user_id = users.user_id\n              JOIN user_profiles ON newsletter_issues.user_id = user_profiles.user_id\n              WHERE newsletter_issues.published_at IS NOT NULL\n                AND users.username = $1\n                AND newsletter_issues.slug = $2\n              LIMIT 1\n            ",
+  "query": "\n              SELECT\n                newsletter_issues.content,\n                newsletter_issues.description,\n                newsletter_issues.published_at,\n                newsletter_issues.slug,\n                newsletter_issues.title,\n                (\n                  user_profiles.avatar_url,\n                  user_profiles.banner_url,\n                  user_profiles.description,\n                  user_profiles.display_name,\n                  users.username\n                ) AS \"user!: AssociatedUser\"\n              FROM newsletter_issues\n              JOIN users ON newsletter_issues.user_id = users.user_id\n              JOIN user_profiles ON newsletter_issues.user_id = user_profiles.user_id\n              WHERE newsletter_issues.published_at IS NOT NULL\n                AND users.username = $1\n                AND newsletter_issues.slug = $2\n              LIMIT 1\n            ",
   "describe": {
     "columns": [
       {
···
       null
     ]
   },
-  "hash": "cdb1a6f44a09c14eeb797205c71c15493f9b15791173985a33c6c01d48206996"
+  "hash": "d193d6ec6eb816835fb673502b9a718339e5949934d5ab3a2cbdb57ff0477a4b"
 }

.sqlx/query-ee6b8b1e87856f97194cd46467bad42d2f4671337c75d822435ef30a2e4b5afa.json .sqlx/query-9d3037e3bfef9b0c2b00f3e306fec3babfb52920048f7b32eb30dd1f028aff32.json

···
 {
   "db_name": "PostgreSQL",
-  "query": "\n              SELECT\n                newsletter_issues.description,\n                newsletter_issues.published_at,\n                newsletter_issues.slug,\n                newsletter_issues.title,\n                (\n                  users.username,\n                  user_profiles.avatar_url,\n                  user_profiles.banner_url,\n                  user_profiles.display_name,\n                  user_profiles.description\n                ) AS \"user!: AssociatedUser\"\n              FROM newsletter_issues\n              JOIN users ON newsletter_issues.user_id = users.user_id\n              JOIN user_profiles ON newsletter_issues.user_id = user_profiles.user_id\n              WHERE newsletter_issues.published_at IS NOT NULL\n              ORDER BY published_at DESC\n              LIMIT 10\n            ",
+  "query": "\n              SELECT\n                newsletter_issues.description,\n                newsletter_issues.published_at,\n                newsletter_issues.slug,\n                newsletter_issues.title,\n                (\n                  user_profiles.avatar_url,\n                  user_profiles.banner_url,\n                  user_profiles.description,\n                  user_profiles.display_name,\n                  users.username\n                ) AS \"user!: AssociatedUser\"\n              FROM newsletter_issues\n              JOIN users ON newsletter_issues.user_id = users.user_id\n              JOIN user_profiles ON newsletter_issues.user_id = user_profiles.user_id\n              WHERE newsletter_issues.published_at IS NOT NULL\n              ORDER BY published_at DESC\n              LIMIT 10\n            ",
   "describe": {
     "columns": [
       {
···
       null
     ]
   },
-  "hash": "ee6b8b1e87856f97194cd46467bad42d2f4671337c75d822435ef30a2e4b5afa"
+  "hash": "9d3037e3bfef9b0c2b00f3e306fec3babfb52920048f7b32eb30dd1f028aff32"
 }

.sqlx/query-ef5f2a02961a795d62468d8e132705e3e4cf1beaf5b45df0d2d9e91285c6761e.json .sqlx/query-874e988c402b4b673cf2c4a0d6bb580f09fdb6be66d340a3fcd36b97ff9b8943.json

···
 {
   "db_name": "PostgreSQL",
-  "query": "\n              SELECT\n                newsletter_issues.description,\n                newsletter_issues.published_at,\n                newsletter_issues.slug,\n                newsletter_issues.title,\n                (\n                  users.username,\n                  user_profiles.avatar_url,\n                  user_profiles.banner_url,\n                  user_profiles.display_name,\n                  user_profiles.description\n                ) AS \"user!: AssociatedUser\"\n              FROM newsletter_issues\n              JOIN users ON newsletter_issues.user_id = users.user_id\n              JOIN user_profiles ON newsletter_issues.user_id = user_profiles.user_id\n              WHERE newsletter_issues.published_at IS NOT NULL\n                AND users.username = $1\n              ORDER BY published_at DESC\n              LIMIT 10\n            ",
+  "query": "\n              SELECT\n                newsletter_issues.description,\n                newsletter_issues.published_at,\n                newsletter_issues.slug,\n                newsletter_issues.title,\n                (\n                  user_profiles.avatar_url,\n                  user_profiles.banner_url,\n                  user_profiles.description,\n                  user_profiles.display_name,\n                  users.username\n                ) AS \"user!: AssociatedUser\"\n              FROM newsletter_issues\n              JOIN users ON newsletter_issues.user_id = users.user_id\n              JOIN user_profiles ON newsletter_issues.user_id = user_profiles.user_id\n              WHERE newsletter_issues.published_at IS NOT NULL\n                AND users.username = $1\n              ORDER BY published_at DESC\n              LIMIT 10\n            ",
   "describe": {
     "columns": [
       {
···
       null
     ]
   },
-  "hash": "ef5f2a02961a795d62468d8e132705e3e4cf1beaf5b45df0d2d9e91285c6761e"
+  "hash": "874e988c402b4b673cf2c4a0d6bb580f09fdb6be66d340a3fcd36b97ff9b8943"
 }

src/models/newsletter.rs

···
         Ok(self.newsletter_issue_id)
     }
 
+    // Note - For serializing nested records sqlx allows returning
+    // sequence of values, which are then mapped to the key names in
+    // order. This means the order of the columns in the query must
+    // reflect the order in the struct definition. For casted values,
+    // sqlx only checks that the column exists.
     pub async fn find_public_newsletter(
         username: String,
         slug: String,
···
                 newsletter_issues.slug,
                 newsletter_issues.title,
                 (
-                  users.username,
                   user_profiles.avatar_url,
                   user_profiles.banner_url,
+                  user_profiles.description,
                   user_profiles.display_name,
-                  user_profiles.description
+                  users.username
                 ) AS "user!: AssociatedUser"
               FROM newsletter_issues
               JOIN users ON newsletter_issues.user_id = users.user_id
···
                 newsletter_issues.slug,
                 newsletter_issues.title,
                 (
-                  users.username,
                   user_profiles.avatar_url,
                   user_profiles.banner_url,
+                  user_profiles.description,
                   user_profiles.display_name,
-                  user_profiles.description
+                  users.username
                 ) AS "user!: AssociatedUser"
               FROM newsletter_issues
               JOIN users ON newsletter_issues.user_id = users.user_id
···
                 newsletter_issues.slug,
                 newsletter_issues.title,
                 (
-                  users.username,
                   user_profiles.avatar_url,
                   user_profiles.banner_url,
+                  user_profiles.description,
                   user_profiles.display_name,
-                  user_profiles.description
+                  users.username
                 ) AS "user!: AssociatedUser"
               FROM newsletter_issues
               JOIN users ON newsletter_issues.user_id = users.user_id

tests/api/newsletters/detail/index.rs

···
 use crate::helpers::spawn_app;
-use newsletter_api::models::{NewsletterIssueAPI, PublicNewsletter};
+use newsletter_api::models::{NewsletterIssueAPI, PublicNewsletter, UserProfile};
 
 #[tokio::test]
 async fn nonexistent_path_params_return_not_found() {
···
     assert_eq!(&response_body.description, "Newsletter description");
     assert_eq!(&response_body.content, "<h2>Newsletter body as HTML</h2>",);
 }
+
+#[tokio::test]
+async fn public_newsletter_includes_associated_user() {
+    // Arrange
+    let app = spawn_app().await;
+    app.test_user.login(&app).await;
+
+    // Act 1 - Update user profile
+    UserProfile {
+        description: "Description".to_string(),
+        display_name: "Display name".to_string(),
+        bio: "Bio".to_string(),
+        user_id: app.test_user.user_id.clone(),
+    }
+    .update(&app.db_pool)
+    .await
+    .expect("Failed to update profile");
+
+    // Act 2 - Publish newsletter issue
+    app.post_admin_create_newsletter(&serde_json::json!({
+      "title": "Newsletter title",
+      "description": "Newsletter description",
+      "content": "## Newsletter body as HTML",
+      "cover_image": "",
+    }))
+    .await;
+
+    let response = app.get_admin_unpublished_newsletter_issues().await;
+    let response_body: Vec<NewsletterIssueAPI> = response.json().await.unwrap();
+    let newsletter_issue_id = response_body[0].newsletter_issue_id;
+
+    app.put_admin_publish_newsletter(
+        &newsletter_issue_id,
+        &serde_json::json!({
+          "idempotency_key": uuid::Uuid::new_v4().to_string()
+        }),
+    )
+    .await;
+
+    // Act 3 - Retrieve endpoint for existing issue
+    let response = app
+        .get_public_newsletter(&app.test_user.username, &"newsletter-title".to_string())
+        .await;
+    assert_eq!(200, response.status().as_u16());
+
+    let response_body: PublicNewsletter = response.json().await.unwrap();
+    assert_eq!(&response_body.title, "Newsletter title");
+    assert_eq!(&response_body.description, "Newsletter description");
+    assert_eq!(&response_body.content, "<h2>Newsletter body as HTML</h2>",);
+    assert_eq!(&response_body.user.description, "Description");
+    assert_eq!(&response_body.user.display_name, "Display name");
+    assert_eq!(&response_body.user.username, &app.test_user.username);
+}