refactor: extract tool registry factory to eliminate duplication

src/planning/mod.rs

···
 use crate::llm::factory::create_client;
 use crate::llm::{LlmClient, Message, ResponseContent};
 use crate::security::{SecurityValidator, permission::CliPermissionHandler};
-use crate::tools::{
-    ToolRegistry,
-    file::{ListFilesTool, ReadFileTool, WriteFileTool},
-    shell::RunCommandTool,
-};
+use crate::tools::ToolRegistry;
+use crate::tools::factory::create_default_registry;
 use std::io::{self, Write};
 use std::sync::Arc;
 
···
         let permission_handler = Arc::new(CliPermissionHandler);
 
         // Create and populate tool registry
-        let registry = ToolRegistry::new();
-        registry.register(Arc::new(ReadFileTool::new(
-            validator.clone(),
-            permission_handler.clone(),
-        )));
-        registry.register(Arc::new(WriteFileTool::new(
-            validator.clone(),
-            permission_handler.clone(),
-        )));
-        registry.register(Arc::new(ListFilesTool::new(
-            validator.clone(),
-            permission_handler.clone(),
-        )));
-        registry.register(Arc::new(RunCommandTool::new(
-            validator.clone(),
-            permission_handler.clone(),
-        )));
+        let registry = create_default_registry(validator, permission_handler);
 
         // Initialize conversation with system message
         let system_message = Message::system(PLANNING_SYSTEM_PROMPT);

src/ralph/mod.rs

···
 use crate::security::{SecurityValidator, permission::CliPermissionHandler};
 use crate::spec::{Spec, TaskStatus};
 use crate::tools::ToolRegistry;
-use crate::tools::file::{ListFilesTool, ReadFileTool, WriteFileTool};
-use crate::tools::shell::RunCommandTool;
+use crate::tools::factory::create_default_registry;
 use anyhow::{Context, Result};
 use chrono::Utc;
 use std::sync::Arc;
···
         let permission_handler = Arc::new(CliPermissionHandler);
 
         // Register tools
-        let tools = ToolRegistry::new();
-        tools.register(Arc::new(ReadFileTool::new(
-            validator.clone(),
-            permission_handler.clone(),
-        )));
-        tools.register(Arc::new(WriteFileTool::new(
-            validator.clone(),
-            permission_handler.clone(),
-        )));
-        tools.register(Arc::new(ListFilesTool::new(
-            validator.clone(),
-            permission_handler.clone(),
-        )));
-        tools.register(Arc::new(RunCommandTool::new(
-            validator.clone(),
-            permission_handler.clone(),
-        )));
+        let tools = create_default_registry(validator, permission_handler);
 
         let max_iterations = max_iterations
             .or(config.rustagent.max_iterations)

src/tools/factory.rs

···
+use crate::security::permission::PermissionHandler;
+use crate::security::SecurityValidator;
+use crate::tools::file::{ListFilesTool, ReadFileTool, WriteFileTool};
+use crate::tools::shell::RunCommandTool;
+use crate::tools::ToolRegistry;
+use std::sync::Arc;
+
+pub fn create_default_registry(
+    validator: Arc<SecurityValidator>,
+    permission_handler: Arc<dyn PermissionHandler>,
+) -> ToolRegistry {
+    let registry = ToolRegistry::new();
+
+    registry.register(Arc::new(ReadFileTool::new(
+        validator.clone(),
+        permission_handler.clone(),
+    )));
+    registry.register(Arc::new(WriteFileTool::new(
+        validator.clone(),
+        permission_handler.clone(),
+    )));
+    registry.register(Arc::new(ListFilesTool::new(
+        validator.clone(),
+        permission_handler.clone(),
+    )));
+    registry.register(Arc::new(RunCommandTool::new(
+        validator.clone(),
+        permission_handler.clone(),
+    )));
+
+    registry
+}

src/tools/mod.rs

···
     }
 }
 
+pub mod factory;
 pub mod file;
 pub mod shell;