Fix tool return message detection - use tool_return attribute

The first pass was incorrectly checking for a 'name' attribute to identify
tool return messages, but Letta's tool return messages don't have this attribute
(or it's None). Instead, tool return messages are identified by having:
- tool_return attribute (the actual return value)
- tool_call_id (to match with the call)
- status (success/error)

This fix:
- Changes first pass to detect tool returns using has_tool_return instead of has_name
- Stores ALL tool return statuses by tool_call_id (not just specific tools)
- Simplifies ignore_notification handling to check the tool_return string directly
- Moves deprecated tool check to tool_call messages where it belongs

This resolves the "unknown status" warnings that occurred because tool returns
weren't being properly collected.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[e-mail]>

bsky.py

···
             msg_type = getattr(message, 'message_type', 'unknown')
             has_tool_call_id = hasattr(message, 'tool_call_id')
             has_status = hasattr(message, 'status')
-            has_name = hasattr(message, 'name')
+            has_tool_return = hasattr(message, 'tool_return')
 
-            logger.debug(f"Message type={msg_type}, has_tool_call_id={has_tool_call_id}, has_status={has_status}, has_name={has_name}")
+            logger.debug(f"Message type={msg_type}, has_tool_call_id={has_tool_call_id}, has_status={has_status}, has_tool_return={has_tool_return}")
 
-            if has_tool_call_id and has_status and has_name:
-                logger.debug(f"  -> tool_call_id={message.tool_call_id}, status={message.status}, name={message.name}")
+            # Tool return messages are identified by having tool_return attribute, tool_call_id, and status
+            if has_tool_call_id and has_status and has_tool_return:
+                logger.debug(f"  -> tool_call_id={message.tool_call_id}, status={message.status}")
 
-                if message.name == 'add_post_to_bluesky_reply_thread':
-                    tool_call_results[message.tool_call_id] = message.status
-                    logger.debug(f"Tool result: {message.tool_call_id} -> {message.status}")
-                elif message.name == 'flag_archival_memory_for_deletion':
-                    tool_call_results[message.tool_call_id] = message.status
-                    logger.debug(f"Tool result: {message.tool_call_id} -> {message.status}")
-                elif message.name == 'ignore_notification':
-                    # Check if the tool was successful
-                    if hasattr(message, 'tool_return') and message.status == 'success':
-                        # Parse the return value to extract category and reason
-                        result_str = str(message.tool_return)
-                        if 'IGNORED_NOTIFICATION::' in result_str:
-                            parts = result_str.split('::')
-                            if len(parts) >= 3:
-                                ignore_category = parts[1]
-                                ignore_reason = parts[2]
-                                ignored_notification = True
-                                logger.info(f"🚫 Notification ignored - Category: {ignore_category}, Reason: {ignore_reason}")
-                elif message.name == 'bluesky_reply':
+                # Store the result for ANY tool that has a return - we'll match by tool_call_id later
+                tool_call_results[message.tool_call_id] = message.status
+                logger.debug(f"Stored tool result: {message.tool_call_id} -> {message.status}")
+
+                # Handle special processing for ignore_notification
+                if message.status == 'success':
+                    result_str = str(message.tool_return) if message.tool_return else ""
+                    if 'IGNORED_NOTIFICATION::' in result_str:
+                        parts = result_str.split('::')
+                        if len(parts) >= 3:
+                            ignore_category = parts[1]
+                            ignore_reason = parts[2]
+                            ignored_notification = True
+                            logger.info(f"🚫 Notification ignored - Category: {ignore_category}, Reason: {ignore_reason}")
+
+            # Check for deprecated tool in tool call messages
+            elif hasattr(message, 'tool_call') and message.tool_call:
+                if message.tool_call.name == 'bluesky_reply':
                     logger.error("DEPRECATED TOOL DETECTED: bluesky_reply is no longer supported!")
                     logger.error("Please use add_post_to_bluesky_reply_thread instead.")
                     logger.error("Update the agent's tools using register_tools.py")