fix: pass final search results to onComplete callback

Fixes issue where results were displayed but not saved to database until
page refresh. Root cause: onComplete callback accessed stale searchResults
from closure instead of updated state.

Changes:
- useSearch.searchAllUsers: onComplete now receives SearchResult[] param
- useSearch: uses setSearchResults updater to get current state
- App.tsx: updated all 3 searchAllUsers calls to use finalResults
- Removed setTimeout workarounds

Result: Extension and file upload flows now save immediately after search.

docs/git-history.json

···
 [
   {
-    "hash": "a90f3a813fd9527e8e59bb1da242e7b67555a8eb",
-    "short_hash": "a90f3a8",
+    "hash": "0afa0ffafd9b05f12d7d52c50082a54f237e09d8",
+    "short_hash": "0afa0ff",
     "author": "Ariel M. Lighty",
-    "date": "2025-12-26T16:11:04-05:00",
-    "message": "fix: pass onProgressUpdate and onComplete callbacks to searchAllUsers",
+    "date": "2025-12-26T20:20:50-05:00",
+    "message": "fix: sourceUser should be object {username, date} not string\n\nWas setting sourceUser to result.sourceUser.username (string)\nShould be result.sourceUser (SourceUser object)\n\nThis caused:\n- useSearch to call batch.map(r => r.sourceUser.username) on strings\n- .username on string returns undefined\n- batch-search-actors received null values\n- ValidationError: expected string, received null\n\nAlso caused localeCompare error when sorting undefined values.",
     "files_changed": 3
   },
   {
···
     "files_changed": 4
   },
   {
-    "hash": "9ca734749fbaa014828f8437afc5e515610afd31",
-    "short_hash": "9ca7347",
+    "hash": "581ed00fec3c0c5f472c6ff92e00bf4ed5b27e9a",
+    "short_hash": "581ed00",
     "author": "Ariel M. Lighty",
-    "date": "2025-12-26T13:37:24-05:00",
-    "message": "update documentation: extension ready for testing after API response fix",
+    "date": "2025-12-26T13:47:37-05:00",
+    "message": "fix extension import: use bulkCreate and handle uploadId param\n\nBackend fixes:\n- Use SourceAccountRepository.bulkCreate() instead of non-existent upsertSourceAccount()\n- Change redirectUrl from /results?uploadId= to /?uploadId=\n- More efficient bulk insert instead of loop\n\nFrontend fixes:\n- Add useEffect to load results when uploadId param present\n- Calls loadUploadResults(uploadId) automatically on page load\n- Cleans up URL param after loading\n\nResolves:\n- \"sourceAccountRepo.upsertSourceAccount is not a function\" error\n- \"No routes matched location /results?uploadId=...\" routing error",
     "files_changed": 4
   },
   {
···
     "files_changed": 3
   },
   {
-    "hash": "32cdee3aeac7ef986df47e0fff786b5f7471e55b",
-    "short_hash": "32cdee3",
+    "hash": "ba29fd68872913ba0a587aa7f29f97b3d373a732",
+    "short_hash": "ba29fd6",
     "author": "Ariel M. Lighty",
     "date": "2025-12-25T13:22:32-05:00",
     "message": "configure Netlify dev for monorepo with --filter flag\n\nFixed Netlify CLI monorepo detection issue by using --filter flag:\n- Updated root package.json scripts to use 'npx netlify-cli dev --filter @atlast/web'\n- Updated netlify.toml [dev] section to use npm with --prefix for framework command\n- Added monorepo development instructions to CLAUDE.md\n- Documented Windows Git Bash compatibility issue with netlify command\n\nSolution: Use 'npx netlify-cli dev --filter @atlast/web' to bypass monorepo\nproject selection prompt and specify which workspace package to run.\n\nDev server now runs successfully at http://localhost:8888 with all backend\nfunctions loaded.",
-    "files_changed": 4
+    "files_changed": 5
   },
   {
-    "hash": "ba29fd68872913ba0a587aa7f29f97b3d373a732",
-    "short_hash": "ba29fd6",
+    "hash": "32cdee3aeac7ef986df47e0fff786b5f7471e55b",
+    "short_hash": "32cdee3",
     "author": "Ariel M. Lighty",
     "date": "2025-12-25T13:22:32-05:00",
     "message": "configure Netlify dev for monorepo with --filter flag\n\nFixed Netlify CLI monorepo detection issue by using --filter flag:\n- Updated root package.json scripts to use 'npx netlify-cli dev --filter @atlast/web'\n- Updated netlify.toml [dev] section to use npm with --prefix for framework command\n- Added monorepo development instructions to CLAUDE.md\n- Documented Windows Git Bash compatibility issue with netlify command\n\nSolution: Use 'npx netlify-cli dev --filter @atlast/web' to bypass monorepo\nproject selection prompt and specify which workspace package to run.\n\nDev server now runs successfully at http://localhost:8888 with all backend\nfunctions loaded.",
-    "files_changed": 5
+    "files_changed": 4
   },
   {
     "hash": "c3e7afad396d130791d801a85cbfc9643bcd6309",

docs/graph-data.json

···
       "created_at": "2025-12-26T20:39:45.657720100-05:00",
       "updated_at": "2025-12-26T20:39:45.657720100-05:00",
       "metadata_json": "{\"branch\":\"master\",\"confidence\":95}"
+    },
+    {
+      "id": 322,
+      "change_id": "2e824556-15c7-4656-b771-1b85cc628edc",
+      "node_type": "observation",
+      "title": "onComplete callback in handleLoadUpload accesses stale searchResults from closure - state updated by searchAllUsers not visible to callback",
+      "description": null,
+      "status": "pending",
+      "created_at": "2025-12-26T20:51:55.431293100-05:00",
+      "updated_at": "2025-12-26T20:51:55.431293100-05:00",
+      "metadata_json": "{\"branch\":\"master\",\"confidence\":95}"
+    },
+    {
+      "id": 323,
+      "change_id": "88fc65bc-c2da-4df7-b79e-ba80d93e5b77",
+      "node_type": "outcome",
+      "title": "Fixed stale closure issue - onComplete now receives finalResults from useSearch state",
+      "description": null,
+      "status": "pending",
+      "created_at": "2025-12-26T20:55:36.922743800-05:00",
+      "updated_at": "2025-12-26T20:55:36.922743800-05:00",
+      "metadata_json": "{\"branch\":\"master\",\"confidence\":95}"
     }
   ],
   "edges": [
···
       "weight": 1.0,
       "rationale": "Implementation complete",
       "created_at": "2025-12-26T20:39:48.757903800-05:00"
+    },
+    {
+      "id": 313,
+      "from_node_id": 321,
+      "to_node_id": 322,
+      "from_change_id": "ac843fbc-1953-4b61-8ef3-4c88c98572f5",
+      "to_change_id": "2e824556-15c7-4656-b771-1b85cc628edc",
+      "edge_type": "leads_to",
+      "weight": 1.0,
+      "rationale": "New UX issue found",
+      "created_at": "2025-12-26T20:51:58.153139700-05:00"
+    },
+    {
+      "id": 314,
+      "from_node_id": 322,
+      "to_node_id": 323,
+      "from_change_id": "2e824556-15c7-4656-b771-1b85cc628edc",
+      "to_change_id": "88fc65bc-c2da-4df7-b79e-ba80d93e5b77",
+      "edge_type": "leads_to",
+      "weight": 1.0,
+      "rationale": "Implementation complete",
+      "created_at": "2025-12-26T20:55:40.014892600-05:00"
     }
   ]
 }

packages/web/src/App.tsx

···
       searchAllUsers(
         initialResults,
         setStatusMessage,
-        () => {
+        (finalResults) => {
           setCurrentStep("results");
 
           // Save results after search completes
-          setTimeout(() => {
-            setSearchResults((currentResults) => {
-              if (currentResults.length > 0) {
-                saveResults(uploadId, platform, currentResults);
-              }
-              return currentResults;
-            });
-          }, 1000);
+          if (finalResults.length > 0) {
+            saveResults(uploadId, platform, finalResults);
+          }
         },
         followLexicon,
       );
···
           await searchAllUsers(
             loadedResults,
             (message) => setStatusMessage(message),
-            async () => {
+            async (finalResults) => {
               // Search complete - save results
-              // Use current searchResults state which has been updated by searchAllUsers
-              const currentResults = searchResults.filter(r => !r.isSearching);
-              if (currentResults.length > 0) {
-                await saveResults(uploadId, platform, currentResults);
-              }
+              // finalResults contains the updated results with all matches found
+              await saveResults(uploadId, platform, finalResults);
             },
             followLexicon
           );
···
         setCurrentStep("home");
       }
     },
-    [setStatusMessage, setCurrentStep, setSearchResults, setAriaAnnouncement, error, currentDestinationAppId, searchAllUsers, saveResults, searchResults],
+    [setStatusMessage, setCurrentStep, setSearchResults, setAriaAnnouncement, error, currentDestinationAppId, searchAllUsers, saveResults],
   );
 
   // Login handler
···
         await searchAllUsers(
           initialResults,
           setStatusMessage,
-          () => {
+          (finalResults) => {
             setCurrentStep('results');
 
             // Save results after search completes
-            setTimeout(() => {
-              setSearchResults((currentResults) => {
-                if (currentResults.length > 0) {
-                  saveResults(uploadId, platform, currentResults);
-                }
-                return currentResults;
-              });
-            }, 1000);
+            if (finalResults.length > 0) {
+              saveResults(uploadId, platform, finalResults);
+            }
 
             // Clear import ID from URL
             const newUrl = new URL(window.location.href);

packages/web/src/hooks/useSearch.ts

···
   const searchAllUsers = useCallback(async (
     resultsToSearch: SearchResult[],
     onProgressUpdate: (message: string) => void,
-    onComplete: () => void,
+    onComplete: (finalResults: SearchResult[]) => void,
     followLexicon?: string,
   ) => {
     if (!session || resultsToSearch.length === 0) return;
···
     onProgressUpdate(
       `Search complete! Found ${totalFound} matches out of ${totalSearched} users searched.`,
     );
-    onComplete();
+
+    // Get current results from state to pass to onComplete
+    setSearchResults((currentResults) => {
+      onComplete(currentResults);
+      return currentResults;
+    });
   }, [session]);
 
   const toggleMatchSelection = useCallback((resultIndex: number, did: string) => {