chore: device config should use refs as arguments

buttplug/src/util/device_configuration.rs

···
 }
 
 fn load_protocol_configs_internal(
-  main_config_str: Option<String>,
-  user_config_str: Option<String>,
+  main_config_str: &Option<String>,
+  user_config_str: &Option<String>,
   skip_version_check: bool,
 ) -> Result<ExternalDeviceConfiguration, ButtplugDeviceError> {
   if main_config_str.is_some() {
···
   }
   // Start by loading the main config
   let main_config = load_protocol_config_from_json::<ProtocolConfiguration>(
-    &main_config_str.unwrap_or_else(|| DEVICE_CONFIGURATION_JSON.to_owned()),
+    &main_config_str.as_ref().unwrap_or(&DEVICE_CONFIGURATION_JSON.to_owned()),
     skip_version_check,
   )?;
 
···
 }
 
 pub fn load_protocol_configs(
-  main_config_str: Option<String>,
-  user_config_str: Option<String>,
+  main_config_str: &Option<String>,
+  user_config_str: &Option<String>,
   skip_version_check: bool,
 ) -> Result<DeviceConfigurationManagerBuilder, ButtplugDeviceError> {
   let mut dcm_builder = DeviceConfigurationManagerBuilder::default();
···
 }
 
 pub fn create_test_dcm(allow_raw_messages: bool) -> DeviceConfigurationManager {
-  let devices = load_protocol_configs_internal(None, None, false)
+  let devices = load_protocol_configs_internal(&None, &None, false)
     .expect("If this fails, the whole library goes with it.");
   let mut builder = DeviceConfigurationManagerBuilder::default();
   if allow_raw_messages {

buttplug/tests/test_device_config.rs

···
 #[tokio::test]
 async fn test_valid_null_version_config() {
   assert!(
-    load_protocol_configs(None, Some(BASE_VALID_VERSION_CONFIG_JSON.to_owned()), false).is_ok()
+    load_protocol_configs(&None, &Some(BASE_VALID_VERSION_CONFIG_JSON.to_owned()), false).is_ok()
   );
 }
 
···
 #[tokio::test]
 async fn test_valid_null_user_config() {
   assert!(load_protocol_configs(
-    None,
-    Some(BASE_VALID_NULL_USER_CONFIG_JSON.to_owned()),
+    &None,
+    &Some(BASE_VALID_NULL_USER_CONFIG_JSON.to_owned()),
     false
   )
   .is_ok());
···
 #[tokio::test]
 async fn test_invalid_null_version_config() {
   assert!(load_protocol_configs(
-    None,
-    Some(BASE_INVALID_VERSION_CONFIG_JSON.to_owned()),
+    &None,
+    &Some(BASE_INVALID_VERSION_CONFIG_JSON.to_owned()),
     false
   )
   .is_err());
···
 #[tokio::test]
 #[ignore = "Still need to update for new message format"]
 async fn test_basic_device_config() {
-  assert!(load_protocol_configs(Some(BASE_CONFIG_JSON.to_owned()), None, false).is_ok());
+  assert!(load_protocol_configs(&Some(BASE_CONFIG_JSON.to_owned()), &None, false).is_ok());
 }
 
 #[cfg(feature = "server")]
···
     }
   }"#;
   assert!(load_protocol_configs(
-    Some(BASE_CONFIG_JSON.to_owned()),
-    Some(user_config_json.to_owned()),
+    &Some(BASE_CONFIG_JSON.to_owned()),
+    &Some(user_config_json.to_owned()),
     false
   )
   .is_err());
···
   }
   "#;
   assert!(load_protocol_configs(
-    Some(BASE_CONFIG_JSON.to_owned()),
-    Some(user_config_json.to_owned()),
+    &Some(BASE_CONFIG_JSON.to_owned()),
+    &Some(user_config_json.to_owned()),
     false
   )
   .is_err());
···
 
 #[tokio::test]
 async fn test_server_builder_null_device_config() {
-  assert!(load_protocol_configs(None, None, false).is_ok())
+  assert!(load_protocol_configs(&None, &None, false).is_ok())
 }
 
 #[tokio::test]
 async fn test_server_builder_device_config_invalid_json() {
-  assert!(load_protocol_configs(Some("{\"Not Valid JSON\"}".to_owned()), None, false).is_err())
+  assert!(load_protocol_configs(&Some("{\"Not Valid JSON\"}".to_owned()), &None, false).is_err())
 }
 
 #[tokio::test]
···
       "protocols": {}
     }
     "#;
-  assert!(load_protocol_configs(Some(device_json.to_owned()), None, false).is_err());
+  assert!(load_protocol_configs(&Some(device_json.to_owned()), &None, false).is_err());
 }
 
 #[tokio::test]
···
       "protocols": {}
     }
     "#;
-  assert!(load_protocol_configs(None, Some(device_json.to_owned()), false).is_err());
+  assert!(load_protocol_configs(&None, &Some(device_json.to_owned()), false).is_err());
 }
 
 #[tokio::test]
 async fn test_server_builder_user_device_config_invalid_json() {
-  assert!(load_protocol_configs(None, Some("{\"Not Valid JSON\"}".to_owned()), false).is_err())
+  assert!(load_protocol_configs(&None, &Some("{\"Not Valid JSON\"}".to_owned()), false).is_err())
 }

buttplug/tests/util/device_test/client/client_v2/mod.rs

···
     None
   };
 
-  let dcm = load_protocol_configs(base_cfg, user_cfg, false)
+  let dcm = load_protocol_configs(&base_cfg, &user_cfg, false)
     .unwrap()
     .finish()
     .unwrap();

buttplug/tests/util/device_test/client/client_v3/mod.rs

···
     None
   };
 
-  let dcm = load_protocol_configs(base_cfg, user_cfg, false)
+  let dcm = load_protocol_configs(&base_cfg, &user_cfg, false)
     .unwrap()
     .finish()
     .unwrap();