Add an error log if 2FA can't be enabled #7

open

opened by

mackuba.eu 3 weeks ago targeting main from mackuba.eu/pds-gatekeeper: 2fa_error_log

Currently, if INSERT INTO two_factor_accounts fails (e.g. in my case, because the gatekeeper sqlite file wasn't writable), Gatekeeper just returns a 400 response with no content, but it doesn't return or log any errors that would indicate what exactly is going on.

options

unified split

Changed files

+4 -1

src

xrpc

com_atproto_server.rs

+4 -1

src/xrpc/com_atproto_server.rs

··· 233 .bind(&did_row.0) 234 .execute(&state.pds_gatekeeper_pool) 235 .await 236 - .map_err(|_| StatusCode::BAD_REQUEST)?; 237 238 Ok(StatusCode::OK.into_response()) 239 }

··· 233 .bind(&did_row.0) 234 .execute(&state.pds_gatekeeper_pool) 235 .await 236 + .map_err(|err| { 237 + log::error!("Error enabling 2FA: {err}"); 238 + StatusCode::BAD_REQUEST 239 + })?; 240 241 Ok(StatusCode::OK.into_response()) 242 }