keyboard stuff
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove deprecated `led_set_user` (#23979)

authored by

Joel Challis and committed by
GitHub
cb39df27 99aa4f51

+4 -19
+1 -6
docs/features/led_indicators.md
··· 21 21 The `host_keyboard_led_state()` may reflect an updated state before `led_update_user()` is called. 22 22 ::: 23 23 24 - Two deprecated functions that provide the LED state as `uint8_t`: 24 + Deprecated functions that provide the LED state as `uint8_t`: 25 25 26 - * `uint8_t led_set_user(uint8_t usb_led)` 27 26 * `uint8_t host_keyboard_leds()` 28 27 29 28 ## Configuration Options ··· 49 48 * Keymap: `bool led_update_user(led_t led_state)` 50 49 51 50 Both receives LED state as a struct parameter. Returning `true` in `led_update_user()` will allow the keyboard level code in `led_update_kb()` to run as well. Returning `false` will override the keyboard level code, depending on how the keyboard level function is set up. 52 - 53 - ::: tip 54 - This boolean return type of `led_update_user` allows for overriding keyboard LED controls, and is thus recommended over the void `led_set_user` function. 55 - ::: 56 51 57 52 ### Example of keyboard LED update implementation 58 53
-1
keyboards/converter/usb_usb/custom_matrix.cpp
··· 229 229 if (kbd2.isReady()) kbd2.SetReport(0, 0, 2, 0, 1, &usb_led); 230 230 if (kbd3.isReady()) kbd3.SetReport(0, 0, 2, 0, 1, &usb_led); 231 231 if (kbd4.isReady()) kbd4.SetReport(0, 0, 2, 0, 1, &usb_led); 232 - led_set_user(usb_led); 233 232 led_update_kb((led_t){.raw = usb_led}); 234 233 } 235 234 }
-1
keyboards/sirius/unigo66/custom_matrix.cpp
··· 216 216 kbd2.SetReport(0, 0, 2, 0, 1, &usb_led); 217 217 kbd3.SetReport(0, 0, 2, 0, 1, &usb_led); 218 218 kbd4.SetReport(0, 0, 2, 0, 1, &usb_led); 219 - led_set_user(usb_led); 220 219 led_update_kb((led_t){.raw = usb_led}); 221 220 } 222 221
+3 -8
quantum/led.c
··· 56 56 #endif 57 57 58 58 static uint32_t last_led_modification_time = 0; 59 - uint32_t last_led_activity_time(void) { 59 + 60 + uint32_t last_led_activity_time(void) { 60 61 return last_led_modification_time; 61 62 } 63 + 62 64 uint32_t last_led_activity_elapsed(void) { 63 65 return timer_elapsed32(last_led_modification_time); 64 66 } 65 - 66 - /** \brief Lock LED set callback - keymap/user level 67 - * 68 - * \deprecated Use led_update_user() instead. 69 - */ 70 - __attribute__((weak)) void led_set_user(uint8_t usb_led) {} 71 67 72 68 /** \brief Lock LED update callback - keymap/user level 73 69 * ··· 146 142 handle_backlight_caps_lock((led_t)usb_led); 147 143 #endif 148 144 149 - led_set_user(usb_led); 150 145 led_update_kb((led_t)usb_led); 151 146 } 152 147
-3
quantum/led.h
··· 48 48 49 49 void led_task(void); 50 50 51 - /* Deprecated callbacks */ 52 - void led_set_user(uint8_t usb_led); 53 - 54 51 /* Callbacks */ 55 52 bool led_update_user(led_t led_state); 56 53 bool led_update_kb(led_t led_state);