Signed-off-by: Shalabh Agarwal me@serendipty01.dev
+1
api/tangled/actorprofile.go
+7
appview/db/db.go
+26
-6
appview/db/profile.go
+6
appview/ingester.go
+1
appview/models/profile.go
+11
appview/pages/templates/user/fragments/editBio.html
+5
appview/pages/templates/user/fragments/profileCard.html
+2
appview/state/profile.go
History
4 rounds
5 comments
1 commit
expand
collapse
Signed-off-by: Shalabh Agarwal <me@serendipty01.dev>
fixes: https://tangled.org/@tangled.org/core/issues/224
expand 1 comment
1 commit
expand
collapse
Signed-off-by: Shalabh Agarwal <me@serendipty01.dev>
fixes: https://tangled.org/@tangled.org/core/issues/224
expand 1 comment
this is looking pretty neat! i'd like the pronouns column to still be nullable however. we can use pronouns sql.Null[String] in the scanner instead, and do a pronouns.Valid check before assigning to the profile.
1 commit
expand
collapse
Signed-off-by: Shalabh Agarwal <me@serendipty01.dev>
fixes: https://tangled.org/@tangled.org/core/issues/224
expand 0 comments
1 commit
expand
collapse
Signed-off-by: Shalabh Agarwal <me@serendipty01.dev>
fixes: https://tangled.org/@tangled.org/core/issues/224
expand 3 comments
thanks for the PR! couple of things:
- the timeline fails to load,
GetProfilesdoes not handle null pronouns gracefully - can we use
text-gray-500 dark:text-gray-400on the rendered field?
otherwise, quite happy with this changeset!
thanks, let me do those changes
updated the PR
lgtm thanks!